[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084450#comment-17084450 ] Erick Erickson commented on LUCENE-7788: [~dsmiley] Well, it _is_ silly to test error and fatal

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084447#comment-17084447 ] Erick Erickson commented on LUCENE-7788: Fixed, gradle_only.patch > fail precommit on

[jira] [Updated] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-7788: --- Attachment: gradle_only.patch > fail precommit on unparameterised log messages and examine

[jira] [Comment Edited] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084442#comment-17084442 ] Erick Erickson edited comment on LUCENE-7788 at 4/16/20, 12:09 AM: ---

[jira] [Updated] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson updated LUCENE-7788: --- Attachment: gradle_only.patch Status: Open (was: Open) I'm in a bit of an awkward

[jira] [Comment Edited] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084423#comment-17084423 ] Erick Erickson edited comment on LUCENE-7788 at 4/15/20, 11:02 PM: --- My

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084428#comment-17084428 ] Erick Erickson commented on LUCENE-7788: Why? What's the advantage of having yet another idiom

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084424#comment-17084424 ] David Smiley commented on LUCENE-7788: -- Can we skip this for info, warn & error please? These are

[jira] [Commented] (LUCENE-7788) fail precommit on unparameterised log messages and examine for wasted work/objects

[ https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084423#comment-17084423 ] Erick Erickson commented on LUCENE-7788: My current thinking: 1> I think I've got the gradle

[jira] [Commented] (LUCENE-9316) Incorporate all :precommit tasks into :check

[ https://issues.apache.org/jira/browse/LUCENE-9316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084410#comment-17084410 ] David Smiley commented on LUCENE-9316: -- Yay! So should I basically assume that {{gradlew check -x

[jira] [Commented] (LUCENE-7701) Refactor grouping collectors

[ https://issues.apache.org/jira/browse/LUCENE-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084365#comment-17084365 ] Mikhail Khludnev commented on LUCENE-7701: -- Hi, [~romseygeek], would you mind if I followup

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

mayya-sharipova commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r409079589 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java

[jira] [Commented] (LUCENE-9322) Discussing a unified vectors format API

[ https://issues.apache.org/jira/browse/LUCENE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084204#comment-17084204 ] Tomoko Uchida commented on LUCENE-9322: --- Hi [~jtibshirani], thank you for hard working on this!  

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r40656 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408887800 ## File path: lucene/core/src/java/org/apache/lucene/search/ScoreMode.java ## @@

[jira] [Commented] (LUCENE-9317) Resolve package name conflicts for StandardAnalyzer to allow Java module system support

[ https://issues.apache.org/jira/browse/LUCENE-9317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084123#comment-17084123 ] David Ryan commented on LUCENE-9317:   I did a new experiment. This is quite severe looking,

[jira] [Resolved] (LUCENE-9271) Make BufferedIndexInput work on a ByteBuffer

[ https://issues.apache.org/jira/browse/LUCENE-9271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9271. -- Fix Version/s: 8.6 master (9.0) Resolution: Fixed > Make

[jira] [Commented] (LUCENE-9260) Verify checksums of CFS files?

[ https://issues.apache.org/jira/browse/LUCENE-9260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084115#comment-17084115 ] ASF subversion and git services commented on LUCENE-9260: - Commit

[jira] [Resolved] (LUCENE-9260) Verify checksums of CFS files?

[ https://issues.apache.org/jira/browse/LUCENE-9260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9260. -- Fix Version/s: 8.6 master (9.0) Resolution: Fixed > Verify

[jira] [Resolved] (LUCENE-9307) Remove the ability to set the buffer size on an existing BufferedIndexInput

[ https://issues.apache.org/jira/browse/LUCENE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9307. -- Fix Version/s: master (9.0) Resolution: Fixed > Remove the ability to set the buffer

[jira] [Commented] (LUCENE-9260) Verify checksums of CFS files?

[ https://issues.apache.org/jira/browse/LUCENE-9260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084070#comment-17084070 ] ASF subversion and git services commented on LUCENE-9260: - Commit

[jira] [Commented] (LUCENE-9307) Remove the ability to set the buffer size on an existing BufferedIndexInput

[ https://issues.apache.org/jira/browse/LUCENE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084068#comment-17084068 ] ASF subversion and git services commented on LUCENE-9307: - Commit

[GitHub] [lucene-solr] jpountz merged pull request #1311: LUCENE-9260: Verify checksums of CFS files.

jpountz merged pull request #1311: LUCENE-9260: Verify checksums of CFS files. URL: https://github.com/apache/lucene-solr/pull/1311 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] jpountz merged pull request #1415: LUCENE-9307: Remove the ability to set the buffer size dynamically on BufferedIndexInput

jpountz merged pull request #1415: LUCENE-9307: Remove the ability to set the buffer size dynamically on BufferedIndexInput URL: https://github.com/apache/lucene-solr/pull/1415 This is an automated message from the Apache

[jira] [Commented] (SOLR-14408) Refactor MoreLikeThisHandler Implementation

[ https://issues.apache.org/jira/browse/SOLR-14408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083995#comment-17083995 ] Nazerke Seidan commented on SOLR-14408: --- just linked the PR > Refactor MoreLikeThisHandler

[GitHub] [lucene-solr] NazerkeBS opened a new pull request #1433: SOLR-14408 Refactor MoreLikeThisHandler implementation

NazerkeBS opened a new pull request #1433: SOLR-14408 Refactor MoreLikeThisHandler implementation URL: https://github.com/apache/lucene-solr/pull/1433 # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Commented] (SOLR-14408) Refactor MoreLikeThisHandler Implementation

[ https://issues.apache.org/jira/browse/SOLR-14408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083990#comment-17083990 ] Alessandro Benedetti commented on SOLR-14408: - can you attach a Pull Request to review? happy

[jira] [Created] (SOLR-14408) Refactor MoreLikeThisHandler Implementation

Nazerke Seidan created SOLR-14408: - Summary: Refactor MoreLikeThisHandler Implementation Key: SOLR-14408 URL: https://issues.apache.org/jira/browse/SOLR-14408 Project: Solr Issue Type:

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408712107 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r403471265 ## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ## @@ -91,6

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r403471265 ## File path: lucene/core/src/java/org/apache/lucene/search/SortField.java ## @@ -91,6

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

jpountz commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408712107 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@

[jira] [Commented] (SOLR-14013) javabin performance regressions

[ https://issues.apache.org/jira/browse/SOLR-14013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083861#comment-17083861 ] ASF subversion and git services commented on SOLR-14013: Commit

[GitHub] [lucene-solr] noblepaul merged pull request #1254: SOLR-14259: Back porting SOLR-14013 to Solr 7.7

noblepaul merged pull request #1254: SOLR-14259: Back porting SOLR-14013 to Solr 7.7 URL: https://github.com/apache/lucene-solr/pull/1254 This is an automated message from the Apache Git Service. To respond to the message,