noblepaul opened a new pull request #2065:
URL: https://github.com/apache/lucene-solr/pull/2065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/SOLR-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227087#comment-17227087
]
Ilan Ginzburg commented on SOLR-14928:
--
I pushed a first
[
https://issues.apache.org/jira/browse/SOLR-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227004#comment-17227004
]
Jan Høydahl commented on SOLR-9188:
---
If you believe you have found a similar bug in 8.6, then please
msokolov commented on a change in pull request #2063:
URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518351139
##
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##
@@ -139,6 +140,7 @@ void collectAnyHit(int doc, int
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518364159
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##
@@ -146,93 +149,114 @@ public LTRQParser(String qstr,
thelabdude commented on pull request #2010:
URL: https://github.com/apache/lucene-solr/pull/2010#issuecomment-722639840
I think this is ready for review again ... still have to create CHANGES.txt
entry and update the ref guide but let's get through another round of reviews,
esp. around
muse-dev[bot] commented on a change in pull request #2010:
URL: https://github.com/apache/lucene-solr/pull/2010#discussion_r518357932
##
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##
@@ -1401,8 +1420,7 @@ public ZkCoreNodeProps getLeaderProps(final
dweiss commented on a change in pull request #2062:
URL: https://github.com/apache/lucene-solr/pull/2062#discussion_r518352675
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/sv/SwedishMinimalStemFilterFactory.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed
janhoy commented on a change in pull request #2062:
URL: https://github.com/apache/lucene-solr/pull/2062#discussion_r518323263
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/sv/SwedishMinimalStemFilterFactory.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed
mayya-sharipova commented on a change in pull request #2063:
URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518316774
##
File path:
lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java
##
@@ -485,4 +491,186 @@ public void
mayya-sharipova commented on a change in pull request #2063:
URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518316315
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518293629
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518292659
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRInterleavingRescorer.java
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518291805
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
##
@@ -271,17
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518290312
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##
@@ -146,93 +149,114 @@ public
[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226930#comment-17226930
]
Erick Erickson commented on SOLR-8330:
--
Without thinking about it too much, I'm in favor of as
[
https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226927#comment-17226927
]
Mikhail Khludnev commented on SOLR-8673:
I think it's good. However, it's worth to add a dummy
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518269182
##
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java
##
@@ -166,64 +186,77 @@ public void
gerlowskija commented on pull request #2056:
URL: https://github.com/apache/lucene-solr/pull/2056#issuecomment-722539440
I thought of doing a `toNativeType` conversion on the "original" Collection,
but didn't like how it changed SolrInputDocument values for field-vals
supposedly
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226897#comment-17226897
]
Chris M. Hostetter edited comment on SOLR-14683 at 11/5/20, 5:47 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226897#comment-17226897
]
Chris M. Hostetter commented on SOLR-14683:
---
Where it's in the spec or not, Solr's JSON
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518217755
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
##
@@ -210,50 +216,59 @@
[
https://issues.apache.org/jira/browse/SOLR-14951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226862#comment-17226862
]
Cassandra Targett commented on SOLR-14951:
--
It looks like this didn't make it into 8.7, is there
[
https://issues.apache.org/jira/browse/SOLR-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226823#comment-17226823
]
David Smiley commented on SOLR-8330:
I'm looking at logs to debug a problem, and the logger name I see
[
https://issues.apache.org/jira/browse/SOLR-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226817#comment-17226817
]
Yevhen Tienkaiev commented on SOLR-9188:
Same issue found in 8.6
> BlockUnknown property makes
[
https://issues.apache.org/jira/browse/SOLR-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226817#comment-17226817
]
Yevhen Tienkaiev edited comment on SOLR-9188 at 11/5/20, 4:45 PM:
--
Same
saatchibhalla commented on pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#issuecomment-722489672
@sigram Would you mind taking another look at this PR whenever you have a
chance?
This is an
Erick Erickson created SOLR-14986:
-
Summary: Restrict the properties possible to define with
"property.name=value" when creating a collection
Key: SOLR-14986
URL: https://issues.apache.org/jira/browse/SOLR-14986
[
https://issues.apache.org/jira/browse/SOLR-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-14985:
-
Description:
HttpClusterStateProvider fetches and caches Aliases and Live Nodes
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518156348
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRInterleavingRescorer.java
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/SOLR-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226782#comment-17226782
]
Shalin Shekhar Mangar commented on SOLR-14985:
--
Linking to SOLR-14966 and SOLR-14967
> Slow
Shalin Shekhar Mangar created SOLR-14985:
Summary: Slow indexing and search performance when using
HttpClusterStateProvider
Key: SOLR-14985
URL: https://issues.apache.org/jira/browse/SOLR-14985
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518147905
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/SolrQueryRequestContextUtils.java
##
@@ -47,12 +47,12 @@ public static
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518145813
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRInterleavingTransformerFactory.java
##
@@ -0,0 +1,120
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518141759
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##
@@ -146,93 +149,114 @@ public
alessandrobenedetti commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r500956870
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##
@@ -146,93 +149,114 @@ public
[
https://issues.apache.org/jira/browse/SOLR-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226729#comment-17226729
]
Andrzej Bialecki commented on SOLR-14683:
-
Prometheus best practices recommend "avoiding missing
msokolov commented on a change in pull request #2063:
URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518055212
##
File path:
lucene/core/src/java/org/apache/lucene/search/comparators/TermOrdValComparator.java
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518035475
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRInterleavingRescorer.java
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
msokolov commented on a change in pull request #2047:
URL: https://github.com/apache/lucene-solr/pull/2047#discussion_r518030964
##
File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java
##
@@ -25,47 +25,22 @@
private VectorUtil() {
}
- public static
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226705#comment-17226705
]
ASF subversion and git services commented on SOLR-14749:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226674#comment-17226674
]
Andrzej Bialecki commented on SOLR-14749:
-
Thanks [~noble.paul] and [~ilan] for comments and
mocobeta commented on pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#issuecomment-722333573
The changes look okay to me; the refactoring on misc module shouldn't change
its behaviour while some classes are moved under o.a.l.misc package.
I'm going to merge it
sigram commented on pull request #1962:
URL: https://github.com/apache/lucene-solr/pull/1962#issuecomment-722317372
Merged to master.
This is an automated message from the Apache Git Service.
To respond to the message,
sigram closed pull request #1962:
URL: https://github.com/apache/lucene-solr/pull/1962
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226657#comment-17226657
]
ASF subversion and git services commented on SOLR-14749:
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226644#comment-17226644
]
ASF subversion and git services commented on LUCENE-9536:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226645#comment-17226645
]
ASF subversion and git services commented on LUCENE-9536:
-
Commit
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r517960447
##
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java
##
@@ -166,64 +186,77 @@ public void scoreFeatures(IndexSearcher
[
https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226632#comment-17226632
]
Thomas Wöckinger commented on SOLR-14923:
-
Some comments about:
{quote}When there isn't an
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517941795
##
File path:
lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##
@@ -95,7 +95,7 @@ private static BytesRef
[
https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226628#comment-17226628
]
Tim Owen commented on SOLR-8673:
I've attached a patch that I used and it allowed me to port our custom
[
https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Owen updated SOLR-8673:
---
Attachment: SOLR-8673.patch
> o.a.s.search.facet classes not public/extendable
>
dweiss commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517932599
##
File path:
lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##
@@ -95,7 +95,7 @@ private static BytesRef
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517929357
##
File path:
lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##
@@ -95,7 +95,7 @@ private static BytesRef
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517929357
##
File path:
lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##
@@ -95,7 +95,7 @@ private static BytesRef
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517910420
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/index/TestIndexSplitter.java
##
@@ -60,9 +67,9 @@ public void test() throws Exception {
[
https://issues.apache.org/jira/browse/LUCENE-9600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226594#comment-17226594
]
Tomoko Uchida commented on LUCENE-9600:
---
I opened
dweiss commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517899107
##
File path:
lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##
@@ -95,7 +95,7 @@ private static BytesRef
dweiss commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517898320
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/index/TestIndexSplitter.java
##
@@ -60,9 +67,9 @@ public void test() throws Exception {
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517897531
##
File path: lucene/test-framework/src/java/org/apache/lucene/index/DocHelper.java
##
@@ -35,7 +35,8 @@
import
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517897262
##
File path:
lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##
@@ -95,7 +95,7 @@ private static BytesRef
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517895258
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/index/TestIndexSplitter.java
##
@@ -60,9 +67,9 @@ public void test() throws Exception {
cpoerschke commented on a change in pull request #1571:
URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r517889175
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java
##
@@ -146,93 +149,114 @@ public LTRQParser(String qstr,
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517891574
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/index/MultiPassIndexSplitter.java
##
@@ -101,7 +111,7 @@ public void split(IndexReader
mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517888111
##
File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexSplitter.java
##
@@ -123,8 +118,8 @@ private SegmentCommitInfo getInfo(String
johtani commented on a change in pull request #33:
URL: https://github.com/apache/lucene-site/pull/33#discussion_r517865206
##
File path: content/core/core_news/2020-11-03-8-7-0-available.md
##
@@ -19,8 +19,8 @@ Faster sorting by field. When a doc-value field is also
indexed
mocobeta opened a new pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064
This refactors misc module to resolve package name conflicts between misc
and lucene-core.
- moves `o.a.l.document`, `o.a.l.index`, `o.a.l.search`, `o.a.l.store`,
`o.a.l.util`, and their
atris commented on a change in pull request #33:
URL: https://github.com/apache/lucene-site/pull/33#discussion_r517862652
##
File path: content/core/core_news/2020-11-03-8-7-0-available.md
##
@@ -19,8 +19,8 @@ Faster sorting by field. When a doc-value field is also
indexed
69 matches
Mail list logo