[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-05 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244635#comment-17244635 ] Tomoko Uchida commented on LUCENE-9623: --- I just wanted to make things a bit clearer. To me, there

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-05 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244601#comment-17244601 ] Tomoko Uchida commented on LUCENE-9623: --- {quote}it's actually better if it's a conscious decision

[jira] [Comment Edited] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244599#comment-17244599 ] Uwe Schindler edited comment on LUCENE-9632 at 12/5/20, 11:31 PM: --

[jira] [Commented] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244599#comment-17244599 ] Uwe Schindler commented on LUCENE-9632: --- Actually the availability of this methods are good to

[jira] [Comment Edited] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244598#comment-17244598 ] Uwe Schindler edited comment on LUCENE-9632 at 12/5/20, 11:21 PM: --

[jira] [Commented] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-05 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244598#comment-17244598 ] Uwe Schindler commented on LUCENE-9632: --- Actually the ArrayUtils and CollectionUtils timSort

[jira] [Commented] (SOLR-10732) potential optimizations in callers of SolrIndexSearcher.numDocs when docset is empty

2020-12-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244595#comment-17244595 ] David Smiley commented on SOLR-10732: - +1 to what you're doing, but at least one maybe two of the

[jira] [Commented] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-05 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244587#comment-17244587 ] Adrien Grand commented on LUCENE-9632: -- +1 to drop the ArrayUtil/CollectionUtil tim sorts, but like

[GitHub] [lucene-solr] pbruski commented on pull request #962: LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception

2020-12-05 Thread GitBox
pbruski commented on pull request #962: URL: https://github.com/apache/lucene-solr/pull/962#issuecomment-739336783 > Hi, @pbruski! Thanks for the contribution. would you mind to resolve the conflict? Not at all. Let's hope it's still green ;-)

[GitHub] [lucene-solr] mkhludnev commented on pull request #962: LUCENE-9021 QueryParser: re-use the LookaheadSuccess exception

2020-12-05 Thread GitBox
mkhludnev commented on pull request #962: URL: https://github.com/apache/lucene-solr/pull/962#issuecomment-739334232 Hi, @pbruski! Thanks for the contribution. would you mind to resolve the conflict? This is an automated

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-05 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244530#comment-17244530 ] Dawid Weiss commented on LUCENE-9623: - I don't think packages change that often and in my opinion