[
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249499#comment-17249499
]
ASF subversion and git services commented on LUCENE-9021:
-
Commit
mkhludnev merged pull request #2143:
URL: https://github.com/apache/lucene-solr/pull/2143
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-11297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249497#comment-17249497
]
Ritvik Sharma commented on SOLR-11297:
--
Try to do with replication factor =1 , it will create
[
https://issues.apache.org/jira/browse/SOLR-11297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritvik Sharma updated SOLR-11297:
-
Comment: was deleted
(was: Try to do with replication factor =1 , it will create collection, you
[
https://issues.apache.org/jira/browse/SOLR-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249484#comment-17249484
]
David Smiley commented on SOLR-14923:
-
I spent some time on it last weekend, exploring some ideas /
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-745039717
> Alas, `gradlew precommit` from the command-line on Linux box is still
angry for me:
>
> ```
> > Task :lucene:misc:compileJava
>
[
https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249464#comment-17249464
]
David Smiley commented on SOLR-14781:
-
Absolutely Gaurav; help out where you please. [~najlak] if you
[
https://issues.apache.org/jira/browse/SOLR-14003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-14003.
---
Resolution: Won't Fix
> Refactor code to avoid reading state of replica from the data object
>
[
https://issues.apache.org/jira/browse/SOLR-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-14089.
---
Resolution: Won't Fix
> Create a ShardStateProvider backed by shard terms
>
noblepaul commented on pull request #1071:
URL: https://github.com/apache/lucene-solr/pull/1071#issuecomment-745026931
Will not fix
This is an automated message from the Apache Git Service.
To respond to the message, please
noblepaul closed pull request #1071:
URL: https://github.com/apache/lucene-solr/pull/1071
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249462#comment-17249462
]
ASF subversion and git services commented on SOLR-14977:
Commit
noblepaul merged pull request #2099:
URL: https://github.com/apache/lucene-solr/pull/2099
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gerlowskija opened a new pull request #2146:
URL: https://github.com/apache/lucene-solr/pull/2146
# Description
TopLevelJoinQuery currently converts ordinals of the "from" field into
ordinals of the "to" field, even when the "from" and "to" field are the same
and have the same
[
https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249444#comment-17249444
]
Chris M. Hostetter commented on SOLR-15047:
---
i started working on this, but am currently
[
https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15048:
--
Description:
while working on SOLR-15047, I realized I wasn't really clear on what the
[
https://issues.apache.org/jira/browse/SOLR-15048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15048:
--
Attachment: SOLR-15048.patch
Status: Open (was: Open)
> collapse + query
Jason Gerlowski created SOLR-15049:
--
Summary: Optimize TopLevelJoinQuery "self joins"
Key: SOLR-15049
URL: https://issues.apache.org/jira/browse/SOLR-15049
Project: Solr
Issue Type:
Chris M. Hostetter created SOLR-15048:
-
Summary: collapse + query elevation behaves inconsistenty w/ 'null
group' docs depending on group head selector
Key: SOLR-15048
URL:
muse-dev[bot] commented on a change in pull request #2132:
URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r542964749
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java
##
@@ -545,6 +557,18 @@ public void open() throws
[
https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raj Yadav updated SOLR-15045:
-
Description:
Hi All,
When we issue commit through curl command, not all the shards are getting
`start
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249387#comment-17249387
]
Timothy Potter commented on SOLR-15036:
---
[~jbernste] Does drill only support counting per
[
https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15047:
--
Attachment: SOLR-15047.patch
Assignee: Chris M. Hostetter
Status: Open
Chris M. Hostetter created SOLR-15047:
-
Summary: 'collapse' on numeric field treats all docs with '0' in
collapse field as part of the null group
Key: SOLR-15047
URL:
mayya-sharipova commented on pull request #2126:
URL: https://github.com/apache/lucene-solr/pull/2126#issuecomment-744672083
@jtibshirani @jpountz Thank you for your review. I've address your feedback
in 7e04bdce818c3. Can you please continue the review.
mayya-sharipova merged pull request #2144:
URL: https://github.com/apache/lucene-solr/pull/2144
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gf2121 commented on pull request #2139:
URL: https://github.com/apache/lucene-solr/pull/2139#issuecomment-744637612
> This is great. I'm curious if you tested other numbers of bits per value
than 15?
The `decode15` benchmark result here only wants to tell that we can cause an
SIMD
rmuir commented on pull request #2080:
URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-744629310
> How about decoupling these two problems? First, let's fix the aggregation
of totalTermFreq and sumTotalTermFreq to explicitly catch any overflow instead
of just doing the
rmuir commented on pull request #2080:
URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-744628416
>> Hmm, but I think sumTotalTermFreq, which is per field sum of all
totalTermFreq across all terms in that field, could overflow long even today,
in and adversarial case. And
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15026:
--
Description:
MiniSolrCloudCluster makes multiple assumptions related to "SSL" that can
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249167#comment-17249167
]
Chris M. Hostetter commented on SOLR-15026:
---
{quote}Hi Chris M. Hostetter I actually think the
[
https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249157#comment-17249157
]
ASF subversion and git services commented on SOLR-15046:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter resolved SOLR-15046.
---
Fix Version/s: 8.8
Resolution: Fixed
> bin/solr check to see if solr.jetty.https.port
thelabdude merged pull request #2145:
URL: https://github.com/apache/lucene-solr/pull/2145
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
thelabdude opened a new pull request #2145:
URL: https://github.com/apache/lucene-solr/pull/2145
# Description
See JIRA: https://issues.apache.org/jira/browse/SOLR-15046
# Solution
Fix bin/solr IF statement.
# Tests
Manual test using:
```
cd solr
mikemccand commented on pull request #2080:
URL: https://github.com/apache/lucene-solr/pull/2080#issuecomment-744596272
I now understand @rmuir 's concern: because today we force sum of term freq
within a single document to fit in `int` (during this `invertState.length`
accumulation for
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249142#comment-17249142
]
Timothy Potter commented on SOLR-15036:
---
Thank you! I read that in the docs but it didn't quite
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249140#comment-17249140
]
Timothy Potter commented on SOLR-15026:
---
See: SOLR-15046
> MiniSolrCloudCluster can inconsistently
[
https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249139#comment-17249139
]
Timothy Potter commented on SOLR-15046:
---
This problem was surfaced by the changes introduced in
[
https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter updated SOLR-15046:
--
Description:
This always returns {{true}} on Mac OS X (not sure about Linux):
{code}
if [
Timothy Potter created SOLR-15046:
-
Summary: bin/solr check to see if solr.jetty.https.port should be
set always returns true
Key: SOLR-15046
URL: https://issues.apache.org/jira/browse/SOLR-15046
mayya-sharipova commented on pull request #2129:
URL: https://github.com/apache/lucene-solr/pull/2129#issuecomment-744587079
@ErickErickson Thanks for your suggestions, and letting me know about
LUCENE-9564, I will keep watching this issue.
mayya-sharipova opened a new pull request #2144:
URL: https://github.com/apache/lucene-solr/pull/2144
Files in org.apache.lucene.search.comparators package
has a wrong indent of 4 spaces instead of 2.
This patch fixes only the indent from 4 to correct 2 spaces
Backport for PR:
[
https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249133#comment-17249133
]
Timothy Potter commented on SOLR-12182:
---
It looks like it is bad BASH logic :P This always
[
https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249118#comment-17249118
]
Timothy Potter commented on SOLR-12182:
---
It's because {{solr.jetty.https.port}} is set; ZkContainer
gf2121 commented on pull request #2113:
URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-744577425
> @gf2121 do you plan on running a full benchmark as a next step?
@jpountz Hi! I am a bit confused about the meaning of `a full benchmark`.
There has already been an
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249110#comment-17249110
]
Joel Bernstein commented on SOLR-15036:
---
>From the test cases:
{code}
rollup(
select(
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249107#comment-17249107
]
Joel Bernstein commented on SOLR-15036:
---
>From the docs:
"The drill function reads and emits the
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249104#comment-17249104
]
Joel Bernstein commented on SOLR-15036:
---
That's the expected behavior. You need to wrap drill in a
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249101#comment-17249101
]
Timothy Potter commented on SOLR-15036:
---
Ok, I have a fix for that issue but the bigger issue is
[
https://issues.apache.org/jira/browse/LUCENE-9021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249099#comment-17249099
]
Przemek Bruski commented on LUCENE-9021:
Done: https://github.com/apache/lucene-solr/pull/2143
pbruski opened a new pull request #2143:
URL: https://github.com/apache/lucene-solr/pull/2143
Same as https://github.com/apache/lucene-solr/pull/962, for branch 8.x
This is basically the same as
https://issues.apache.org/jira/browse/SOLR-11242 , but for Lucene QueryParser
#
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249098#comment-17249098
]
Joel Bernstein commented on SOLR-15036:
---
It looks like you've got nulls in the *a_d* column based
[
https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249091#comment-17249091
]
Adrien Grand commented on LUCENE-9624:
--
[~mikemccand] I merged a bit quickly from Github and I had
[
https://issues.apache.org/jira/browse/LUCENE-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249083#comment-17249083
]
Michael McCandless commented on LUCENE-9624:
Hmm, I see only the 8.x commit above? Was this
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249056#comment-17249056
]
Joel Bernstein edited comment on SOLR-15026 at 12/14/20, 4:12 PM:
--
May
[
https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249061#comment-17249061
]
Joel Bernstein edited comment on SOLR-12182 at 12/14/20, 4:12 PM:
--
Just
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249081#comment-17249081
]
Joel Bernstein commented on SOLR-15026:
---
Here is my start command:
{code}
bin/solr start -c
{code}
mikemccand commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-744542544
> > I think this method serves an important purpose/use-case: it lets you
efficiently clear the whole index, transactionally, so that e.g. searchers can
see the old
[
https://issues.apache.org/jira/browse/LUCENE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249080#comment-17249080
]
Michael McCandless commented on LUCENE-9406:
Oh hello [~zacharymorn]!
As far as I know,
[
https://issues.apache.org/jira/browse/SOLR-15036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249078#comment-17249078
]
Timothy Potter commented on SOLR-15036:
---
[~jbernste] does this {{drill}} expr look correct? I'm not
[
https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249075#comment-17249075
]
Michael McCandless commented on LUCENE-9632:
We should at least run `luceneutil` to check
mikemccand commented on a change in pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#discussion_r542492206
##
File path: lucene/core/src/java/org/apache/lucene/search/IndriQuery.java
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249062#comment-17249062
]
Timothy Potter edited comment on SOLR-15026 at 12/14/20, 3:52 PM:
--
Not
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249062#comment-17249062
]
Timothy Potter edited comment on SOLR-15026 at 12/14/20, 3:51 PM:
--
Not
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249062#comment-17249062
]
Timothy Potter commented on SOLR-15026:
---
Not related to this issue ^ for sure ... so maybe open a
[
https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249061#comment-17249061
]
Joel Bernstein edited comment on SOLR-12182 at 12/14/20, 3:48 PM:
--
Just
[
https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249061#comment-17249061
]
Joel Bernstein edited comment on SOLR-12182 at 12/14/20, 3:47 PM:
--
Just
[
https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249061#comment-17249061
]
Joel Bernstein commented on SOLR-12182:
---
Just posted on different ticket but I'll post here as
mikemccand commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-744527462
Alas, `gradlew precommit` from the command-line on Linux box is still angry
for me:
```
> Task :lucene:misc:compileJava
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249056#comment-17249056
]
Joel Bernstein edited comment on SOLR-15026 at 12/14/20, 3:40 PM:
--
May
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249056#comment-17249056
]
Joel Bernstein edited comment on SOLR-15026 at 12/14/20, 3:39 PM:
--
May
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249056#comment-17249056
]
Joel Bernstein edited comment on SOLR-15026 at 12/14/20, 3:39 PM:
--
May
[
https://issues.apache.org/jira/browse/SOLR-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249056#comment-17249056
]
Joel Bernstein commented on SOLR-15026:
---
May be unrelated but I'm having SSL problems on branch_8x:
[
https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249053#comment-17249053
]
Adrien Grand commented on LUCENE-9047:
--
By the way it would be nice if we could also get rid of
mikemccand commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r542469384
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -154,14 +146,43 @@ public IndexOutput
mikemccand commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r542469154
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -154,14 +146,43 @@ public IndexOutput
mikemccand commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-744511463
> Is this error showing up in some CI environment / job execution that I can
take a further look at?
Hmm, I saw this error on running `gradlew precommit` after
[
https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249038#comment-17249038
]
Adrien Grand commented on LUCENE-9047:
--
+1 I was looking at the PR and I think that would help
mikemccand commented on a change in pull request #2138:
URL: https://github.com/apache/lucene-solr/pull/2138#discussion_r542413369
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiNormsLeafSimScorer.java
##
@@ -128,7 +128,7 @@ public boolean
[
https://issues.apache.org/jira/browse/LUCENE-9635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249008#comment-17249008
]
Michael McCandless commented on LUCENE-9635:
Thank you [~yiluncui] – this indeed looks like
jpountz commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-744450866
Even though the API is not final, it looks like the incubating JDK vector
API currently only supports little endian:
jpountz commented on pull request #2113:
URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-744426442
@gf2121 do you plan on running a full benchmark as a next step?
This is an automated message from the
jpountz commented on a change in pull request #2126:
URL: https://github.com/apache/lucene-solr/pull/2126#discussion_r542360145
##
File path: lucene/core/src/java/org/apache/lucene/search/ScoreMode.java
##
@@ -73,4 +82,16 @@ public boolean needsScores() {
public boolean
[
https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248958#comment-17248958
]
ASF subversion and git services commented on LUCENE-9636:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248957#comment-17248957
]
ASF subversion and git services commented on LUCENE-9636:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248955#comment-17248955
]
ASF subversion and git services commented on LUCENE-9636:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248956#comment-17248956
]
ASF subversion and git services commented on LUCENE-9636:
-
Commit
jpountz merged pull request #2139:
URL: https://github.com/apache/lucene-solr/pull/2139
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jpountz commented on a change in pull request #2109:
URL: https://github.com/apache/lucene-solr/pull/2109#discussion_r542333262
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50CompoundFormat.java
##
@@ -80,52 +89,46 @@ public void write(Directory
[
https://issues.apache.org/jira/browse/LUCENE-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248915#comment-17248915
]
ASF subversion and git services commented on LUCENE-9552:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248913#comment-17248913
]
ASF subversion and git services commented on LUCENE-9552:
-
Commit
iverase merged pull request #2131:
URL: https://github.com/apache/lucene-solr/pull/2131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dweiss commented on pull request #2104:
URL: https://github.com/apache/lucene-solr/pull/2104#issuecomment-744357731
Sorry, I missed this one. I think the includes approach is actually safer -
people use all kinds of IDEs, tools and stuff that produces local files which
you simply can't
vonbox commented on pull request #2118:
URL: https://github.com/apache/lucene-solr/pull/2118#issuecomment-744327073
Thanks for the hint. I added a test.
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17248808#comment-17248808
]
Ignacio Vera commented on LUCENE-9047:
--
I am wondering if the best approach for this issue is to
96 matches
Mail list logo