[GitHub] [lucene-solr] thomaswoeckinger edited a comment on pull request #2426: SOLR-15191: Fix faceting on EnumFieldType

2021-02-24 Thread GitBox
thomaswoeckinger edited a comment on pull request #2426: URL: https://github.com/apache/lucene-solr/pull/2426#issuecomment-785663364 > Instead of the instanceof checks (kinda brittle code-smell, not flexible), maybe we can call `FieldType.getNumberType() != null` ? > That is already

[GitHub] [lucene-solr] thomaswoeckinger commented on pull request #2426: SOLR-15191: Fix faceting on EnumFieldType

2021-02-24 Thread GitBox
thomaswoeckinger commented on pull request #2426: URL: https://github.com/apache/lucene-solr/pull/2426#issuecomment-785663364 > Instead of the instanceof checks (kinda brittle code-smell, not flexible), maybe we can call `FieldType.getNumberType() != null` ? > That is already done in

[GitHub] [lucene-solr] dsmiley commented on pull request #2426: SOLR-15191: Fix faceting on EnumFieldType

2021-02-24 Thread GitBox
dsmiley commented on pull request #2426: URL: https://github.com/apache/lucene-solr/pull/2426#issuecomment-785630714 Instead of the instanceof checks (kinda brittle code-smell, not flexible), maybe we can call `FieldType.getNumberType() != null` ? Can you please run all tests, e.g.

[GitHub] [lucene-solr] baisui1981 commented on a change in pull request #2343: SOLR-15100: make ConfigSetService configurable in solr.xml

2021-02-24 Thread GitBox
baisui1981 commented on a change in pull request #2343: URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582545685 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -56,11 +58,24 @@ private static final Logger log =

[GitHub] [lucene-solr] baisui1981 commented on a change in pull request #2343: SOLR-15100: make ConfigSetService configurable in solr.xml

2021-02-24 Thread GitBox
baisui1981 commented on a change in pull request #2343: URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582545153 ## File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java ## @@ -89,6 +89,8 @@ private final boolean fromZookeeper; private

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2343: SOLR-15100: make ConfigSetService configurable in solr.xml

2021-02-24 Thread GitBox
dsmiley commented on a change in pull request #2343: URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582529363 ## File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java ## @@ -89,6 +89,8 @@ private final boolean fromZookeeper; private final

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2343: SOLR-15100: make ConfigSetService configurable in solr.xml

2021-02-24 Thread GitBox
dsmiley commented on a change in pull request #2343: URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582528724 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -56,11 +58,24 @@ private static final Logger log =

[GitHub] [lucene-solr] baisui1981 commented on a change in pull request #2343: SOLR-15100: make ConfigSetService configurable in solr.xml

2021-02-24 Thread GitBox
baisui1981 commented on a change in pull request #2343: URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582437332 ## File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java ## @@ -89,6 +89,8 @@ private final boolean fromZookeeper; private

[GitHub] [lucene-solr] baisui1981 commented on a change in pull request #2343: SOLR-15100: make ConfigSetService configurable in solr.xml

2021-02-24 Thread GitBox
baisui1981 commented on a change in pull request #2343: URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582434520 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -56,11 +58,24 @@ private static final Logger log =

[jira] [Commented] (SOLR-15100) add ConfigSetService extension ability

2021-02-24 Thread bai sui (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290586#comment-17290586 ] bai sui commented on SOLR-15100: sorry,I thought I needed to click the resolved button to continue the

[jira] [Commented] (SOLR-14499) New Solr TLP site

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290543#comment-17290543 ] Jan Høydahl commented on SOLR-14499: People following a link to [https://lucene.apache.org/solr/foo]

[jira] [Updated] (SOLR-14499) New Solr TLP site

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14499: --- Attachment: (was: solr-has-moved-modal.png) > New Solr TLP site > - > >

[jira] [Updated] (SOLR-14499) New Solr TLP site

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14499: --- Attachment: solr-has-moved-modal.png > New Solr TLP site > - > >

[jira] [Commented] (SOLR-15146) Distribute Collection API command execution

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290537#comment-17290537 ] ASF subversion and git services commented on SOLR-15146: Commit

[GitHub] [lucene-solr] murblanc merged pull request #2431: SOLR-15146: remove unreachable code

2021-02-24 Thread GitBox
murblanc merged pull request #2431: URL: https://github.com/apache/lucene-solr/pull/2431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (SOLR-14499) New Solr TLP site

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14499: --- Attachment: solr-has-moved-modal.png > New Solr TLP site > - > >

[GitHub] [lucene-solr] murblanc opened a new pull request #2431: SOLR-15146: remove unreachable code

2021-02-24 Thread GitBox
murblanc opened a new pull request #2431: URL: https://github.com/apache/lucene-solr/pull/2431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290513#comment-17290513 ] ASF subversion and git services commented on SOLR-15193: Commit

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290509#comment-17290509 ] ASF subversion and git services commented on SOLR-15193: Commit

[jira] [Comment Edited] (SOLR-15191) Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing is set

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289895#comment-17289895 ] Thomas Wöckinger edited comment on SOLR-15191 at 2/24/21, 10:22 PM:

[jira] [Comment Edited] (SOLR-15191) Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing is set

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289895#comment-17289895 ] Thomas Wöckinger edited comment on SOLR-15191 at 2/24/21, 10:22 PM:

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #221: Work with basic-auth enabled SolrCloud clusters

2021-02-24 Thread GitBox
thelabdude commented on a change in pull request #221: URL: https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582307325 ## File path: api/v1beta1/solrcloud_types.go ## @@ -1022,3 +1040,37 @@ type SolrTLSOptions struct { // +optional

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #221: Work with basic-auth enabled SolrCloud clusters

2021-02-24 Thread GitBox
thelabdude commented on a change in pull request #221: URL: https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582306677 ## File path: controllers/solrcloud_controller.go ## @@ -256,6 +259,74 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request)

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #221: Work with basic-auth enabled SolrCloud clusters

2021-02-24 Thread GitBox
thelabdude commented on a change in pull request #221: URL: https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582304972 ## File path: controllers/util/solr_util.go ## @@ -1157,3 +1193,240 @@ func createZkConnectionEnvVars(solrCloud *solr.SolrCloud,

[GitHub] [lucene-solr] epugh opened a new pull request #2430: SOLR-15194: relax requirements and allow http urls.

2021-02-24 Thread GitBox
epugh opened a new pull request #2430: URL: https://github.com/apache/lucene-solr/pull/2430 # Description Allow `http` urls to work, albeit with a warning. # Solution Add the `http` protocol, and log a warning about this not being super secure! # Tests

[jira] [Commented] (LUCENE-9639) Add unit tests for SImpleTextVector format

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290254#comment-17290254 ] ASF subversion and git services commented on LUCENE-9639: - Commit

[GitHub] [lucene-solr] msokolov merged pull request #2404: LUCENE-9639: Add unit tests for SimpleTextVector format

2021-02-24 Thread GitBox
msokolov merged pull request #2404: URL: https://github.com/apache/lucene-solr/pull/2404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290240#comment-17290240 ] ASF subversion and git services commented on SOLR-15193: Commit

[jira] [Created] (SOLR-15195) Onboard committers who are not on PMC

2021-02-24 Thread Jira
Jan Høydahl created SOLR-15195: -- Summary: Onboard committers who are not on PMC Key: SOLR-15195 URL: https://issues.apache.org/jira/browse/SOLR-15195 Project: Solr Issue Type: Sub-task

[jira] [Commented] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290230#comment-17290230 ] ASF subversion and git services commented on SOLR-15193: Commit

[jira] [Commented] (SOLR-14762) Fork the git repo into two new 'lucene' and 'solr'

2021-02-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290225#comment-17290225 ] Dawid Weiss commented on SOLR-14762: I think it should be sooner than later. Solr can depend on

[jira] [Commented] (LUCENE-9802) Switch to new logo

2021-02-24 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290205#comment-17290205 ] Anshum Gupta commented on LUCENE-9802: -- Thanks Ryan! We might also need to provide this to ASF

[jira] [Commented] (SOLR-14499) New Solr TLP site

2021-02-24 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290203#comment-17290203 ] Anshum Gupta commented on SOLR-14499: - This is beautiful, thanks Jan! :) I agree with Houston too.

[jira] [Commented] (SOLR-14762) Fork the git repo into two new 'lucene' and 'solr'

2021-02-24 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290200#comment-17290200 ] Anshum Gupta commented on SOLR-14762: - Would it make sense to split the repos closer to when we can

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #221: Work with basic-auth enabled SolrCloud clusters

2021-02-24 Thread GitBox
HoustonPutman commented on a change in pull request #221: URL: https://github.com/apache/lucene-solr-operator/pull/221#discussion_r582129440 ## File path: api/v1beta1/solrcloud_types.go ## @@ -1022,3 +1040,37 @@ type SolrTLSOptions struct { // +optional

[jira] [Created] (SOLR-15194) JWTIssuerConfig only allows HTTPS urls, not HTTP, which is overly strict.

2021-02-24 Thread David Eric Pugh (Jira)
David Eric Pugh created SOLR-15194: -- Summary: JWTIssuerConfig only allows HTTPS urls, not HTTP, which is overly strict. Key: SOLR-15194 URL: https://issues.apache.org/jira/browse/SOLR-15194 Project:

[jira] [Commented] (SOLR-15178) Non-existent dependency listed in solr-core

2021-02-24 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290189#comment-17290189 ] Dawid Weiss commented on SOLR-15178: I don't understand it either. I just shaped what was present in

[GitHub] [lucene-solr] pawel-bugalski-dynatrace commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-02-24 Thread GitBox
pawel-bugalski-dynatrace commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-785282649 > The problem is this change doesn't just impact find() like the description states, but also other things like add() getting called by TermsHashPerField, a

[jira] [Commented] (LUCENE-9791) Monitor (aka Luwak) has concurrency issues related to BytesRefHash#find

2021-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290173#comment-17290173 ] Robert Muir commented on LUCENE-9791: - I attached a patch with my proposal, so you can see it

[jira] [Updated] (LUCENE-9791) Monitor (aka Luwak) has concurrency issues related to BytesRefHash#find

2021-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9791: Attachment: LUCENE-9791_example.patch > Monitor (aka Luwak) has concurrency issues related to

[GitHub] [lucene-solr] epugh commented on a change in pull request #2401: SOLR-11646: Add v2 examples for collections API

2021-02-24 Thread GitBox
epugh commented on a change in pull request #2401: URL: https://github.com/apache/lucene-solr/pull/2401#discussion_r582195690 ## File path: solr/solr-ref-guide/src/cluster-node-management.adoc ## @@ -420,7 +632,29 @@

[jira] [Commented] (SOLR-15192) Atomic update error when RTG component is involved

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290170#comment-17290170 ] Thomas Wöckinger commented on SOLR-15192: - The PR looks nearly identical, expect i didn't use

[jira] [Commented] (LUCENE-9791) Monitor (aka Luwak) has concurrency issues related to BytesRefHash#find

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290166#comment-17290166 ] Paweł Bugalski commented on LUCENE-9791: {quote}I think it is a problem if we start saying that

[jira] [Commented] (SOLR-15192) Atomic update error when RTG component is involved

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290165#comment-17290165 ] Thomas Wöckinger commented on SOLR-15192: - At the end the bug is in

[jira] [Commented] (LUCENE-9791) Monitor (aka Luwak) has concurrency issues related to BytesRefHash#find

2021-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290152#comment-17290152 ] Robert Muir commented on LUCENE-9791: - I suggested on the PR to maybe just provide a separate method

[GitHub] [lucene-solr] rmuir commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-02-24 Thread GitBox
rmuir commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-785265843 I think for this issue, if we are not going to fix the bad consumer of the API, we should consider separate method (maybe deprecated) for it to use. The problem is this

[jira] [Commented] (LUCENE-9791) Monitor (aka Luwak) has concurrency issues related to BytesRefHash#find

2021-02-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290144#comment-17290144 ] Mike Drob commented on LUCENE-9791: --- > Maybe another clean way would be some method in BytesRefHash

[jira] [Commented] (LUCENE-9791) Monitor (aka Luwak) has concurrency issues related to BytesRefHash#find

2021-02-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290140#comment-17290140 ] Mike Drob commented on LUCENE-9791: --- >From the comments on the PR: {quote}As a result it is now

[jira] [Updated] (SOLR-15146) Distribute Collection API command execution

2021-02-24 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilan Ginzburg updated SOLR-15146: - Description: Building on the distributed cluster state update changes (SOLR-14928), this ticket

[jira] [Reopened] (SOLR-15100) add ConfigSetService extension ability

2021-02-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reopened SOLR-15100: - Assignee: David Smiley Don't change the resolution please. I reviewed your PR just now --

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2343: SOLR-15100: make ConfigSetService configurable in solr.xml

2021-02-24 Thread GitBox
dsmiley commented on a change in pull request #2343: URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582174260 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -2027,6 +2027,10 @@ public ConfigSetsHandler getConfigSetsHandler() {

[GitHub] [lucene-solr] madrob commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-02-24 Thread GitBox
madrob commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-785259427 I think we agree with each other, Robert. I'll move further discussion back to the JIRA. This is an

[GitHub] [lucene-solr] rmuir commented on pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-02-24 Thread GitBox
rmuir commented on pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#issuecomment-785256914 > > As a result > > it is now possible to call BytesRefHash#find concurrently as long as there are > > no concurrent modifications to BytesRefHash instance and it is

[GitHub] [lucene-solr-operator] HoustonPutman commented on pull request #225: Fix Ingress API group for RBAC rules.

2021-02-24 Thread GitBox
HoustonPutman commented on pull request #225: URL: https://github.com/apache/lucene-solr-operator/pull/225#issuecomment-785249760 `make manifests` should always be done before submitting a PR. It's a part of the PR check, but I guess there are some file paths we don't check for the

[GitHub] [lucene-solr-operator] jward-bw commented on pull request #225: Fix Ingress API group for RBAC rules.

2021-02-24 Thread GitBox
jward-bw commented on pull request #225: URL: https://github.com/apache/lucene-solr-operator/pull/225#issuecomment-785247613 > Great find! > > That file is actually auto-generated via the comment tags in solrcloud-controller, and the command `make manifests`. > > I've made

[GitHub] [lucene-solr-operator] HoustonPutman merged pull request #225: Fix Ingress API group for RBAC rules.

2021-02-24 Thread GitBox
HoustonPutman merged pull request #225: URL: https://github.com/apache/lucene-solr-operator/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (SOLR-15192) Atomic update error when RTG component is involved

2021-02-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15192. - Resolution: Duplicate Closing as a duplicate of SOLR-13034 which has PR that fixes the matter.

[jira] [Commented] (SOLR-14499) New Solr TLP site

2021-02-24 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290082#comment-17290082 ] Cassandra Targett commented on SOLR-14499: -- I agree with Houston and like the burnt-yellow ->

[GitHub] [lucene-solr-operator] jward-bw opened a new pull request #225: Fix Ingress API group in helm chart.

2021-02-24 Thread GitBox
jward-bw opened a new pull request #225: URL: https://github.com/apache/lucene-solr-operator/pull/225 Helm chart no longer works as of this PR: https://github.com/apache/lucene-solr-operator/pull/217 This should fix the issue.

[jira] [Commented] (LUCENE-9810) Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290077#comment-17290077 ] ASF subversion and git services commented on LUCENE-9810: - Commit

[jira] [Resolved] (LUCENE-9810) Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9810. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: when generating suggestions,

[jira] [Commented] (LUCENE-9810) Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290078#comment-17290078 ] ASF subversion and git services commented on LUCENE-9810: - Commit

[GitHub] [lucene-solr] rmuir merged pull request #2427: LUCENE-9810: Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread GitBox
rmuir merged pull request #2427: URL: https://github.com/apache/lucene-solr/pull/2427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] rmuir commented on pull request #2427: LUCENE-9810: Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread GitBox
rmuir commented on pull request #2427: URL: https://github.com/apache/lucene-solr/pull/2427#issuecomment-785218829 I'm not very familiar with the suggester here, but when I see optimizations like this, it reminds me of automata intersection with lucene's term dictionary (think

[jira] [Commented] (SOLR-15178) Non-existent dependency listed in solr-core

2021-02-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290072#comment-17290072 ] Mike Drob commented on SOLR-15178: -- Ok, yea, I see what's going on now. The solr:server looks like a

[jira] [Commented] (LUCENE-9806) Hunspell: speed up affix condition checking

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290067#comment-17290067 ] ASF subversion and git services commented on LUCENE-9806: - Commit

[jira] [Commented] (LUCENE-9806) Hunspell: speed up affix condition checking

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290068#comment-17290068 ] ASF subversion and git services commented on LUCENE-9806: - Commit

[jira] [Resolved] (LUCENE-9806) Hunspell: speed up affix condition checking

2021-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9806. - Resolution: Fixed > Hunspell: speed up affix condition checking >

[jira] [Updated] (LUCENE-9806) Hunspell: speed up affix condition checking

2021-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9806: Fix Version/s: master (9.0) > Hunspell: speed up affix condition checking >

[GitHub] [lucene-solr] rmuir merged pull request #2423: LUCENE-9806: Hunspell: speed up affix condition checking

2021-02-24 Thread GitBox
rmuir merged pull request #2423: URL: https://github.com/apache/lucene-solr/pull/2423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9808) Hunspell suggestions: consider space/dash-separated words for each case variation

2021-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9808. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell suggestions: consider

[jira] [Commented] (LUCENE-9808) Hunspell suggestions: consider space/dash-separated words for each case variation

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290066#comment-17290066 ] ASF subversion and git services commented on LUCENE-9808: - Commit

[GitHub] [lucene-solr] rmuir merged pull request #2425: LUCENE-9808: Hunspell suggestions: consider space/dash-separated words for each case variation

2021-02-24 Thread GitBox
rmuir merged pull request #2425: URL: https://github.com/apache/lucene-solr/pull/2425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9811) Hunspell suggestions: speed up ngram calculation by not searching for substrings in impossible places

2021-02-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290065#comment-17290065 ] ASF subversion and git services commented on LUCENE-9811: - Commit

[jira] [Resolved] (LUCENE-9811) Hunspell suggestions: speed up ngram calculation by not searching for substrings in impossible places

2021-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9811. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell suggestions: speed up ngram

[GitHub] [lucene-solr] rmuir merged pull request #2428: LUCENE-9811: Hunspell suggestions: speed up ngram calculation…

2021-02-24 Thread GitBox
rmuir merged pull request #2428: URL: https://github.com/apache/lucene-solr/pull/2428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] madrob commented on a change in pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-02-24 Thread GitBox
madrob commented on a change in pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429#discussion_r582073943 ## File path: lucene/core/src/test/org/apache/lucene/util/TestBytesRefHash.java ## @@ -267,6 +270,44 @@ public void testFind() throws Exception {

[jira] [Commented] (SOLR-15192) Atomic update error when RTG component is involved

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290058#comment-17290058 ] Thomas Wöckinger commented on SOLR-15192: - Deletion is not an option here, as the values of all

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #2401: SOLR-11646: Add v2 examples for collections API

2021-02-24 Thread GitBox
gerlowskija commented on a change in pull request #2401: URL: https://github.com/apache/lucene-solr/pull/2401#discussion_r582081552 ## File path: solr/solr-ref-guide/src/cluster-node-management.adoc ## @@ -420,7 +632,29 @@

[jira] [Commented] (LUCENE-9791) Monitor (aka Luwak) has concurrency issues related to BytesRefHash#find

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290018#comment-17290018 ] Paweł Bugalski commented on LUCENE-9791: I've open pull request on github so that it should be

[jira] [Created] (SOLR-15193) Add Graph to the Visual Guide to Streaming Expressions and Math Expressions

2021-02-24 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-15193: - Summary: Add Graph to the Visual Guide to Streaming Expressions and Math Expressions Key: SOLR-15193 URL: https://issues.apache.org/jira/browse/SOLR-15193 Project:

[GitHub] [lucene-solr] pawel-bugalski-dynatrace opened a new pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

2021-02-24 Thread GitBox
pawel-bugalski-dynatrace opened a new pull request #2429: URL: https://github.com/apache/lucene-solr/pull/2429 # Description Replaces `scratch1` field in `BytesRefHash` with `scratch` local variable. As a result it is now possible to call `BytesRefHash#find` concurrently as long

[jira] [Updated] (SOLR-15100) add ConfigSetService extension ability

2021-02-24 Thread bai sui (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bai sui updated SOLR-15100: --- Resolution: Done Status: Resolved (was: Patch Available) > add ConfigSetService extension ability >

[GitHub] [lucene-solr] donnerpeter commented on pull request #2427: LUCENE-9810: Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread GitBox
donnerpeter commented on pull request #2427: URL: https://github.com/apache/lucene-solr/pull/2427#issuecomment-785118956 This is quite a hot spot in suggestion generation. If you have other ideas how to speed up walking all dictionary entries, please share :)

[jira] [Commented] (SOLR-15189) Tracking downloads on new Solr site

2021-02-24 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289963#comment-17289963 ] Alexandre Rafalovitch commented on SOLR-15189: -- Google Analytics is a lot more than what

[jira] [Commented] (SOLR-15192) Atomic update error when RTG component is involved

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289949#comment-17289949 ] Thomas Wöckinger commented on SOLR-15192: - [~dsmiley] Finally found the reason, really hard to

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2428: LUCENE-9811: Hunspell suggestions: speed up ngram calculation…

2021-02-24 Thread GitBox
donnerpeter opened a new pull request #2428: URL: https://github.com/apache/lucene-solr/pull/2428 # Description …by not searching for substrings in impossible places. ngram is a very expensive (O(M*M*N)) algorithm, it's worth to try to save a bit there. # Solution

[jira] [Created] (LUCENE-9811) Hunspell suggestions: speed up ngram calculation by not searching for substrings in impossible places

2021-02-24 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9811: Summary: Hunspell suggestions: speed up ngram calculation by not searching for substrings in impossible places Key: LUCENE-9811 URL:

[jira] [Commented] (SOLR-15192) Atomic update error when RTG component is involved

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289913#comment-17289913 ] Thomas Wöckinger commented on SOLR-15192: - I will try to setup a unit test which shows this

[jira] [Commented] (SOLR-15192) Atomic update error when RTG component is involved

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289910#comment-17289910 ] Thomas Wöckinger commented on SOLR-15192: - [~dsmiley] I am not absolutely sure but i think a

[jira] [Created] (SOLR-15192) Atomic update error when RTG component is involved

2021-02-24 Thread Jira
Thomas Wöckinger created SOLR-15192: --- Summary: Atomic update error when RTG component is involved Key: SOLR-15192 URL: https://issues.apache.org/jira/browse/SOLR-15192 Project: Solr Issue

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2427: LUCENE-9810: Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread GitBox
donnerpeter commented on a change in pull request #2427: URL: https://github.com/apache/lucene-solr/pull/2427#discussion_r581931504 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ## @@ -63,47 +65,57 @@ String

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2427: LUCENE-9810: Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread GitBox
donnerpeter opened a new pull request #2427: URL: https://github.com/apache/lucene-solr/pull/2427 # Description we skip roots longer than misspelled+4 anyway, so there's no need to read their arcs # Solution When we visit a node longer than needed, use

[jira] [Updated] (SOLR-15189) Tracking downloads on new Solr site

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15189: --- Description: On lucene.apache.org we use Google Analytics tracking

[jira] [Comment Edited] (SOLR-15178) Non-existent dependency listed in solr-core

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289842#comment-17289842 ] Bence Szabó edited comment on SOLR-15178 at 2/24/21, 12:34 PM: --- Thank you

[jira] [Commented] (SOLR-15191) Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing is set

2021-02-24 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17289895#comment-17289895 ] Thomas Wöckinger commented on SOLR-15191: - [~munendrasn] you may have short look on because the

[jira] [Created] (LUCENE-9810) Hunspell: when generating suggestions, skip too deep word FST subtrees

2021-02-24 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9810: Summary: Hunspell: when generating suggestions, skip too deep word FST subtrees Key: LUCENE-9810 URL: https://issues.apache.org/jira/browse/LUCENE-9810 Project:

[GitHub] [lucene-solr] thomaswoeckinger opened a new pull request #2426: SOLR-15191: Fix faceting on EnumFieldType

2021-02-24 Thread GitBox
thomaswoeckinger opened a new pull request #2426: URL: https://github.com/apache/lucene-solr/pull/2426 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the

[jira] [Created] (SOLR-15191) Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing is set

2021-02-24 Thread Jira
Thomas Wöckinger created SOLR-15191: --- Summary: Faceting on EnumFieldType does not work if allBuckets, numBuckets or missing is set Key: SOLR-15191 URL: https://issues.apache.org/jira/browse/SOLR-15191

[jira] [Created] (LUCENE-9809) Adapt Release Wizard to only release Lucene

2021-02-24 Thread Jira
Jan Høydahl created LUCENE-9809: --- Summary: Adapt Release Wizard to only release Lucene Key: LUCENE-9809 URL: https://issues.apache.org/jira/browse/LUCENE-9809 Project: Lucene - Core Issue

  1   2   >