[GitHub] [lucene] zacharymorn commented on a change in pull request #81: LUCENE-9335: [WIP] Speed up pure disjunction with BMM

2021-04-13 Thread GitBox
zacharymorn commented on a change in pull request #81: URL: https://github.com/apache/lucene/pull/81#discussion_r612957244 ## File path: lucene/core/src/java/org/apache/lucene/search/DisjunctionSumScorer.java ## @@ -45,8 +47,18 @@ protected float score(DisiWrapper topList)

[jira] [Commented] (LUCENE-9335) Add a bulk scorer for disjunctions that does dynamic pruning

2021-04-13 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320681#comment-17320681 ] Zach Chen commented on LUCENE-9335: --- bq. Actually you should be able to do it without modifying the

[GitHub] [lucene] rmuir commented on a change in pull request #82: LUCENE-9928: speed up analysis/icu regeneration

2021-04-13 Thread GitBox
rmuir commented on a change in pull request #82: URL: https://github.com/apache/lucene/pull/82#discussion_r612869465 ## File path: gradle/generation/icu.gradle ## @@ -215,6 +217,7 @@ configure(project(":lucene:analysis:icu")) { project.quietExec { executable

[GitHub] [lucene] gsmiller commented on pull request #69: LUCENE-9850: Use PFOR encoding for doc IDs (instead of FOR)

2021-04-13 Thread GitBox
gsmiller commented on pull request #69: URL: https://github.com/apache/lucene/pull/69#issuecomment-819059707 Thanks @jpountz, @rmuir ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] dweiss commented on a change in pull request #82: LUCENE-9928: speed up analysis/icu regeneration

2021-04-13 Thread GitBox
dweiss commented on a change in pull request #82: URL: https://github.com/apache/lucene/pull/82#discussion_r612692200 ## File path: gradle/generation/icu.gradle ## @@ -215,6 +217,7 @@ configure(project(":lucene:analysis:icu")) { project.quietExec { executable

[GitHub] [lucene] rmuir commented on pull request #69: LUCENE-9850: Use PFOR encoding for doc IDs (instead of FOR)

2021-04-13 Thread GitBox
rmuir commented on pull request #69: URL: https://github.com/apache/lucene/pull/69#issuecomment-818921014 Thanks @gsmiller ! I'm not really competent to review this stuff, just here for moral support. But the numbers look good to me. -- This is an automated message from the Apache Git

[GitHub] [lucene] jpountz commented on a change in pull request #69: LUCENE-9850: Use PFOR encoding for doc IDs (instead of FOR)

2021-04-13 Thread GitBox
jpountz commented on a change in pull request #69: URL: https://github.com/apache/lucene/pull/69#discussion_r608737981 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/PForUtil.java ## @@ -121,4 +167,146 @@ void skip(DataInput in) throws IOException {

[GitHub] [lucene] rmuir commented on a change in pull request #82: LUCENE-9928: speed up analysis/icu regeneration

2021-04-13 Thread GitBox
rmuir commented on a change in pull request #82: URL: https://github.com/apache/lucene/pull/82#discussion_r612641061 ## File path: gradle/generation/icu.gradle ## @@ -215,6 +217,7 @@ configure(project(":lucene:analysis:icu")) { project.quietExec { executable

[GitHub] [lucene] rmuir opened a new pull request #82: LUCENE-9928: speed up analysis/icu regeneration

2021-04-13 Thread GitBox
rmuir opened a new pull request #82: URL: https://github.com/apache/lucene/pull/82 The compilation of the library is slow, disable optimization as it doesn't speed up our usage of the gennorm2 tool. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (LUCENE-9928) speed up analysis/icu regeneration

2021-04-13 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9928: --- Summary: speed up analysis/icu regeneration Key: LUCENE-9928 URL: https://issues.apache.org/jira/browse/LUCENE-9928 Project: Lucene - Core Issue Type: Task

[GitHub] [lucene] gsmiller commented on pull request #69: LUCENE-9850: Use PFOR encoding for doc IDs (instead of FOR)

2021-04-13 Thread GitBox
gsmiller commented on pull request #69: URL: https://github.com/apache/lucene/pull/69#issuecomment-81890 @jpountz I think I've addressed all of your feedback at this point. No rush if you've got other work occupying your time right now of course, just wanted to check in and make sure

[GitHub] [lucene] rmuir commented on a change in pull request #80: LUCENE-9925: add checksums to snowball-generated files

2021-04-13 Thread GitBox
rmuir commented on a change in pull request #80: URL: https://github.com/apache/lucene/pull/80#discussion_r612614117 ## File path: gradle/generation/snowball.gradle ## @@ -114,5 +133,5 @@ configure(project(":lucene:analysis:common")) { } } - regenerate.dependsOn

[jira] [Resolved] (LUCENE-9927) Configurable BKDWriter maximum heap size

2021-04-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9927. -- Resolution: Won't Fix +1 Robert > Configurable BKDWriter maximum heap size >

[jira] [Commented] (LUCENE-9927) Configurable BKDWriter maximum heap size

2021-04-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320144#comment-17320144 ] Robert Muir commented on LUCENE-9927: - I think it would be better to use the bugfixed version in

[jira] [Created] (LUCENE-9927) Configurable BKDWriter maximum heap size

2021-04-13 Thread Andras Salamon (Jira)
Andras Salamon created LUCENE-9927: -- Summary: Configurable BKDWriter maximum heap size Key: LUCENE-9927 URL: https://issues.apache.org/jira/browse/LUCENE-9927 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-9335) Add a bulk scorer for disjunctions that does dynamic pruning

2021-04-13 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319972#comment-17319972 ] Adrien Grand commented on LUCENE-9335: -- bq. I made the following changes, and actually still saw

[GitHub] [lucene] jpountz commented on a change in pull request #81: LUCENE-9335: [WIP] Speed up pure disjunction with BMM

2021-04-13 Thread GitBox
jpountz commented on a change in pull request #81: URL: https://github.com/apache/lucene/pull/81#discussion_r612186123 ## File path: lucene/core/src/java/org/apache/lucene/search/DisjunctionSumScorer.java ## @@ -45,8 +47,18 @@ protected float score(DisiWrapper topList) throws

[jira] [Resolved] (LUCENE-9925) Add checksums to snowball-generated files

2021-04-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9925. - Fix Version/s: main (9.0) Resolution: Fixed > Add checksums to snowball-generated files

[GitHub] [lucene] dweiss merged pull request #80: LUCENE-9925: add checksums to snowball-generated files

2021-04-13 Thread GitBox
dweiss merged pull request #80: URL: https://github.com/apache/lucene/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (LUCENE-9925) Add checksums to snowball-generated files

2021-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319962#comment-17319962 ] ASF subversion and git services commented on LUCENE-9925: - Commit

[GitHub] [lucene] dweiss commented on a change in pull request #80: LUCENE-9925: add checksums to snowball-generated files

2021-04-13 Thread GitBox
dweiss commented on a change in pull request #80: URL: https://github.com/apache/lucene/pull/80#discussion_r612178745 ## File path: gradle/generation/snowball.gradle ## @@ -114,5 +133,5 @@ configure(project(":lucene:analysis:common")) { } } - regenerate.dependsOn

[GitHub] [lucene] dweiss commented on a change in pull request #80: LUCENE-9925: add checksums to snowball-generated files

2021-04-13 Thread GitBox
dweiss commented on a change in pull request #80: URL: https://github.com/apache/lucene/pull/80#discussion_r612177428 ## File path: gradle/generation/snowball.gradle ## @@ -114,5 +133,5 @@ configure(project(":lucene:analysis:common")) { } } - regenerate.dependsOn

[jira] [Comment Edited] (LUCENE-9335) Add a bulk scorer for disjunctions that does dynamic pruning

2021-04-13 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319923#comment-17319923 ] Zach Chen edited comment on LUCENE-9335 at 4/13/21, 6:08 AM: - I made some

[jira] [Commented] (LUCENE-9335) Add a bulk scorer for disjunctions that does dynamic pruning

2021-04-13 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319923#comment-17319923 ] Zach Chen commented on LUCENE-9335: --- I made some further changes to move some block max related logic

[jira] [Comment Edited] (LUCENE-9335) Add a bulk scorer for disjunctions that does dynamic pruning

2021-04-13 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319923#comment-17319923 ] Zach Chen edited comment on LUCENE-9335 at 4/13/21, 6:07 AM: - I made some

[GitHub] [lucene] zacharymorn opened a new pull request #81: LUCENE-9335: Speed up pure disjunction with BMM

2021-04-13 Thread GitBox
zacharymorn opened a new pull request #81: URL: https://github.com/apache/lucene/pull/81 This WIP PR is for discussion an review only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the