jpountz commented on pull request #455:
URL: https://github.com/apache/lucene/pull/455#issuecomment-974611343
It's reasonable to me too. I can imagine how someone would like to implement
similar logic to `MultiCollectorManager` (which internally uses
`MultiCollector#getCollectors`) but ret
reta edited a comment on pull request #455:
URL: https://github.com/apache/lucene/pull/455#issuecomment-974514163
Thanks for looking @gsmiller , we are working on experimental support of the
concurrent segment search in the OpenSearch (if you are curious, please take a
look at [1]). Since
reta commented on pull request #455:
URL: https://github.com/apache/lucene/pull/455#issuecomment-974514163
Thanks for looking @gsmiller , we are working on experimental support of the
concurrent segment search in the OpenSearch (if you are curious, please take a
look at [1]). Since we are
gsmiller commented on pull request #455:
URL: https://github.com/apache/lucene/pull/455#issuecomment-974502955
I don't have any strong opposition to making this public, but I would be
curious to understand why `MultiCollectorManager` isn't a good fit for your use
case. It looks like your d
[
https://issues.apache.org/jira/browse/LUCENE-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446675#comment-17446675
]
Greg Miller commented on LUCENE-10246:
--
[~sokolov] yeah, that's a good point. This
[
https://issues.apache.org/jira/browse/LUCENE-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10122.
--
Fix Version/s: 9.0
10.0 (main)
Resolution: Fixed
Thanks [~zhai7631]
[
https://issues.apache.org/jira/browse/LUCENE-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446661#comment-17446661
]
ASF subversion and git services commented on LUCENE-10062:
--
Co
jpountz commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-974476179
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gsmiller merged pull request #458:
URL: https://github.com/apache/lucene/pull/458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-974449903
OK, pushed the bug fix onto `branch_9_0`. @jpountz hopefully no more issues
related to this change.
--
This is an automated message from the Apache Git Service.
To respond to th
gsmiller merged pull request #459:
URL: https://github.com/apache/lucene/pull/459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446638#comment-17446638
]
Greg Miller commented on LUCENE-10245:
--
Thanks [~romseygeek]! That was along the l
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-974368142
Ok, silly bug in the test case itself. Fix is here #459. Feel free to have a
look if you like, but I think it's simple enough that I'll just merge it after
the approval checks pas
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-974357754
> I'm getting a test failure that looks caused by this change
Uh oh. Ok, looking into it. Thanks for letting me know @jpountz
--
This is an automated message from the Apa
gsmiller commented on pull request #458:
URL: https://github.com/apache/lucene/pull/458#issuecomment-974345657
Just waiting on approval steps to run and will merge. (git has too many
sharp edges for my liking, so I prefer to use the squash/merge button here :) )
--
This is an automated m
gsmiller commented on pull request #458:
URL: https://github.com/apache/lucene/pull/458#issuecomment-974345305
Looks like someone beat me to forward-porting LUCENE-10122. Just merged
`branch_9x` to get that change and resolved conflicts. So this is now just
forward-porting LUCENE-10062.
pquentin commented on pull request #445:
URL: https://github.com/apache/lucene/pull/445#issuecomment-974322287
@jpountz Thanks a lot for your help throughout the week! Your help was
invaluable, both privately and on GitHub/JIRA. I basically transcribed what you
said to me, and it worked. :
[
https://issues.apache.org/jira/browse/LUCENE-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446615#comment-17446615
]
ASF subversion and git services commented on LUCENE-10122:
--
Co
mikemccand merged pull request #454:
URL: https://github.com/apache/lucene/pull/454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
mikemccand commented on pull request #454:
URL: https://github.com/apache/lucene/pull/454#issuecomment-974291679
OK I get it! We already pushed this awesome change to 9.0 branch, main
branch, and this one is for 9.x branch! Thanks @zhaih!
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446609#comment-17446609
]
Robert Muir commented on LUCENE-10239:
--
I manually ran the analyzers benchmark fro
jpountz commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-974278354
I'm getting a test failure that looks caused by this change:
```
gradlew test --tests TestBackwardsCompatibility.testCreateNewTaxonomy
-Dtests.seed=567E100D397BFC2E -Dtest
[
https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446596#comment-17446596
]
Alan Woodward commented on LUCENE-10245:
The XXXValuesSource impls were origina
costin commented on pull request #453:
URL: https://github.com/apache/lucene/pull/453#issuecomment-974257210
To see how VHLB behaves without the branch conditional (for bpv < 56) I've
created removed the endBits field and related codepath from `get` and `set`.
With it the benchmark becomes
[
https://issues.apache.org/jira/browse/LUCENE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446585#comment-17446585
]
ASF subversion and git services commented on LUCENE-10085:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446584#comment-17446584
]
ASF subversion and git services commented on LUCENE-10085:
--
Co
jpountz merged pull request #445:
URL: https://github.com/apache/lucene/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
mikemccand commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-974213961
> Thanks @dweiss seems this is not the first time we see this error:
https://issues.apache.org/jira/browse/LUCENE-9839
Looks like this is (scarily!) pre-existing. I don't
[
https://issues.apache.org/jira/browse/LUCENE-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446547#comment-17446547
]
Michael Sokolov commented on LUCENE-10246:
--
Thanks, Greg! I think we might als
[
https://issues.apache.org/jira/browse/LUCENE-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446539#comment-17446539
]
Greg Miller edited comment on LUCENE-10246 at 11/19/21, 3:34 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446539#comment-17446539
]
Greg Miller commented on LUCENE-10246:
--
FYI [~sokolov], opened this issue based on
Greg Miller created LUCENE-10246:
Summary: Support getting counts from "association" facets
Key: LUCENE-10246
URL: https://issues.apache.org/jira/browse/LUCENE-10246
Project: Lucene - Core
Is
Greg Miller created LUCENE-10245:
Summary: Allow users to provide DocValues to (some) Facets
Implementations
Key: LUCENE-10245
URL: https://issues.apache.org/jira/browse/LUCENE-10245
Project: Lucene -
[
https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10239.
--
Resolution: Fixed
I've opened LUCENE-10243 to bump the unicode versions of the grammars. Will
[
https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446517#comment-17446517
]
ASF subversion and git services commented on LUCENE-10239:
--
Co
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-974127530
FYI, I'm merging this onto `branch_9x` as well over in #458 (no need for a
review unless someone wants to have a look). I've also updated #264 with the
non-back-compat version of
gsmiller commented on pull request #264:
URL: https://github.com/apache/lucene/pull/264#issuecomment-974125925
This is now ready for review. This is the "forward port" of the change
introduced to 9.0 on #443 (but without all the back-compat complexity for 8.x
indexes).
--
This is an aut
gsmiller commented on pull request #264:
URL: https://github.com/apache/lucene/pull/264#issuecomment-974123523
> On a related topic, while I was stumbling around in here I found we have
the option to accumulate scores in MatchingDocs which I'd be excited to explore
for doing relevance-weig
[
https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-10239:
-
Fix Version/s: 9.1
> upgrade jflex (1.7.0 -> 1.8.2)
> --
>
>
[
https://issues.apache.org/jira/browse/LUCENE-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446506#comment-17446506
]
ASF subversion and git services commented on LUCENE-10239:
--
Co
rmuir merged pull request #452:
URL: https://github.com/apache/lucene/pull/452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
rmuir commented on pull request #452:
URL: https://github.com/apache/lucene/pull/452#issuecomment-974115268
thank you @dweiss and @sarowe for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gsmiller opened a new pull request #458:
URL: https://github.com/apache/lucene/pull/458
Bring forward the two taxonomy faceting changes made against `branch_9_0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
gsmiller commented on pull request #443:
URL: https://github.com/apache/lucene/pull/443#issuecomment-974104360
I believe I've addressed all the PR feedback and got an approval from
@mikemccand, so I went ahead and merged. Happy to iterate on this further if
anyone has additional comments.
[
https://issues.apache.org/jira/browse/LUCENE-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446502#comment-17446502
]
ASF subversion and git services commented on LUCENE-10062:
--
Co
gsmiller merged pull request #443:
URL: https://github.com/apache/lucene/pull/443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r753206863
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -409,9 +410,26 @@ private void processFacetFields(
indexDrillDow
bruno-roustant commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r753194847
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -409,9 +410,26 @@ private void processFacetFields(
indexD
jpountz commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r753161661
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##
@@ -409,9 +410,26 @@ private void processFacetFields(
indexDrillDow
mikemccand commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r753134998
##
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetUtils.java
##
@@ -81,4 +82,17 @@ public long cost() {
}
};
}
+
+ /**
+
mikemccand commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r753133857
##
File path: lucene/MIGRATE.md
##
@@ -443,3 +443,16 @@ structure. Use a standard BoostQuery here instead.
Rather than using `setSort()` to change sort
mikemccand commented on a change in pull request #443:
URL: https://github.com/apache/lucene/pull/443#discussion_r751810539
##
File path: lucene/MIGRATE.md
##
@@ -443,3 +443,16 @@ structure. Use a standard BoostQuery here instead.
Rather than using `setSort()` to change sort
mikemccand commented on a change in pull request #456:
URL: https://github.com/apache/lucene/pull/456#discussion_r753122632
##
File path: lucene/CHANGES.txt
##
@@ -57,7 +57,9 @@ Optimizations
Bug Fixes
-
-(No changes)
+
+* LUCENE-10236: Update field-weig
costin edited a comment on pull request #453:
URL: https://github.com/apache/lucene/pull/453#issuecomment-973999178
I have tighten the implementation a bit, removing an extra field adding some
constants and following more the style of Packed64 with regards to the
conditionals.
In additi
rmuir commented on pull request #452:
URL: https://github.com/apache/lucene/pull/452#issuecomment-974001822
@dweiss see https://issues.apache.org/jira/browse/LUCENE-5897 for more
background on that
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
mikemccand commented on pull request #455:
URL: https://github.com/apache/lucene/pull/455#issuecomment-973999812
This sounds reasonable to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
costin commented on pull request #453:
URL: https://github.com/apache/lucene/pull/453#issuecomment-973999178
I have tighten the implementation a bit, removing an extra field adding some
constants and following more the style of Packed64 with regards to the
conditionals.
In addition upda
dweiss commented on pull request #452:
URL: https://github.com/apache/lucene/pull/452#issuecomment-973995491
I tried to look up why this no-buffer-expansion is needed. I see LUCENE-8527
and some corner cases there... but why is it used here and there and not all
across the board (some toke
pquentin commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r753067107
##
File path: lucene/CHANGES.txt
##
@@ -33,7 +33,10 @@ Other
API Changes
-
-(No changes)
+
+* LUCENE-10085: Added Weight#count on Do
jpountz commented on a change in pull request #445:
URL: https://github.com/apache/lucene/pull/445#discussion_r753016736
##
File path: lucene/CHANGES.txt
##
@@ -33,7 +33,10 @@ Other
API Changes
-
-(No changes)
+
+* LUCENE-10085: Added Weight#count on Doc
pquentin commented on pull request #445:
URL: https://github.com/apache/lucene/pull/445#issuecomment-973896793
Thank you @jpountz! Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
[
https://issues.apache.org/jira/browse/LUCENE-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated LUCENE-9229:
Description:
The new website is live, so I ran a dead-link checker on it to see if anything
is br
jpountz commented on a change in pull request #418:
URL: https://github.com/apache/lucene/pull/418#discussion_r752994952
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/CombinedFieldQuery.java
##
@@ -441,6 +491,273 @@ public boolean isCacheable(LeafReade
[
https://issues.apache.org/jira/browse/LUCENE-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated LUCENE-9229:
Description:
The new website is live, so I ran a dead-link checker on it to see if anything
is br
janhoy merged pull request #2604:
URL: https://github.com/apache/lucene-solr/pull/2604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
costin commented on pull request #453:
URL: https://github.com/apache/lucene/pull/453#issuecomment-973879755
I've done more benchmarking with a variant of Packed64 that uses the
`VarHandle` `int` and `short` variant to read memory when dealing with a
smaller bpv (<=32 for `int`, <=16 for `
66 matches
Mail list logo
