[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766443769 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: If we are fine wi

[GitHub] [lucene] dweiss commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
dweiss commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766442867 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: Yeah.. shadowing ot

[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766338933 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: > Options 3 - fak

[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766414279 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: Here is the size

[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766338933 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: > Options 3 - fak

[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766338933 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: > Options 3 - fak

[GitHub] [lucene] gsmiller commented on pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets

2021-12-09 Thread GitBox
gsmiller commented on pull request #509: URL: https://github.com/apache/lucene/pull/509#issuecomment-990550171 @mdmarshmallow right got it. I wonder if an actual tree is really necessary of if it's really just still a map of "path" -> ordRange? There's no need to traverse the "tree" struct

[GitHub] [lucene-solr] madrob opened a new pull request #2627: SOLR-15843

2021-12-09 Thread GitBox
madrob opened a new pull request #2627: URL: https://github.com/apache/lucene-solr/pull/2627 https://issues.apache.org/jira/browse/SOLR-15843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] mdmarshmallow commented on pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets

2021-12-09 Thread GitBox
mdmarshmallow commented on pull request #509: URL: https://github.com/apache/lucene/pull/509#issuecomment-990443067 The current way of storing ranges is a `Map` that maps dimensions to their respective ord ranges. That obviously won't work anymore since want the ranges of any arbitrary pat

[GitHub] [lucene] gsmiller commented on pull request #509: LUCENE-10250: Add support for arbitrary length hierarchical SSDV facets

2021-12-09 Thread GitBox
gsmiller commented on pull request #509: URL: https://github.com/apache/lucene/pull/509#issuecomment-990419374 Thanks for taking a pass at this! I've started looking at the change but hope to have more time tomorrow to dive into details and start leaving feedback. One thing that's not clea

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2597: SOLR-15732 : queries to missing collection are slow

2021-12-09 Thread GitBox
dsmiley commented on a change in pull request #2597: URL: https://github.com/apache/lucene-solr/pull/2597#discussion_r766197049 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java ## @@ -2269,7 +2269,12 @@ public boolean update() throws KeeperExcep

[GitHub] [lucene] dsmiley commented on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-09 Thread GitBox
dsmiley commented on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-990226022 Let's definitely *not* double up the tests in the name of test coverage. It's not worth the maintenance overhead. As it is, I think there's some other double-up test for somethin

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766123595 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: Wasn't my plan.

[GitHub] [lucene] dweiss commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
dweiss commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766100807 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: No, please, let's n

[GitHub] [lucene] dweiss commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
dweiss commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766099602 ## File path: gradle/java/jar-manifest.gradle ## @@ -69,12 +69,6 @@ subprojects { "X-Build-OS": "${System.properties['os.name']} $

[GitHub] [lucene] zhaih commented on pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-09 Thread GitBox
zhaih commented on pull request #521: URL: https://github.com/apache/lucene/pull/521#issuecomment-990171485 @dweiss NP and thank you for merging it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] rmuir commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-12-09 Thread GitBox
rmuir commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r766065104 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -614,16 +624,17 @@ public Automaton toAutomaton(AutomatonProvider automa

[GitHub] [lucene] zhaih commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-12-09 Thread GitBox
zhaih commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r766061920 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -614,16 +624,17 @@ public Automaton toAutomaton(AutomatonProvider automa

[GitHub] [lucene] rmuir commented on a change in pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-12-09 Thread GitBox
rmuir commented on a change in pull request #225: URL: https://github.com/apache/lucene/pull/225#discussion_r762372861 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java ## @@ -614,16 +624,17 @@ public Automaton toAutomaton(AutomatonProvider automa

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766043869 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: > ASM also has

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766041473 ## File path: gradle/java/jar-manifest.gradle ## @@ -69,12 +69,6 @@ subprojects { "X-Build-OS": "${System.properties['os.name']

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766022562 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: > > But neverth

[GitHub] [lucene] ChrisHegarty commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
ChrisHegarty commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766030837 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: Ah, I see it.

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766022562 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: > > But neverth

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766020629 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: ASM also has a

[jira] [Comment Edited] (LUCENE-10297) Speed up medium cardinality fields with readLongs and SIMD

2021-12-09 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456577#comment-17456577 ] Feng Guo edited comment on LUCENE-10297 at 12/9/21, 5:24 PM:

[GitHub] [lucene] ChrisHegarty commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
ChrisHegarty commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r766001739 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: @uschindler I

[jira] [Commented] (LUCENE-10297) Speed up medium cardinality fields with readLongs and SIMD

2021-12-09 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456577#comment-17456577 ] Feng Guo commented on LUCENE-10297: --- Hi [~jpountz] , Would you please help take a loo

[jira] [Commented] (LUCENE-10229) Match offsets should be consistent for fields with positions and fields with offsets

2021-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456555#comment-17456555 ] ASF subversion and git services commented on LUCENE-10229: -- Co

[jira] [Commented] (LUCENE-10229) Match offsets should be consistent for fields with positions and fields with offsets

2021-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456556#comment-17456556 ] ASF subversion and git services commented on LUCENE-10229: -- Co

[jira] [Commented] (LUCENE-10229) Match offsets should be consistent for fields with positions and fields with offsets

2021-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456553#comment-17456553 ] ASF subversion and git services commented on LUCENE-10229: -- Co

[jira] [Commented] (LUCENE-10229) Match offsets should be consistent for fields with positions and fields with offsets

2021-12-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456551#comment-17456551 ] Dawid Weiss commented on LUCENE-10229: -- I'm going to leave the issue open because

[jira] [Commented] (LUCENE-10229) Match offsets should be consistent for fields with positions and fields with offsets

2021-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456543#comment-17456543 ] ASF subversion and git services commented on LUCENE-10229: -- Co

[GitHub] [lucene] dweiss commented on pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-09 Thread GitBox
dweiss commented on pull request #521: URL: https://github.com/apache/lucene/pull/521#issuecomment-990004272 Thank you @zhaih and apologies for the delay! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] dweiss merged pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-09 Thread GitBox
dweiss merged pull request #521: URL: https://github.com/apache/lucene/pull/521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] (LUCENE-10297) Speed up medium cardinality fields with readLongs and SIMD

2021-12-09 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10297 ] Feng Guo deleted comment on LUCENE-10297: --- was (Author: gf2121): Several side findings and thoughts that need confirm: * This optimization can proberbly make storage lager because we store al

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456540#comment-17456540 ] Dawid Weiss commented on LUCENE-10301: -- I'm really not sure... but I anticipate pr

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456533#comment-17456533 ] Ignacio Vera commented on LUCENE-10299: --- Yes, I think we should track it from a d

[jira] [Commented] (LUCENE-10297) Speed up medium cardinality fields with readLongs and SIMD

2021-12-09 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456530#comment-17456530 ] Feng Guo commented on LUCENE-10297: --- Several side findings and thoughts that need con

[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765929282 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: > But nevertheles

[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765929282 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: > But nevertheles

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765927524 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: I think the pro

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765921053 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: @ChrisHegarty:

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765921053 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: @ChrisHegarty:

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765921053 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: @ChrisHegarty:

[GitHub] [lucene] mocobeta commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-989977641 @dweiss please go ahead - I don't think I'm the right person for review here anyway. I will try to catch up and I like the explicit dependency configurations (`moduleApi`, `module

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765920281 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: Ah it is `commo

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765918674 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: In fobiddenapis

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765917561 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: Do we need asm-

[GitHub] [lucene] mocobeta commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
mocobeta commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765907490 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: I think this is n

[GitHub] [lucene] uschindler commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
uschindler commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765860295 ## File path: lucene/licenses/asm-analysis-7.2.jar.sha1 ## @@ -0,0 +1 @@ +b6e6abe057f23630113f4167c34bda7086691258 Review comment: is there no way

[GitHub] [lucene] ChrisHegarty commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
ChrisHegarty commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-989908876 FWIW, I really like the explicit module configurations. I'm working on aligning the Modular Elasticsearch prototype I have with them. I really like the flexibility that they o

[jira] [Updated] (LUCENE-10297) Speed up medium cardinality fields with readLongs and SIMD

2021-12-09 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10297: -- Description: We introduced a bitset optimization for extremly low cardinality fields in [LUCENE-1023

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456468#comment-17456468 ] Robert Muir commented on LUCENE-10301: -- Can someone propose a new package name to

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456466#comment-17456466 ] Robert Muir commented on LUCENE-10301: -- I imagine the refactoring would be very no

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456463#comment-17456463 ] Robert Muir commented on LUCENE-10299: -- Thanks [~ivera]! I see that LUCENE-10289 w

[GitHub] [lucene] dweiss commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
dweiss commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765805595 ## File path: gradle/java/modules.gradle ## @@ -199,6 +200,67 @@ allprojects { } } +// Configure the test task. +tasks.matching { it.nam

[GitHub] [lucene] ChrisHegarty commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
ChrisHegarty commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765798599 ## File path: gradle/java/modules.gradle ## @@ -199,6 +200,67 @@ allprojects { } } +// Configure the test task. +tasks.matching {

[jira] [Commented] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2021-12-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456448#comment-17456448 ] David Smiley commented on LUCENE-10302: --- This builder could provide a buildList m

[jira] [Commented] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2021-12-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456443#comment-17456443 ] David Smiley commented on LUCENE-10302: --- Fun fact: there are 56 usages of Lucene'

[jira] [Commented] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2021-12-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456441#comment-17456441 ] David Smiley commented on LUCENE-10302: --- As an aside; it's weird/annoying to have

[jira] [Created] (LUCENE-10302) PriorityQueue: optimize where we collect then iterate by using O(N) heapify

2021-12-09 Thread David Smiley (Jira)
David Smiley created LUCENE-10302: - Summary: PriorityQueue: optimize where we collect then iterate by using O(N) heapify Key: LUCENE-10302 URL: https://issues.apache.org/jira/browse/LUCENE-10302 Proje

[jira] [Resolved] (LUCENE-10289) DocIdSetBuilder#grow() should take a long instead of int

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10289. --- Fix Version/s: (was: 9.1) Resolution: Invalid This changes introduced a performa

[jira] [Resolved] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10299. --- Assignee: Ignacio Vera Resolution: Fixed The problematic commit has been reverted on

[jira] [Commented] (LUCENE-10289) DocIdSetBuilder#grow() should take a long instead of int

2021-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456419#comment-17456419 ] ASF subversion and git services commented on LUCENE-10289: -- Co

[jira] [Commented] (LUCENE-10289) DocIdSetBuilder#grow() should take a long instead of int

2021-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456418#comment-17456418 ] ASF subversion and git services commented on LUCENE-10289: -- Co

[GitHub] [lucene] iverase merged pull request #532: Revert "LUCENE-10289: Change DocIdSetBuilder#grow() from taking an int to a long (#520)"

2021-12-09 Thread GitBox
iverase merged pull request #532: URL: https://github.com/apache/lucene/pull/532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456415#comment-17456415 ] Ignacio Vera commented on LUCENE-10299: --- > It is a harder problem to fix, as we m

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456409#comment-17456409 ] Ignacio Vera commented on LUCENE-10299: --- I open https://github.com/apache/lucene/

[GitHub] [lucene] iverase opened a new pull request #532: Revert "LUCENE-10289: Change DocIdSetBuilder#grow() from taking an int to a long (#520)"

2021-12-09 Thread GitBox
iverase opened a new pull request #532: URL: https://github.com/apache/lucene/pull/532 This reverts commit af1e68b89197bd6399c0db18e478716951dd381c. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456404#comment-17456404 ] Robert Muir commented on LUCENE-10299: -- I don't think there's a real disagreement

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456402#comment-17456402 ] Ignacio Vera commented on LUCENE-10299: --- I would prefer to rollback the commit th

[jira] [Created] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-09 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10301: Summary: The test-framework as a module (or a separate test-framework-module) Key: LUCENE-10301 URL: https://issues.apache.org/jira/browse/LUCENE-10301 Project: Lucen

[GitHub] [lucene] dweiss commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-989807971 @mocobeta @uschindler Last look and thoughts? I will rewrite this to be less repetitive but this may entail a bit more gradle magic which may be obscure the overall idea. -- This

[GitHub] [lucene] dweiss commented on a change in pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-09 Thread GitBox
dweiss commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r765741925 ## File path: gradle/java/modules.gradle ## @@ -199,6 +200,67 @@ allprojects { } } +// Configure the test task. +tasks.matching { it.nam

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456390#comment-17456390 ] Robert Muir commented on LUCENE-10299: -- I understand the motivation, I just disagr

[jira] [Resolved] (LUCENE-10286) Module path to dependencies that are not automatic modules (according to gradle)

2021-12-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10286. -- Resolution: Won't Fix We'll solve this one in a different way - you as a developer have to be

[jira] [Commented] (LUCENE-10255) Fully embrace the java module system

2021-12-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456388#comment-17456388 ] Dawid Weiss commented on LUCENE-10255: -- Finally! I think we have all the pieces th

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456386#comment-17456386 ] Ignacio Vera commented on LUCENE-10299: --- I am concern as well with the API. Let's

[jira] [Updated] (LUCENE-10255) Fully embrace the java module system

2021-12-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10255: - Description: I've experimented a bit trying to move the code to the JMS. It is _surprisingly d

[jira] [Created] (LUCENE-10300) Ukrainian analyzer won't load if started as a module

2021-12-09 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10300: Summary: Ukrainian analyzer won't load if started as a module Key: LUCENE-10300 URL: https://issues.apache.org/jira/browse/LUCENE-10300 Project: Lucene - Core

[jira] [Resolved] (LUCENE-10282) morfologik-stemming is not an automatic module

2021-12-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10282. -- Resolution: Fixed I've converted morfologik-stemming to a full module, so this is not an issu

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456366#comment-17456366 ] Robert Muir commented on LUCENE-10299: -- Hi [~ivera], I think your idea of an {{int

[jira] [Commented] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456248#comment-17456248 ] ASF subversion and git services commented on LUCENE-10294: -- Co

[jira] [Commented] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456247#comment-17456247 ] ASF subversion and git services commented on LUCENE-10294: -- Co

[jira] [Resolved] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10294. -- Fix Version/s: 9.1 Resolution: Fixed > Avoid compiling javadocs twice in 'gradlew chec

[GitHub] [lucene] dweiss commented on a change in pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2021-12-09 Thread GitBox
dweiss commented on a change in pull request #523: URL: https://github.com/apache/lucene/pull/523#discussion_r765559356 ## File path: lucene/distribution/build.gradle ## @@ -126,3 +126,31 @@ tasks.matching {it.name in [ ]}.all { group "distribution" } + +// Prepare a sonat

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456226#comment-17456226 ] Ignacio Vera commented on LUCENE-10299: --- In addition, here is the link where afte

[jira] [Commented] (LUCENE-10299) investigate prefix/wildcard perf drop in nightly benchmarks

2021-12-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456221#comment-17456221 ] Ignacio Vera commented on LUCENE-10299: --- Yikes, thanks for catching this up! Befo