[jira] [Comment Edited] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2021-12-15 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460463#comment-17460463 ] Feng Guo edited comment on LUCENE-10315 at 12/16/21, 7:57 AM: ---

[jira] [Commented] (LUCENE-10317) In PhraseQuery API, the explanation of getSlop is not inexact but could be more clear

2021-12-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460468#comment-17460468 ] Dawid Weiss commented on LUCENE-10317: -- The implementation logic for this is here,

[jira] [Comment Edited] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2021-12-15 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460463#comment-17460463 ] Feng Guo edited comment on LUCENE-10315 at 12/16/21, 7:55 AM: ---

[jira] [Commented] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2021-12-15 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460463#comment-17460463 ] Feng Guo commented on LUCENE-10315: --- I noticed that benchmark in LuceneUtil is mainly

[jira] [Updated] (LUCENE-10315) Speed up BKD leaf block ids codec by a 512 ints ForUtil

2021-12-15 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Guo updated LUCENE-10315: -- Attachment: addall.svg > Speed up BKD leaf block ids codec by a 512 ints ForUtil > --

[jira] [Created] (LUCENE-10318) Reuse HNSW graphs when merging segments?

2021-12-15 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-10318: - Summary: Reuse HNSW graphs when merging segments? Key: LUCENE-10318 URL: https://issues.apache.org/jira/browse/LUCENE-10318 Project: Lucene - Core

[GitHub] [lucene] mocobeta commented on a change in pull request #544: LUCENE-10313: drop log4j from luke

2021-12-15 Thread GitBox
mocobeta commented on a change in pull request #544: URL: https://github.com/apache/lucene/pull/544#discussion_r770140481 ## File path: lucene/luke/src/java/org/apache/lucene/luke/util/LoggerFactory.java ## @@ -17,54 +17,28 @@ package org.apache.lucene.luke.util; -import j

[GitHub] [lucene] mocobeta commented on a change in pull request #544: LUCENE-10313: drop log4j from luke

2021-12-15 Thread GitBox
mocobeta commented on a change in pull request #544: URL: https://github.com/apache/lucene/pull/544#discussion_r770140180 ## File path: lucene/luke/src/java/org/apache/lucene/luke/util/LoggerFactory.java ## @@ -17,54 +17,28 @@ package org.apache.lucene.luke.util; -import j

[GitHub] [lucene] jtibshirani commented on pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-12-15 Thread GitBox
jtibshirani commented on pull request #416: URL: https://github.com/apache/lucene/pull/416#issuecomment-995224656 @mayya-sharipova thanks for all your work on this PR. For me, there aren't blockers to merging. I'll do a final review tomorrow (with my morning coffee :)) to make sure I didn'

[GitHub] [lucene] jtibshirani commented on a change in pull request #416: LUCENE-10054 Make HnswGraph hierarchical

2021-12-15 Thread GitBox
jtibshirani commented on a change in pull request #416: URL: https://github.com/apache/lucene/pull/416#discussion_r770048710 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsReader.java ## @@ -205,6 +215,43 @@ private FieldEntry readField

[jira] [Commented] (LUCENE-10317) In PhraseQuery API, the explanation of getSlop is not inexact but could be more clear

2021-12-15 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460252#comment-17460252 ] Claude Lepère commented on LUCENE-10317: Thank you for your quick answer. In "t

[jira] [Commented] (LUCENE-10317) In PhraseQuery API, the explanation of getSlop is not inexact but could be more clear

2021-12-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460158#comment-17460158 ] Dawid Weiss commented on LUCENE-10317: -- If you open up your document in Luke and t

[jira] [Created] (LUCENE-10317) In PhraseQuery API, the explanation of getSlop is not inexact but could be more clear

2021-12-15 Thread Jira
Claude Lepère created LUCENE-10317: -- Summary: In PhraseQuery API, the explanation of getSlop is not inexact but could be more clear Key: LUCENE-10317 URL: https://issues.apache.org/jira/browse/LUCENE-10317

[jira] [Commented] (LUCENE-10245) Allow users to provide DocValues to (some) Facets Implementations

2021-12-15 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460030#comment-17460030 ] Greg Miller commented on LUCENE-10245: -- Just put up a PR for this work for feedbac

[GitHub] [lucene] gsmiller opened a new pull request #543: LUCENE-10245: Addition of MultiDoubleValues(Source) and MultiLongValues(Source) along with faceting capabilities

2021-12-15 Thread GitBox
gsmiller opened a new pull request #543: URL: https://github.com/apache/lucene/pull/543 # Description This change allows users to provide custom multi-valued "value sources" for numeric faceting (`LongValueFacetCounts`, `LongRangeFacetCounts` and `DoubleRangeFacetCounts`). Without t

[jira] [Commented] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459912#comment-17459912 ] Dawid Weiss commented on LUCENE-10313: -- Sure. I'll clean up the branch from unnece

[jira] [Commented] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459908#comment-17459908 ] Tomoko Uchida commented on LUCENE-10313: Please feel free to directly merge it

[jira] [Commented] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459890#comment-17459890 ] Dawid Weiss commented on LUCENE-10313: -- Sure, thanks for the explanation. What do

[jira] [Commented] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459876#comment-17459876 ] Tomoko Uchida commented on LUCENE-10313: I did not mean Swing's model is not go

[jira] [Commented] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459817#comment-17459817 ] Dawid Weiss commented on LUCENE-10313: -- I remember Swing's event model was just fi

[jira] [Commented] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459763#comment-17459763 ] Tomoko Uchida commented on LUCENE-10313: I forgot so many things but it seems I

[jira] [Comment Edited] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459721#comment-17459721 ] Tomoko Uchida edited comment on LUCENE-10313 at 12/15/21, 8:43 AM: --

[jira] [Commented] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459724#comment-17459724 ] Dawid Weiss commented on LUCENE-10313: -- I've been thinking about it once I posted

[jira] [Commented] (LUCENE-10313) Remove log4j from dependencies and switch to java logging (in luke)

2021-12-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459721#comment-17459721 ] Tomoko Uchida commented on LUCENE-10313: {quote}I think this should only update