[GitHub] [lucene] iverase commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-02-20 Thread GitBox
iverase commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1046560283 I open https://github.com/apache/lucene/pull/698 where I proposed a different way to compute const that reflect that the internal counter of DocIdSetBuilder refers to documents in

[GitHub] [lucene] iverase opened a new pull request #698: LUCENE-10429: Change how DocIdSetBuilder compute the cost of the dense iterator

2022-02-20 Thread GitBox
iverase opened a new pull request #698: URL: https://github.com/apache/lucene/pull/698 We currently compute the cost of the dense iterator using the following code: ``` final long cost = Math.round(counter / numValuesPerDoc); ``` Where counter is how many values have been

[GitHub] [lucene] mocobeta opened a new pull request #697: migrate to temurin

2022-02-20 Thread GitBox
mocobeta opened a new pull request #697: URL: https://github.com/apache/lucene/pull/697 follow-up of #674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[jira] [Updated] (LUCENE-10429) DocIdsetBuilder implementation is inconsistent with DocIdsetBuilder#grow contract

2022-02-20 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-10429: -- Summary: DocIdsetBuilder implementation is inconsistent with DocIdsetBuilder#grow contract

[jira] [Updated] (LUCENE-10429) DocIdsetBuilder implementation is inconsistent with DocIdSetBuilder#grow contract

2022-02-20 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera updated LUCENE-10429: -- Summary: DocIdsetBuilder implementation is inconsistent with DocIdSetBuilder#grow contract

[jira] [Created] (LUCENE-10429) DocIdsetBuilder implementation implementation is inconsistent with DocIdsetBuilder#grow contract

2022-02-20 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-10429: - Summary: DocIdsetBuilder implementation implementation is inconsistent with DocIdsetBuilder#grow contract Key: LUCENE-10429 URL: https://issues.apache.org/jira/browse/LUCENE-10

[jira] [Resolved] (LUCENE-10424) Optimize the "everything matches" case for count query in PointRangeQuery

2022-02-20 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10424. --- Fix Version/s: 9.1 Assignee: Ignacio Vera Resolution: Fixed > Optimize the

[jira] [Commented] (LUCENE-10424) Optimize the "everything matches" case for count query in PointRangeQuery

2022-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495336#comment-17495336 ] ASF subversion and git services commented on LUCENE-10424: -- Co

[GitHub] [lucene] iverase commented on pull request #691: LUCENE-10424: Optimize the "everything matches" case for count query in PointRangeQuery

2022-02-20 Thread GitBox
iverase commented on pull request #691: URL: https://github.com/apache/lucene/pull/691#issuecomment-1046508035 Thank you @LuXugang! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (LUCENE-10424) Optimize the "everything matches" case for count query in PointRangeQuery

2022-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495333#comment-17495333 ] ASF subversion and git services commented on LUCENE-10424: -- Co

[GitHub] [lucene] iverase merged pull request #691: LUCENE-10424: Optimize the "everything matches" case for count query in PointRangeQuery

2022-02-20 Thread GitBox
iverase merged pull request #691: URL: https://github.com/apache/lucene/pull/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] LuXugang edited a comment on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-02-20 Thread GitBox
LuXugang edited a comment on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1046438848 > I'm also confused why we have this sorted array buffer case instead of using SparseFixedBitSet (which has approximateCardinality already and needs no such special grow-t

[GitHub] [lucene] LuXugang commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-02-20 Thread GitBox
LuXugang commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1046438848 > I'm also confused why we have this sorted array buffer case instead of using SparseFixedBitSet (which has approximateCardinality already and needs no such special grow-tracking

[GitHub] [lucene] mocobeta closed pull request #694: supress Actions jobs when only text files are changed

2022-02-20 Thread GitBox
mocobeta closed pull request #694: URL: https://github.com/apache/lucene/pull/694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (LUCENE-10416) Update Korean Dictionary for Nori

2022-02-20 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495158#comment-17495158 ] Tomoko Uchida commented on LUCENE-10416: Right. I haven't considered it. I can

[jira] [Comment Edited] (LUCENE-10416) Update Korean Dictionary for Nori

2022-02-20 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495157#comment-17495157 ] Uwe Schindler edited comment on LUCENE-10416 at 2/20/22, 1:19 PM: ---

[jira] [Commented] (LUCENE-10416) Update Korean Dictionary for Nori

2022-02-20 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495157#comment-17495157 ] Uwe Schindler commented on LUCENE-10416: I have one question: if you have index

[jira] [Resolved] (LUCENE-10416) Update Korean Dictionary for Nori

2022-02-20 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10416. Fix Version/s: 9.1 10.0 (main) Resolution: Fixed > Update Korea

[jira] [Commented] (LUCENE-10416) Update Korean Dictionary for Nori

2022-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495152#comment-17495152 ] ASF subversion and git services commented on LUCENE-10416: -- Co

[jira] [Commented] (LUCENE-10416) Update Korean Dictionary for Nori

2022-02-20 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495151#comment-17495151 ] Tomoko Uchida commented on LUCENE-10416: There is no CHANGES entry in your patc

[jira] [Commented] (LUCENE-10416) Update Korean Dictionary for Nori

2022-02-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495150#comment-17495150 ] ASF subversion and git services commented on LUCENE-10416: -- Co

[jira] [Commented] (LUCENE-10416) Update Korean Dictionary for Nori

2022-02-20 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495146#comment-17495146 ] Tomoko Uchida commented on LUCENE-10416: Thanks [~uihyun], this looks all fine

[jira] [Resolved] (LUCENE-10400) Clean up the constructors' API signature of dictionary classes in kuromoji and nori

2022-02-20 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10400. Fix Version/s: 9.1 10.0 (main) Resolution: Fixed > Clean up the

[GitHub] [lucene] mocobeta merged pull request #695: LUCENE-10400: Remove deprecated constructors in Nori

2022-02-20 Thread GitBox
mocobeta merged pull request #695: URL: https://github.com/apache/lucene/pull/695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [lucene] mocobeta commented on pull request #695: LUCENE-10400: Remove deprecated constructors in Nori

2022-02-20 Thread GitBox
mocobeta commented on pull request #695: URL: https://github.com/apache/lucene/pull/695#issuecomment-1046189859 ``` lucene $ git grep "@Deprecated" lucene/analysis/nori/ // no outputs ``` -- This is an automated message from the Apache Git Service. To respond to the message, plea