[jira] [Commented] (LUCENE-10431) AssertionError in BooleanQuery.hashCode()

2022-02-28 Thread Michael Bien (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499321#comment-17499321 ] Michael Bien commented on LUCENE-10431: --- IMO: If you don't want client code to use setters:

[jira] [Created] (LUCENE-10446) Add a precise cost of score in ScorerSupplier

2022-02-28 Thread Lu Xugang (Jira)
Lu Xugang created LUCENE-10446: -- Summary: Add a precise cost of score in ScorerSupplier Key: LUCENE-10446 URL: https://issues.apache.org/jira/browse/LUCENE-10446 Project: Lucene - Core Issue

[GitHub] [lucene] wjp719 commented on pull request #687: LUCENE-10425:speed up IndexSortSortedNumericDocValuesRangeQuery#BoundedDocSetIdIterator construction using bkd binary search

2022-02-28 Thread GitBox
wjp719 commented on pull request #687: URL: https://github.com/apache/lucene/pull/687#issuecomment-1054926857 @iverase I add a random test, please review it again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene] wjp719 commented on a change in pull request #687: LUCENE-10425:speed up IndexSortSortedNumericDocValuesRangeQuery#BoundedDocSetIdIterator construction using bkd binary search

2022-02-28 Thread GitBox
wjp719 commented on a change in pull request #687: URL: https://github.com/apache/lucene/pull/687#discussion_r816404708 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -308,8 +449,10 @@ public int

[GitHub] [lucene-solr] kiranchitturi commented on a change in pull request #2644: SOLR-16009 Add custom udfs for filtering inside multi-valued fields

2022-02-28 Thread GitBox
kiranchitturi commented on a change in pull request #2644: URL: https://github.com/apache/lucene-solr/pull/2644#discussion_r816219452 ## File path: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java ## @@ -2388,6 +2388,7 @@ public void

[jira] [Comment Edited] (LUCENE-10428) getMinCompetitiveScore method in MaxScoreSumPropagator fails to converge leading to busy threads in infinite loop

2022-02-28 Thread Ankit Jain (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17497658#comment-17497658 ] Ankit Jain edited comment on LUCENE-10428 at 2/28/22, 6:14 PM: --- {quote}I

[jira] [Commented] (LUCENE-10442) When indexQuery or/and dvQuery be a MatchAllDocsQuery then IndexOrDocValuesQuery should be rewrite to MatchAllDocsQuery

2022-02-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499099#comment-17499099 ] Adrien Grand commented on LUCENE-10442: --- Thanks [~ChrisLu]! > When indexQuery or/and dvQuery be

[jira] [Resolved] (LUCENE-10442) When indexQuery or/and dvQuery be a MatchAllDocsQuery then IndexOrDocValuesQuery should be rewrite to MatchAllDocsQuery

2022-02-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10442. --- Resolution: Fixed > When indexQuery or/and dvQuery be a MatchAllDocsQuery then >

[jira] [Commented] (LUCENE-10442) When indexQuery or/and dvQuery be a MatchAllDocsQuery then IndexOrDocValuesQuery should be rewrite to MatchAllDocsQuery

2022-02-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499087#comment-17499087 ] ASF subversion and git services commented on LUCENE-10442: -- Commit

[jira] [Commented] (LUCENE-10442) When indexQuery or/and dvQuery be a MatchAllDocsQuery then IndexOrDocValuesQuery should be rewrite to MatchAllDocsQuery

2022-02-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499077#comment-17499077 ] ASF subversion and git services commented on LUCENE-10442: -- Commit

[GitHub] [lucene] jpountz merged pull request #715: LUCENE-10442: When indexQuery or/and dvQuery be a MatchAllDocsQuery then IndexOrDocValuesQuery should be rewrite to MatchAllDocsQuery

2022-02-28 Thread GitBox
jpountz merged pull request #715: URL: https://github.com/apache/lucene/pull/715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10431) AssertionError in BooleanQuery.hashCode()

2022-02-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499074#comment-17499074 ] Adrien Grand commented on LUCENE-10431: --- I wonder if the most immediate fix could consist of

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2644: SOLR-16009 Add custom udfs for filtering inside multi-valued fields

2022-02-28 Thread GitBox
thelabdude commented on a change in pull request #2644: URL: https://github.com/apache/lucene-solr/pull/2644#discussion_r816037662 ## File path: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java ## @@ -2388,6 +2388,7 @@ public void testMultiValuedFieldHandling()

[GitHub] [lucene] LuXugang commented on pull request #715: LUCENE-10442: When indexQuery or/and dvQuery be a MatchAllDocsQuery then IndexOrDocValuesQuery should be rewrite to MatchAllDocsQuery

2022-02-28 Thread GitBox
LuXugang commented on pull request #715: URL: https://github.com/apache/lucene/pull/715#issuecomment-1054355756 > +1 can you add a CHANGES entry? OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] iverase commented on a change in pull request #687: LUCENE-10425:speed up IndexSortSortedNumericDocValuesRangeQuery#BoundedDocSetIdIterator construction using bkd binary search

2022-02-28 Thread GitBox
iverase commented on a change in pull request #687: URL: https://github.com/apache/lucene/pull/687#discussion_r815921747 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -181,12 +189,143 @@ public int

[GitHub] [lucene] jpountz commented on pull request #715: LUCENE-10442: When indexQuery or/and dvQuery be a MatchAllDocsQuery then IndexOrDocValuesQuery should be rewrite to MatchAllDocsQuery

2022-02-28 Thread GitBox
jpountz commented on pull request #715: URL: https://github.com/apache/lucene/pull/715#issuecomment-1054280947 +1 can you add a CHANGES entry? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] jpountz commented on a change in pull request #446: LUCENE-10237 : Add MergeOnCommitTieredMergePolicy to sandbox

2022-02-28 Thread GitBox
jpountz commented on a change in pull request #446: URL: https://github.com/apache/lucene/pull/446#discussion_r815897598 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/index/MergeOnFlushMergePolicy.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache

[GitHub] [lucene] jpountz edited a comment on pull request #446: LUCENE-10237 : Add MergeOnCommitTieredMergePolicy to sandbox

2022-02-28 Thread GitBox
jpountz edited a comment on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-1054266698 > I also noticed that in IndexWriter where we call findFullFlushMerges, we only do so for merge triggers GET_READER and COMMIT, but not for trigger FULL_FLUSH, which seems

[GitHub] [lucene] jpountz commented on pull request #446: LUCENE-10237 : Add MergeOnCommitTieredMergePolicy to sandbox

2022-02-28 Thread GitBox
jpountz commented on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-1054266698 > I also noticed that in IndexWriter where we call findFullFlushMerges, we only do so for merge triggers GET_READER and COMMIT, but not for trigger FULL_FLUSH, which seems quite

[GitHub] [lucene] wjp719 edited a comment on pull request #687: LUCENE-10425:speed up IndexSortSortedNumericDocValuesRangeQuery#BoundedDocSetIdIterator construction using bkd binary search

2022-02-28 Thread GitBox
wjp719 edited a comment on pull request #687: URL: https://github.com/apache/lucene/pull/687#issuecomment-1054244294 @iverase , Hi I move the bkd binary search to the IndexSortSortedNumericDocValuesRangeQuery as you suggested, please help to review it, thanks. -- This is an automated

[GitHub] [lucene] wjp719 commented on pull request #687: LUCENE-10425:speed up IndexSortSortedNumericDocValuesRangeQuery#BoundedDocSetIdIterator construction using bkd binary search

2022-02-28 Thread GitBox
wjp719 commented on pull request #687: URL: https://github.com/apache/lucene/pull/687#issuecomment-1054244294 @iverase , Hi I move the bkd binary to the IndexSortSortedNumericDocValuesRangeQuery as you suggested, please help to review it, thanks. -- This is an automated message from

[GitHub] [lucene] codaitya commented on pull request #446: LUCENE-10237 : Add MergeOnCommitTieredMergePolicy to sandbox

2022-02-28 Thread GitBox
codaitya commented on pull request #446: URL: https://github.com/apache/lucene/pull/446#issuecomment-1054179398 Sorry for the delay in getting back to this, got busy with work and also needed time to study more details on how Lucene does segment merges. > Why do we need to exclude

[jira] [Commented] (LUCENE-10442) When indexQuery or/and dvQuery be a MatchAllDocsQuery then IndexOrDocValuesQuery should be rewrite to MatchAllDocsQuery

2022-02-28 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498818#comment-17498818 ] Lu Xugang commented on LUCENE-10442: Further more: can we leverage Weigh#count() to get a

[GitHub] [lucene] mogui commented on a change in pull request #679: Monitor Improvements LUCENE-10422

2022-02-28 Thread GitBox
mogui commented on a change in pull request #679: URL: https://github.com/apache/lucene/pull/679#discussion_r815732492 ## File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] romseygeek commented on a change in pull request #679: Monitor Improvements LUCENE-10422

2022-02-28 Thread GitBox
romseygeek commented on a change in pull request #679: URL: https://github.com/apache/lucene/pull/679#discussion_r815721410 ## File path: lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (LUCENE-10431) AssertionError in BooleanQuery.hashCode()

2022-02-28 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498799#comment-17498799 ] Alan Woodward commented on LUCENE-10431: I think the issue is that BooleanQuery is expecting