[
https://issues.apache.org/jira/browse/LUCENE-10311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500568#comment-17500568
]
ASF subversion and git services commented on LUCENE-10311:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500565#comment-17500565
]
Vigya Sharma commented on LUCENE-10302:
---
+1. I'd also like to look at it and maybe pick up a
[
https://issues.apache.org/jira/browse/LUCENE-10311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500563#comment-17500563
]
ASF subversion and git services commented on LUCENE-10311:
--
Commit
jpountz merged pull request #710:
URL: https://github.com/apache/lucene/pull/710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500546#comment-17500546
]
Vigya Sharma commented on LUCENE-10448:
---
>From what I understand, the only case when
[
https://issues.apache.org/jira/browse/LUCENE-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500514#comment-17500514
]
Lu Xugang commented on LUCENE-10446:
This is a new Query within the quick patch named
[
https://issues.apache.org/jira/browse/LUCENE-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10446:
---
Attachment: LUCENE-10466-1.patch
> Add a precise cost of score in ScorerSupplier
>
dsmiley commented on a change in pull request #2165:
URL: https://github.com/apache/lucene-solr/pull/2165#discussion_r818317522
##
File path: solr/contrib/prometheus-exporter/conf/solr-exporter-config.xml
##
@@ -315,88 +477,22 @@
node metrics
-->
mocobeta commented on a change in pull request #717:
URL: https://github.com/apache/lucene/pull/717#discussion_r818287557
##
File path: build.gradle
##
@@ -183,3 +183,5 @@ apply from: file('gradle/hacks/turbocharge-jvm-opts.gradle')
apply from:
wjp719 commented on pull request #687:
URL: https://github.com/apache/lucene/pull/687#issuecomment-1057611824
> One thing I'm not totally happy with is that the change assumes that the
field is either not indexed or indexed with `LongPoint` while this query would
previousy also work with
thelabdude merged pull request #2644:
URL: https://github.com/apache/lucene-solr/pull/2644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500438#comment-17500438
]
Julie Tibshirani commented on LUCENE-10408:
---
I noticed a failure in a test that was added:
uschindler commented on a change in pull request #722:
URL: https://github.com/apache/lucene/pull/722#discussion_r818194470
##
File path: lucene/core/src/java/org/apache/lucene/search/MultiTermQuery.java
##
@@ -52,7 +52,7 @@
*/
public abstract class MultiTermQuery extends
jainankitk edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057396494
> This gave me the idea that we can use negative values for a test at least.
I PRed [jpountz#2](https://github.com/jpountz/lucene/pull/2) into your branch:
it
jainankitk commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057396494
> This gave me the idea that we can use negative values for a test at least.
I PRed [jpountz#2](https://github.com/jpountz/lucene/pull/2) into your branch:
it reproduces this
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057349041
Thank you for the detailed explanation, this makes a lot of sense.
> * A bug in other code that breaks assumptions that this code is making,
e.g. a query that
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057349041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057349510
> > I won't argue on this specific approach, but I have hard time accepting
that we can fix a real bug, and write no new tests.
>
> Please feel free to contribute one, this
dblock commented on a change in pull request #711:
URL: https://github.com/apache/lucene/pull/711#discussion_r818077386
##
File path:
lucene/core/src/java/org/apache/lucene/search/MaxScoreSumPropagator.java
##
@@ -131,22 +131,28 @@ void setMinCompetitiveScore(float minScore)
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057349041
Thank you for the detailed explanation, this makes a lot of sense.
> * A bug in other code that breaks assumptions that this code is making,
e.g. a query that produces
dweiss commented on a change in pull request #717:
URL: https://github.com/apache/lucene/pull/717#discussion_r818072938
##
File path: build.gradle
##
@@ -183,3 +183,5 @@ apply from: file('gradle/hacks/turbocharge-jvm-opts.gradle')
apply from:
rmuir commented on a change in pull request #722:
URL: https://github.com/apache/lucene/pull/722#discussion_r817992391
##
File path: lucene/core/src/java/org/apache/lucene/search/RegexpQuery.java
##
@@ -62,6 +62,24 @@ public RegexpQuery(Term term) {
this(term,
rmuir commented on a change in pull request #722:
URL: https://github.com/apache/lucene/pull/722#discussion_r817991640
##
File path: lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java
##
@@ -113,11 +138,40 @@ public FuzzyQuery(Term term, int maxEdits) {
Peter Gromov created LUCENE-10452:
-
Summary: Hunspell: call checkCanceled less frequently to reduce
the overhead
Key: LUCENE-10452
URL: https://issues.apache.org/jira/browse/LUCENE-10452
Project:
jpountz commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057183183
> It looks like converging in getMinCompetitiveScore relies on truncating
(rounding?) doubles to floats, so this looks suspicious to me.
I certainly wish it was simpler,
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057078347
I think we have a case of floating point here.
If you change `getMinCompetitiveScore` to take a `double` or `minScoreSum`,
it becomes easy to reproduce. It also
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057078347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057078347
I think we have a case of floating point here.
If you change `getMinCompetitiveScore` to take a `double` or `minScoreSum`,
it becomes easy to reproduce. It also
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057078347
I think we have a case of floating point here.
If you change `getMinCompetitiveScore` to take a `double` or `minScoreSum`,
it becomes easy to reproduce. It also
dblock edited a comment on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057078347
I think we have a case of floating point here.
If you change `getMinCompetitiveScore` to take a `double` or `minScoreSum`,
it becomes easy to reproduce. It also
dblock commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057078347
I think we have a case of floating point here.
If you change `getMinCompetitiveScore` to take a `double` or `minScoreSum`,
it becomes easy to reproduce. It also almost
jpountz commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057061295
@dblock Yeah I'm unhappy about this change too. FWIW this isn't really a bug
fix, this mostly turns a potential bug that we haven't managed to understand
into a different bug
[
https://issues.apache.org/jira/browse/LUCENE-10302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500239#comment-17500239
]
Greg Miller commented on LUCENE-10302:
--
{quote}I have the start of some code in progress I can
jpountz commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1057058488
> Out of curiosity, what is the implication of returning whatever minScore
get's computed after 2 iterations? Like we do a best case effort to converge,
but return with whatever
jpountz commented on a change in pull request #722:
URL: https://github.com/apache/lucene/pull/722#discussion_r817784359
##
File path: lucene/core/src/java/org/apache/lucene/search/FuzzyQuery.java
##
@@ -56,6 +56,10 @@
public static final int defaultMaxExpansions = 50;
mocobeta commented on a change in pull request #717:
URL: https://github.com/apache/lucene/pull/717#discussion_r817759908
##
File path: lucene/distribution/src/binary-release/bin/luke.sh
##
@@ -17,5 +17,16 @@
MODULES=`dirname "$0"`/..
MODULES=`cd "$MODULES" && pwd`
-java
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500204#comment-17500204
]
Renaud Delbru commented on LUCENE-10449:
We will, thanks Robert.
> Performance regression due
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500198#comment-17500198
]
Robert Muir commented on LUCENE-10449:
--
{quote}
Our need in terms of data access pattern is to
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renaud Delbru updated LUCENE-10449:
---
Description:
LUCENE-9843 removed the compression option for SortedSetDocValues term
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500194#comment-17500194
]
Robert Muir commented on LUCENE-10449:
--
yeah, I think it is best to address the issue with them.
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renaud Delbru updated LUCENE-10449:
---
Summary: Performance regression due to LZ4 compression of TermsDict in
SortedSetDocValues
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500191#comment-17500191
]
Renaud Delbru commented on LUCENE-10449:
Hi [~rcmuir]
Thanks for your observation and advice.
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500172#comment-17500172
]
kkewwei edited comment on LUCENE-10448 at 3/2/22, 1:56 PM:
---
We know that if
msokolov commented on pull request #711:
URL: https://github.com/apache/lucene/pull/711#issuecomment-1056965854
> I won't argue on this specific approach, but I have hard time accepting
that we can fix a real bug, and write no new tests.
Please feel free to contribute one, this is
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500172#comment-17500172
]
kkewwei commented on LUCENE-10448:
--
We know that If we reach bytesSinceLastPause, we will call
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500172#comment-17500172
]
kkewwei edited comment on LUCENE-10448 at 3/2/22, 1:47 PM:
---
We know that if
[
https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500157#comment-17500157
]
Michael Bien commented on LUCENE-10431:
---
I see. Thanks for the info!
> AssertionError in
[
https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500118#comment-17500118
]
Alan Woodward commented on LUCENE-10431:
I opened [https://github.com/apache/lucene/pull/722]
romseygeek opened a new pull request #722:
URL: https://github.com/apache/lucene/pull/722
Allowing users to mutate MultiTermQuery can give rise to odd bugs, for
example
in wrapper queries such as BooleanQuery which lazily calculate their
hashcodes
and then cache the result. This
[
https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10449.
--
Resolution: Not A Problem
Problem here is that user isn't using binary docvalues, they are
mocobeta commented on a change in pull request #717:
URL: https://github.com/apache/lucene/pull/717#discussion_r817641774
##
File path: lucene/distribution/src/binary-release/bin/luke.sh
##
@@ -17,5 +17,16 @@
MODULES=`dirname "$0"`/..
MODULES=`cd "$MODULES" && pwd`
-java
[
https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500098#comment-17500098
]
Michael Bien commented on LUCENE-10431:
---
"in 9.x only, remove rewriteMethod from MTQ's hashcode()
[
https://issues.apache.org/jira/browse/LUCENE-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500090#comment-17500090
]
Alan Woodward commented on LUCENE-10431:
I suggest we do the following:
* deprecate
donnerpeter opened a new pull request #721:
URL: https://github.com/apache/lucene/pull/721
move all expensive operations closer to the suggestion creation, encapsulate
case and output conversion into a new Suggestion class
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/LUCENE-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500048#comment-17500048
]
Lu Xugang commented on LUCENE-10446:
Thanks [~jpountz] , so according to LUCENE-10162 , does the
Peter Gromov created LUCENE-10451:
-
Summary: Hunspell: don't perform potentially expensive
spellchecking after timeout
Key: LUCENE-10451
URL: https://issues.apache.org/jira/browse/LUCENE-10451
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1754#comment-1754
]
kkewwei edited comment on LUCENE-10448 at 3/2/22, 9:28 AM:
---
Yes, this is
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1754#comment-1754
]
kkewwei commented on LUCENE-10448:
--
Yes, This is what I wan to describe, the instant rate is
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1751#comment-1751
]
Adrien Grand commented on LUCENE-10448:
---
So if I understand correctly, the problem is that the
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1745#comment-1745
]
kkewwei edited comment on LUCENE-10448 at 3/2/22, 9:17 AM:
---
For example,
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1745#comment-1745
]
kkewwei edited comment on LUCENE-10448 at 3/2/22, 9:17 AM:
---
For example,
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1745#comment-1745
]
kkewwei edited comment on LUCENE-10448 at 3/2/22, 9:12 AM:
---
For example,
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1745#comment-1745
]
kkewwei commented on LUCENE-10448:
--
For example, After the first time calling maybePause, it took long
[
https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499984#comment-17499984
]
Adrien Grand commented on LUCENE-10391:
---
+1 to stop here for now, it looks like reusing the
[
https://issues.apache.org/jira/browse/LUCENE-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499982#comment-17499982
]
ASF subversion and git services commented on LUCENE-10450:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10450.
---
Resolution: Fixed
> IndexSortSortedNumericDocValuesRangeQuery could be rewrite to
>
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499981#comment-17499981
]
Adrien Grand commented on LUCENE-10448:
---
[~kkewwei] Sorry I'm not understanding what are the
[
https://issues.apache.org/jira/browse/LUCENE-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10450:
---
Fix Version/s: 9.1
> IndexSortSortedNumericDocValuesRangeQuery could be rewrite to
>
[
https://issues.apache.org/jira/browse/LUCENE-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499977#comment-17499977
]
ASF subversion and git services commented on LUCENE-10237:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10237:
--
Summary: Add merge on flush merge policy to Lucene Sandbox (was: Add merge
on commit merge
[
https://issues.apache.org/jira/browse/LUCENE-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10237.
---
Fix Version/s: 9.1
Resolution: Fixed
> Add merge on commit merge policy to Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499973#comment-17499973
]
ASF subversion and git services commented on LUCENE-10450:
--
Commit
jpountz merged pull request #720:
URL: https://github.com/apache/lucene/pull/720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499972#comment-17499972
]
ASF subversion and git services commented on LUCENE-10439:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499970#comment-17499970
]
ASF subversion and git services commented on LUCENE-10002:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499971#comment-17499971
]
ASF subversion and git services commented on LUCENE-10237:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499968#comment-17499968
]
ASF subversion and git services commented on LUCENE-10439:
--
Commit
jpountz merged pull request #714:
URL: https://github.com/apache/lucene/pull/714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499962#comment-17499962
]
ASF subversion and git services commented on LUCENE-10237:
--
Commit
mocobeta edited a comment on pull request #717:
URL: https://github.com/apache/lucene/pull/717#issuecomment-1056113863
Sure; it works on macOS.
```
% sw_vers [0][LUCENE-10447]
ProductName: macOS
ProductVersion: 11.6
BuildVersion:
jpountz merged pull request #446:
URL: https://github.com/apache/lucene/pull/446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499960#comment-17499960
]
kkewwei commented on LUCENE-10448:
--
[~jpountz] would you help confirm it?
> MergeRateLimiter doesn't
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499957#comment-17499957
]
ASF subversion and git services commented on LUCENE-10002:
--
Commit
jpountz merged pull request #716:
URL: https://github.com/apache/lucene/pull/716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
84 matches
Mail list logo
