mogui commented on pull request #679:
URL: https://github.com/apache/lucene/pull/679#issuecomment-1066549257
@romseygeek fixed !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
romseygeek commented on a change in pull request #679:
URL: https://github.com/apache/lucene/pull/679#discussion_r825818251
##
File path: lucene/monitor/src/java/org/apache/lucene/monitor/Monitor.java
##
@@ -125,14 +105,16 @@ public Monitor(Analyzer analyzer, Presearcher
prese
[
https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506184#comment-17506184
]
Adrien Grand commented on LUCENE-10448:
---
Like [~vigyas] my understanding is that
mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1066672493
We could have a common `DictionaryBuilder` class in analyzers-common but it
brings too complex class hierarchy to me. I'd postpone refactoring
XXXDictionaryBuilder until we come
jpountz commented on pull request #737:
URL: https://github.com/apache/lucene/pull/737#issuecomment-1066789801
This change makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jpountz commented on a change in pull request #736:
URL: https://github.com/apache/lucene/pull/736#discussion_r825981973
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -198,16 +198,22 @@ public boolea
gsmiller commented on a change in pull request #718:
URL: https://github.com/apache/lucene/pull/718#discussion_r826082690
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java
##
@@ -130,16 +140,16 @@ public FacetResult getTopChildren(in
gsmiller commented on a change in pull request #718:
URL: https://github.com/apache/lucene/pull/718#discussion_r826085655
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##
@@ -173,17 +185,17 @@ public FacetResult getTopChildren(int
javanna opened a new pull request #745:
URL: https://github.com/apache/lucene/pull/745
Based on discussion happening in
https://issues.apache.org/jira/browse/LUCENE-10458 , I am reverting
LUCENE-10385 (#635) in the 8.1 branch.
I left some test improvements that are still valid but r
gsmiller commented on pull request #718:
URL: https://github.com/apache/lucene/pull/718#issuecomment-1066998156
Even though I ran benchmarks on the backport version of this change (#719),
I figured it would be good to run benchmarks here as well. Below compares this
patch against `main` us
[
https://issues.apache.org/jira/browse/LUCENE-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506341#comment-17506341
]
Adrien Grand commented on LUCENE-10458:
---
Thanks for catching this, [~lucacavanna]
[
https://issues.apache.org/jira/browse/LUCENE-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506376#comment-17506376
]
Peixin Li commented on LUCENE-10441:
How many tokens should causing issue? and is t
mocobeta opened a new pull request #746:
URL: https://github.com/apache/lucene/pull/746
This tests if Luke process successfully starts on "java" on Mac/Linux or
"start javaw" on Windows.
TestScripts now checks if the expected message is contained in a log file
instead of the forked proc
[
https://issues.apache.org/jira/browse/LUCENE-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506392#comment-17506392
]
Christine Poerschke commented on LUCENE-10464:
--
https://github.com/apache/
Christine Poerschke created LUCENE-10464:
Summary: unnecessary for-loop in
WeightedSpanTermExtractor.extractWeightedSpanTerms
Key: LUCENE-10464
URL: https://issues.apache.org/jira/browse/LUCENE-10464
Muler created LUCENE-10465:
--
Summary: Unable to find antlr4.runtime
Key: LUCENE-10465
URL: https://issues.apache.org/jira/browse/LUCENE-10465
Project: Lucene - Core
Issue Type: Bug
Compone
[
https://issues.apache.org/jira/browse/LUCENE-10427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506402#comment-17506402
]
Adrien Grand commented on LUCENE-10427:
---
Thanks I understand better now. With the
[
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506403#comment-17506403
]
Tomoko Uchida commented on LUCENE-10461:
I am fine with keeping javaw support.
mocobeta commented on a change in pull request #746:
URL: https://github.com/apache/lucene/pull/746#discussion_r826259906
##
File path:
lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java
##
@@ -112,6 +120,7 @@ protected void execute(
Laun
mocobeta commented on a change in pull request #746:
URL: https://github.com/apache/lucene/pull/746#discussion_r826266136
##
File path:
lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java
##
@@ -125,13 +134,29 @@ protected void execute(
[
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506458#comment-17506458
]
Dawid Weiss commented on LUCENE-10461:
--
Hey, Tomoko. I don't think we should go in
Andriy Redko created LUCENE-10466:
-
Summary: IndexSortSortedNumericDocValuesRangeQuery unconditionally
assumes the usage of the LONG-encoded SortField
Key: LUCENE-10466
URL: https://issues.apache.org/jira/browse/L
[
https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andriy Redko updated LUCENE-10466:
--
Description:
We have run into this issue while migrating to OpenSearch and making changes to
[
https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506464#comment-17506464
]
Andriy Redko commented on LUCENE-10466:
---
[~jpountz] does the issue make sense to
mocobeta commented on a change in pull request #746:
URL: https://github.com/apache/lucene/pull/746#discussion_r826294904
##
File path: lucene/distribution/src/binary-release/bin/luke.cmd
##
@@ -18,21 +18,17 @@
SETLOCAL
SET MODULES=%~dp0..
-IF DEFINED LAUNCH_CMD GOTO testin
[
https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andriy Redko updated LUCENE-10466:
--
Priority: Minor (was: Major)
> IndexSortSortedNumericDocValuesRangeQuery unconditionally ass
[
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506488#comment-17506488
]
Dawid Weiss commented on LUCENE-10461:
--
Just to be clear - I did take a look at th
Yuti-G opened a new pull request #747:
URL: https://github.com/apache/lucene/pull/747
# Description
This change
* adds a new API - getTopDims in Facets to support users specify the number
of dims and children they want to get, and returns only these dims and children.
* override g
[
https://issues.apache.org/jira/browse/LUCENE-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506528#comment-17506528
]
Julie Tibshirani commented on LUCENE-10460:
---
It indeed seems okay to use a si
[
https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506530#comment-17506530
]
Julie Tibshirani commented on LUCENE-10466:
---
Thank you [~reta] for reporting
[
https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506530#comment-17506530
]
Julie Tibshirani edited comment on LUCENE-10466 at 3/14/22, 8:40 PM:
[
https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506530#comment-17506530
]
Julie Tibshirani edited comment on LUCENE-10466 at 3/14/22, 8:40 PM:
jtibshirani merged pull request #745:
URL: https://github.com/apache/lucene/pull/745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
[
https://issues.apache.org/jira/browse/LUCENE-10385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506531#comment-17506531
]
ASF subversion and git services commented on LUCENE-10385:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506532#comment-17506532
]
ASF subversion and git services commented on LUCENE-10458:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andriy Redko updated LUCENE-10466:
--
Description:
We have run into this issue while migrating to OpenSearch and making changes to
[
https://issues.apache.org/jira/browse/LUCENE-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506548#comment-17506548
]
Andriy Redko commented on LUCENE-10466:
---
Thanks a lot, [~julietibs] , working on
gsmiller commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r826440044
##
File path: lucene/facet/src/java/org/apache/lucene/facet/Facets.java
##
@@ -48,4 +48,13 @@ public abstract FacetResult getTopChildren(int topN, String
d
Yuti-G commented on pull request #747:
URL: https://github.com/apache/lucene/pull/747#issuecomment-1067392546
> Thanks for picking this up! I've looked at everything except for your
overridden implementation in SSDV faceting, but since I may run out of time to
look at that today, I'll go a
Yuti-G edited a comment on pull request #747:
URL: https://github.com/apache/lucene/pull/747#issuecomment-1067392546
> Thanks for picking this up! I've looked at everything except for your
overridden implementation in SSDV faceting, but since I may run out of time to
look at that today, I'
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r826455347
##
File path: lucene/facet/src/java/org/apache/lucene/facet/Facets.java
##
@@ -48,4 +48,13 @@ public abstract FacetResult getTopChildren(int topN, String
dim
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r826456302
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/range/TestRangeFacetCounts.java
##
@@ -243,6 +243,24 @@ public void testLongGetAllDims() throws E
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r826456758
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/sortedset/TestSortedSetDocValuesFacets.java
##
@@ -104,6 +104,65 @@ public void testBasic() throw
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r826461610
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/sortedset/TestSortedSetDocValuesFacets.java
##
@@ -104,6 +104,65 @@ public void testBasic() throw
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r82646
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/sortedset/TestSortedSetDocValuesFacets.java
##
@@ -104,6 +104,65 @@ public void testBasic() throw
Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r826461610
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/sortedset/TestSortedSetDocValuesFacets.java
##
@@ -104,6 +104,65 @@ public void testBasic() throw
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506640#comment-17506640
]
Yuting Gan commented on LUCENE-10325:
-
Thanks [~gsmiller] for creating issue!
I pr
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506640#comment-17506640
]
Yuting Gan edited comment on LUCENE-10325 at 3/15/22, 12:22 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506640#comment-17506640
]
Yuting Gan edited comment on LUCENE-10325 at 3/15/22, 12:25 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10467:
Description:
Currently, when calling getAllDims(0) in SortedSetDocValuesFacetCounts, it
would th
Yuting Gan created LUCENE-10467:
---
Summary: Throws IllegalArgumentException for getAllDims(0)
Key: LUCENE-10467
URL: https://issues.apache.org/jira/browse/LUCENE-10467
Project: Lucene - Core
Iss
[
https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10467:
Description:
Currently, when calling getAllDims(0) in SortedSetDocValuesFacetCounts, it
would th
[
https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10467:
Summary: Throws IllegalArgumentException for getAllDims if topN <= 0 (was:
Throws IllegalArgumen
LuXugang commented on a change in pull request #736:
URL: https://github.com/apache/lucene/pull/736#discussion_r826515036
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -198,16 +198,22 @@ public boole
54 matches
Mail list logo
