[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout

2022-03-16 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507377#comment-17507377 ] Dawid Weiss commented on LUCENE-10451: -- Yes, sure! Just cherry pick the commit. I

[GitHub] [lucene] vigyasharma commented on pull request #633: LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges.

2022-03-16 Thread GitBox
vigyasharma commented on pull request #633: URL: https://github.com/apache/lucene/pull/633#issuecomment-1068815107 1. Found a better way to handle addIndexes failures due to background merges - OneMerge objects store the error they run into, which can be pulled via `OneMerge.getExceptio

[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout

2022-03-16 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507393#comment-17507393 ] Peter Gromov commented on LUCENE-10451: --- I will cherry-pick a bit later, thanks!

[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout

2022-03-16 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507394#comment-17507394 ] Dawid Weiss commented on LUCENE-10451: -- It's an issue in Jira and changes.txt is t

[GitHub] [lucene] jpountz commented on a change in pull request #736: LUCENE-10458: BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-16 Thread GitBox
jpountz commented on a change in pull request #736: URL: https://github.com/apache/lucene/pull/736#discussion_r827711332 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -307,9 +292,16 @@ private Bounde

[jira] [Commented] (LUCENE-10468) Do not always do checkField() in DocValues.getXXX(LeafReader, String)

2022-03-16 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507395#comment-17507395 ] Lu Xugang commented on LUCENE-10468: checkField() originally designed for sorting/g

[jira] [Comment Edited] (LUCENE-10468) Do not always do checkField() in DocValues.getXXX(LeafReader, String)

2022-03-16 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507395#comment-17507395 ] Lu Xugang edited comment on LUCENE-10468 at 3/16/22, 7:55 AM: ---

[jira] [Commented] (LUCENE-10468) Do not always do checkField() in DocValues.getXXX(LeafReader, String)

2022-03-16 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507399#comment-17507399 ] Adrien Grand commented on LUCENE-10468: --- I agree that there is inconsistency betw

[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout

2022-03-16 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507402#comment-17507402 ] Peter Gromov commented on LUCENE-10451: --- OK, convinced, will add. > Hunspell: do

[GitHub] [lucene] donnerpeter merged pull request #723: LUCENE-10452: Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread GitBox
donnerpeter merged pull request #723: URL: https://github.com/apache/lucene/pull/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Commented] (LUCENE-10452) Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507404#comment-17507404 ] ASF subversion and git services commented on LUCENE-10452: -- Co

[GitHub] [lucene] donnerpeter commented on pull request #723: LUCENE-10452: Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread GitBox
donnerpeter commented on pull request #723: URL: https://github.com/apache/lucene/pull/723#issuecomment-1068841881 @dweiss do you approve of a backport here? (with changes.txt entry) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [lucene] dweiss commented on pull request #723: LUCENE-10452: Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread GitBox
dweiss commented on pull request #723: URL: https://github.com/apache/lucene/pull/723#issuecomment-1068850326 Yep, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507415#comment-17507415 ] ASF subversion and git services commented on LUCENE-10451: -- Co

[jira] [Commented] (LUCENE-10452) Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507414#comment-17507414 ] ASF subversion and git services commented on LUCENE-10452: -- Co

[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507419#comment-17507419 ] ASF subversion and git services commented on LUCENE-10451: -- Co

[jira] [Commented] (LUCENE-10452) Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507417#comment-17507417 ] ASF subversion and git services commented on LUCENE-10452: -- Co

[jira] [Commented] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507418#comment-17507418 ] ASF subversion and git services commented on LUCENE-10451: -- Co

[jira] [Commented] (LUCENE-10452) Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507416#comment-17507416 ] ASF subversion and git services commented on LUCENE-10452: -- Co

[jira] [Updated] (LUCENE-10451) Hunspell: don't perform potentially expensive spellchecking after timeout

2022-03-16 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gromov updated LUCENE-10451: -- Fix Version/s: 10.0 (main) > Hunspell: don't perform potentially expensive spellchecking afte

[jira] [Resolved] (LUCENE-10452) Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gromov resolved LUCENE-10452. --- Fix Version/s: 10.0 (main) 9.2 Resolution: Fixed > Hunspell: call

[jira] [Closed] (LUCENE-10452) Hunspell: call checkCanceled less frequently to reduce the overhead

2022-03-16 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gromov closed LUCENE-10452. - > Hunspell: call checkCanceled less frequently to reduce the overhead > ---

[GitHub] [lucene] LuXugang commented on pull request #742: LUCENE-10460: Delegating DocIdSetIterator could be replaced to DocIdSetIterator#range(int minDoc, int maxDoc) in IndexSortSortedNumericDocVal

2022-03-16 Thread GitBox
LuXugang commented on pull request #742: URL: https://github.com/apache/lucene/pull/742#issuecomment-1068884146 Optimized by #736 , so this issue closed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene] LuXugang closed pull request #742: LUCENE-10460: Delegating DocIdSetIterator could be replaced to DocIdSetIterator#range(int minDoc, int maxDoc) in IndexSortSortedNumericDocValuesRan

2022-03-16 Thread GitBox
LuXugang closed pull request #742: URL: https://github.com/apache/lucene/pull/742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Resolved] (LUCENE-10460) Delegating DocIdSetIterator could be replaced to DocIdSetIterator#range(int minDoc, int maxDoc) in IndexSortSortedNumericDocValuesRangeQuery

2022-03-16 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Xugang resolved LUCENE-10460. Resolution: Auto Closed optimized by  LUCENE-10458. > Delegating DocIdSetIterator could be repla

[GitHub] [lucene-solr] bszabo97 opened a new pull request #2647: SOLR-16095 Upgrade JQuery to 3.5.1 in velocity contrib modul

2022-03-16 Thread GitBox
bszabo97 opened a new pull request #2647: URL: https://github.com/apache/lucene-solr/pull/2647 - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x

[GitHub] [lucene] iverase commented on a change in pull request #736: LUCENE-10458: BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-16 Thread GitBox
iverase commented on a change in pull request #736: URL: https://github.com/apache/lucene/pull/736#discussion_r827815011 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -278,7 +287,21 @@ private Bounde

[jira] [Created] (LUCENE-10469) ConstantScoreQuery doesn't propagate its score mode correctly

2022-03-16 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10469: - Summary: ConstantScoreQuery doesn't propagate its score mode correctly Key: LUCENE-10469 URL: https://issues.apache.org/jira/browse/LUCENE-10469 Project: Lucene - C

[jira] [Commented] (LUCENE-10468) Do not always do checkField() in DocValues.getXXX(LeafReader, String)

2022-03-16 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507524#comment-17507524 ] Robert Muir commented on LUCENE-10468: -- -1 to adding leniency here. There's no goo

[GitHub] [lucene] jpountz merged pull request #750: LUCENE-10469: Fix score mode propagation in ConstantScoreQuery.

2022-03-16 Thread GitBox
jpountz merged pull request #750: URL: https://github.com/apache/lucene/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10469) ConstantScoreQuery doesn't propagate its score mode correctly

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507549#comment-17507549 ] ASF subversion and git services commented on LUCENE-10469: -- Co

[GitHub] [lucene-solr] janhoy commented on pull request #2647: SOLR-16095 Upgrade JQuery to 3.5.1 in velocity contrib modul

2022-03-16 Thread GitBox
janhoy commented on pull request #2647: URL: https://github.com/apache/lucene-solr/pull/2647#issuecomment-1069067329 Great. Plase also add a line to solr/CHANGES.txt file, under the 8.11.2 "Bug fixes" section. Have you tested that velocity now works? -- This is an automated message fr

[jira] [Resolved] (LUCENE-10469) ConstantScoreQuery doesn't propagate its score mode correctly

2022-03-16 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10469. --- Fix Version/s: 9.1 Resolution: Fixed > ConstantScoreQuery doesn't propagate its scor

[jira] [Resolved] (LUCENE-10468) Do not always do checkField() in DocValues.getXXX(LeafReader, String)

2022-03-16 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10468. --- Resolution: Not A Problem > Do not always do checkField() in DocValues.getXXX(LeafReader, S

[jira] [Commented] (LUCENE-10469) ConstantScoreQuery doesn't propagate its score mode correctly

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507555#comment-17507555 ] ASF subversion and git services commented on LUCENE-10469: -- Co

[jira] [Commented] (LUCENE-10469) ConstantScoreQuery doesn't propagate its score mode correctly

2022-03-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507556#comment-17507556 ] ASF subversion and git services commented on LUCENE-10469: -- Co

[GitHub] [lucene] jpountz commented on a change in pull request #672: LUCENE-10418: Optimize `Query#rewrite` in the non-scoring case.

2022-03-16 Thread GitBox
jpountz commented on a change in pull request #672: URL: https://github.com/apache/lucene/pull/672#discussion_r803887266 ## File path: lucene/core/src/java/org/apache/lucene/search/ConstantScoreQuery.java ## @@ -114,7 +124,19 @@ public long cost() { @Override public Weigh

[GitHub] [lucene] gsmiller commented on a change in pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-16 Thread GitBox
gsmiller commented on a change in pull request #747: URL: https://github.com/apache/lucene/pull/747#discussion_r828050128 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -190,20 +235,45 @@ private FacetResult getPa

[GitHub] [lucene] gsmiller commented on a change in pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-16 Thread GitBox
gsmiller commented on a change in pull request #747: URL: https://github.com/apache/lucene/pull/747#discussion_r828063663 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -190,20 +235,45 @@ private FacetResult getPa

[GitHub] [lucene] jpountz commented on pull request #672: LUCENE-10418: Optimize `Query#rewrite` in the non-scoring case.

2022-03-16 Thread GitBox
jpountz commented on pull request #672: URL: https://github.com/apache/lucene/pull/672#issuecomment-1069185004 I plan to merge in the coming days if there are no objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [lucene] rmuir commented on a change in pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

2022-03-16 Thread GitBox
rmuir commented on a change in pull request #740: URL: https://github.com/apache/lucene/pull/740#discussion_r828219001 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/UnknownDictionaryWriter.java ## @@ -56,9 +59,14 @@ public void putInvokeDef

[GitHub] [lucene] iverase closed pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-03-16 Thread GitBox
iverase closed pull request #692: URL: https://github.com/apache/lucene/pull/692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] iverase closed pull request #698: LUCENE-10429: Change how DocIdSetBuilder compute the cost of the dense iterator

2022-03-16 Thread GitBox
iverase closed pull request #698: URL: https://github.com/apache/lucene/pull/698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene-solr] bszabo97 commented on pull request #2647: SOLR-16095 Upgrade JQuery to 3.5.1 in velocity contrib module

2022-03-16 Thread GitBox
bszabo97 commented on pull request #2647: URL: https://github.com/apache/lucene-solr/pull/2647#issuecomment-1069361510 I uploaded a new commit with the CHANGES.txt. Also, yes, I have tested that velocity is working with the newer jquery and was not working with the older one. --

[GitHub] [lucene] iverase commented on pull request #698: LUCENE-10429: Change how DocIdSetBuilder compute the cost of the dense iterator

2022-03-16 Thread GitBox
iverase commented on pull request #698: URL: https://github.com/apache/lucene/pull/698#issuecomment-1069345393 won't happen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] iverase commented on pull request #692: LUCENE-10311: Different implementations of DocIdSetBuilder for points and terms

2022-03-16 Thread GitBox
iverase commented on pull request #692: URL: https://github.com/apache/lucene/pull/692#issuecomment-1069345096 won't happen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [lucene] Yuti-G commented on a change in pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-16 Thread GitBox
Yuti-G commented on a change in pull request #747: URL: https://github.com/apache/lucene/pull/747#discussion_r828260482 ## File path: lucene/facet/src/java/org/apache/lucene/facet/sortedset/SortedSetDocValuesFacetCounts.java ## @@ -414,4 +493,107 @@ public int compare(FacetRes

[GitHub] [lucene] jtibshirani commented on a change in pull request #736: LUCENE-10458: BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-16 Thread GitBox
jtibshirani commented on a change in pull request #736: URL: https://github.com/apache/lucene/pull/736#discussion_r828333005 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -198,16 +200,23 @@ public bo

[GitHub] [lucene] jtibshirani commented on a change in pull request #736: LUCENE-10458: BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-16 Thread GitBox
jtibshirani commented on a change in pull request #736: URL: https://github.com/apache/lucene/pull/736#discussion_r828316628 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -278,7 +287,21 @@ private Bo

[GitHub] [lucene] jtibshirani commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-16 Thread GitBox
jtibshirani commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1069465953 Thanks @reta! This is on my list of PRs to review, I'd just like to wait until https://github.com/apache/lucene/pull/736 wraps up as it might affect this logic a bit. A

[GitHub] [lucene] jtibshirani edited a comment on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-16 Thread GitBox
jtibshirani edited a comment on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1069465953 Thanks @reta! This is on my list of PRs to review, I'd just like to wait until https://github.com/apache/lucene/pull/736 wraps up as it might affect this logic a bit.

[GitHub] [lucene] jtibshirani commented on a change in pull request #736: LUCENE-10458: BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-16 Thread GitBox
jtibshirani commented on a change in pull request #736: URL: https://github.com/apache/lucene/pull/736#discussion_r828330417 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestIndexSortSortedNumericDocValuesRangeQuery.java ## @@ -459,54 +461,55 @@ publi

[GitHub] [lucene] jtibshirani commented on a change in pull request #736: LUCENE-10458: BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

2022-03-16 Thread GitBox
jtibshirani commented on a change in pull request #736: URL: https://github.com/apache/lucene/pull/736#discussion_r828339904 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java ## @@ -306,14 +329,14 @@ private s

[GitHub] [lucene] reta commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-16 Thread GitBox
reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1069493698 Thanks a lot @jtibshirani , I will re-target the `main` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (LUCENE-10448) MergeRateLimiter doesn't always limit instant rate.

2022-03-16 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507884#comment-17507884 ] Vigya Sharma commented on LUCENE-10448: --- [~jpountz] - we could handle the edge ca

[jira] [Created] (LUCENE-10470) Unable to Tessellate polygon

2022-03-16 Thread Yixun Xu (Jira)
Yixun Xu created LUCENE-10470: - Summary: Unable to Tessellate polygon Key: LUCENE-10470 URL: https://issues.apache.org/jira/browse/LUCENE-10470 Project: Lucene - Core Issue Type: Bug Co

[jira] [Updated] (LUCENE-10470) Unable to Tessellate polygon

2022-03-16 Thread Yixun Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yixun Xu updated LUCENE-10470: -- Description: I have a polygon that causes {{Tessellator.tessellate}} to throw an "Unable to Tessella

[jira] [Updated] (LUCENE-10470) Unable to Tessellate polygon

2022-03-16 Thread Yixun Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yixun Xu updated LUCENE-10470: -- Description: I have a polygon that causes {{Tessellator.tessellate}} to throw an "Unable to Tessella

[jira] [Updated] (LUCENE-10470) Unable to Tessellate polygon

2022-03-16 Thread Yixun Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yixun Xu updated LUCENE-10470: -- Attachment: image-2022-03-16-18-12-43-411.png > Unable to Tessellate polygon > --

[jira] [Updated] (LUCENE-10470) Unable to Tessellate polygon

2022-03-16 Thread Yixun Xu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yixun Xu updated LUCENE-10470: -- Attachment: (was: image-2022-03-16-17-40-18-721.png) > Unable to Tessellate polygon > ---

[jira] [Updated] (LUCENE-10467) Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-03-16 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10467: Summary: Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0 (was: Th

[GitHub] [lucene] Yuti-G opened a new pull request #751: LUCENE-10467: Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-03-16 Thread GitBox
Yuti-G opened a new pull request #751: URL: https://github.com/apache/lucene/pull/751 # Description Currently, there are different behaviors from subclass that implements `getAllDims` and `getTopChildren` when the requested `topN` is invalid (`topN <= 0`). Some overridden implementa

[jira] [Updated] (LUCENE-10467) Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-03-16 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10467: Description: Currently, there are different behaviors from subclass that implements `getAllDims`

[jira] [Updated] (LUCENE-10467) Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-03-16 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10467: Description: Currently, there are different behaviors from subclass that implements `getAllDims`