[GitHub] [lucene] wjp719 commented on pull request #687: LUCENE-10425:speed up IndexSortSortedNumericDocValuesRangeQuery#BoundedDocSetIdIterator construction using bkd binary search

2022-03-28 Thread GitBox
wjp719 commented on pull request #687: URL: https://github.com/apache/lucene/pull/687#issuecomment-1081341226 @jpountz @iverase Hi, is this pr ok now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene] wjp719 commented on pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
wjp719 commented on pull request #731: URL: https://github.com/apache/lucene/pull/731#issuecomment-1081337873 @gautamworah96 I refactor the code again, please review it again, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r837001367 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -163,6 +165,69 @@ public void visit(QueryVisitor visitor)

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r837000418 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -163,6 +165,69 @@ public void visit(QueryVisitor visitor)

[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #771: URL: https://github.com/apache/lucene/pull/771#discussion_r836975410 ## File path: CONTRIBUTING.md ## @@ -0,0 +1,124 @@ + + +# Contributing to Lucene Guide + +## Working with Code + +### Getting the source code + +First of

[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #771: URL: https://github.com/apache/lucene/pull/771#discussion_r836975410 ## File path: CONTRIBUTING.md ## @@ -0,0 +1,124 @@ + + +# Contributing to Lucene Guide + +## Working with Code + +### Getting the source code + +First of

[GitHub] [lucene] gautamworah96 commented on a change in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch

2022-03-28 Thread GitBox
gautamworah96 commented on a change in pull request #762: URL: https://github.com/apache/lucene/pull/762#discussion_r836975590 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java ## @@ -0,0 +1,95 @@ +/*

[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #771: URL: https://github.com/apache/lucene/pull/771#discussion_r836975410 ## File path: CONTRIBUTING.md ## @@ -0,0 +1,124 @@ + + +# Contributing to Lucene Guide + +## Working with Code + +### Getting the source code + +First of

[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #771: URL: https://github.com/apache/lucene/pull/771#discussion_r836967733 ## File path: CONTRIBUTING.md ## @@ -0,0 +1,128 @@ + + +# Contributing to Lucene Guide + +## Working with Code + +### Getting the source code + +First of

[GitHub] [lucene] mocobeta commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #771: URL: https://github.com/apache/lucene/pull/771#discussion_r836967094 ## File path: CONTRIBUTING.md ## @@ -0,0 +1,128 @@ + + +# Contributing to Lucene Guide + +## Working with Code + +### Getting the source code + +First of

[GitHub] [lucene] gautamworah96 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
gautamworah96 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r836963073 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -761,4 +764,103 @@ public void

[jira] [Comment Edited] (LUCENE-10325) Add getTopDims functionality to Facets

2022-03-28 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506640#comment-17506640 ] Yuting Gan edited comment on LUCENE-10325 at 3/29/22, 12:17 AM: Thanks

[jira] [Commented] (LUCENE-10325) Add getTopDims functionality to Facets

2022-03-28 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513732#comment-17513732 ] Greg Miller commented on LUCENE-10325: -- Also opened LUCENE-10488 to track other optimizations. >

[jira] [Resolved] (LUCENE-10325) Add getTopDims functionality to Facets

2022-03-28 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10325. -- Fix Version/s: 9.2 Resolution: Fixed Merged and backported. Thanks again

[jira] [Commented] (LUCENE-10325) Add getTopDims functionality to Facets

2022-03-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513729#comment-17513729 ] ASF subversion and git services commented on LUCENE-10325: -- Commit

[GitHub] [lucene] gsmiller merged pull request #773: LUCENE-10325: Add getTopDims functionality to Facets (#747)

2022-03-28 Thread GitBox
gsmiller merged pull request #773: URL: https://github.com/apache/lucene/pull/773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (LUCENE-10488) Optimize Facets#getTopDims across Facets implementations

2022-03-28 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513722#comment-17513722 ] Greg Miller edited comment on LUCENE-10488 at 3/28/22, 11:41 PM: - Note

[jira] [Commented] (LUCENE-10488) Optimize Facets#getTopDims across Facets implementations

2022-03-28 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513722#comment-17513722 ] Greg Miller commented on LUCENE-10488: -- Note that I have an [open

[jira] [Created] (LUCENE-10488) Optimize Facets#getTopDims across Facets implementations

2022-03-28 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10488: Summary: Optimize Facets#getTopDims across Facets implementations Key: LUCENE-10488 URL: https://issues.apache.org/jira/browse/LUCENE-10488 Project: Lucene - Core

[GitHub] [lucene] gsmiller opened a new pull request #773: LUCENE-10325: Add getTopDims functionality to Facets (#747)

2022-03-28 Thread GitBox
gsmiller opened a new pull request #773: URL: https://github.com/apache/lucene/pull/773 Backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (LUCENE-10325) Add getTopDims functionality to Facets

2022-03-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513703#comment-17513703 ] ASF subversion and git services commented on LUCENE-10325: -- Commit

[jira] [Commented] (LUCENE-10325) Add getTopDims functionality to Facets

2022-03-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513702#comment-17513702 ] ASF subversion and git services commented on LUCENE-10325: -- Commit

[GitHub] [lucene] gsmiller merged pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-28 Thread GitBox
gsmiller merged pull request #747: URL: https://github.com/apache/lucene/pull/747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

2022-03-28 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r836886681 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

2022-03-28 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r836886681 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

2022-03-28 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r836886681 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

2022-03-28 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r836886681 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] dweiss commented on a change in pull request #770: Implement method to add all collection elements to a PriorityQueue

2022-03-28 Thread GitBox
dweiss commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r836748820 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +163,43 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] dweiss commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

2022-03-28 Thread GitBox
dweiss commented on a change in pull request #771: URL: https://github.com/apache/lucene/pull/771#discussion_r836744907 ## File path: CONTRIBUTING.md ## @@ -0,0 +1,128 @@ + + +# Contributing to Lucene Guide + +## Working with Code + +### Getting the source code + +First of

[GitHub] [lucene] dweiss commented on a change in pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

2022-03-28 Thread GitBox
dweiss commented on a change in pull request #771: URL: https://github.com/apache/lucene/pull/771#discussion_r836744402 ## File path: CONTRIBUTING.md ## @@ -0,0 +1,128 @@ + + +# Contributing to Lucene Guide + +## Working with Code + +### Getting the source code + +First of

[jira] [Commented] (LUCENE-10484) Add support for concurrent facets random sampling

2022-03-28 Thread Luca Cavanna (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513572#comment-17513572 ] Luca Cavanna commented on LUCENE-10484: --- I am not sure why the PR is not getting linked to the

[jira] [Updated] (LUCENE-10484) Add support for concurrent facets random sampling

2022-03-28 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller updated LUCENE-10484: - Component/s: modules/facet > Add support for concurrent facets random sampling >

[GitHub] [lucene] gsmiller commented on pull request #747: LUCENE-10325: Add getTopDims functionality to Facets

2022-03-28 Thread GitBox
gsmiller commented on pull request #747: URL: https://github.com/apache/lucene/pull/747#issuecomment-1080958647 Thanks for running the benchmarks. The regression to taxo-faceting seems weird indeed since you didn't touch that code at all (as you point out). Maybe double-check that the

[GitHub] [lucene] gsmiller commented on a change in pull request #751: LUCENE-10467: Throws IllegalArgumentException for getAllDims and getTopChildren if topN <= 0

2022-03-28 Thread GitBox
gsmiller commented on a change in pull request #751: URL: https://github.com/apache/lucene/pull/751#discussion_r836685698 ## File path: lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java ## @@ -348,6 +348,9 @@ private void increment(long value) {

[GitHub] [lucene-solr] cpoerschke commented on pull request #2643: SOLR-9359 Make Config API work for warming queries

2022-03-28 Thread GitBox
cpoerschke commented on pull request #2643: URL: https://github.com/apache/lucene-solr/pull/2643#issuecomment-1080947093 > ... Is there anything similar I could take a lead from? Perhaps these two: *

[GitHub] [lucene-solr] andywebb1975 commented on pull request #2643: SOLR-9359 Make Config API work for warming queries

2022-03-28 Thread GitBox
andywebb1975 commented on pull request #2643: URL: https://github.com/apache/lucene-solr/pull/2643#issuecomment-1080930412 I've given this some more attention: * found the `getArgs().getAll()` method which means it now works with a flat list like in my last comment above * moved

[jira] [Commented] (LUCENE-10454) UnifiedHighlighter can miss terms because of query rewrites

2022-03-28 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513493#comment-17513493 ] Julie Tibshirani commented on LUCENE-10454: --- Thanks for looking into this! I don't understand

[GitHub] [lucene] wjp719 commented on pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
wjp719 commented on pull request #731: URL: https://github.com/apache/lucene/pull/731#issuecomment-1080600767 @gautamworah96 Hi, I have refactor the code as you suggest, please help to review it again, thanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r836367709 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -761,4 +764,67 @@ public void

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r836366764 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -163,6 +165,60 @@ public void visit(QueryVisitor visitor)

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r836366205 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -314,6 +370,32 @@ public Scorer scorer(LeafReaderContext

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-28 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r836331353 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -163,6 +165,60 @@ public void visit(QueryVisitor visitor)

[GitHub] [lucene] romseygeek commented on pull request #679: Monitor Improvements LUCENE-10422

2022-03-28 Thread GitBox
romseygeek commented on pull request #679: URL: https://github.com/apache/lucene/pull/679#issuecomment-1080474711 @mogui there isn't a roadmap for the monitor itself, but please do open issues and/or PRs if you have ideas for other improvements! -- This is an automated message from the

[GitHub] [lucene] mocobeta commented on a change in pull request #772: LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #772: URL: https://github.com/apache/lucene/pull/772#discussion_r836245264 ## File path: lucene/analysis/nori/src/java/module-info.java ## @@ -23,7 +23,6 @@ exports org.apache.lucene.analysis.ko; exports

[GitHub] [lucene] mocobeta commented on a change in pull request #772: LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #772: URL: https://github.com/apache/lucene/pull/772#discussion_r836244662 ## File path: lucene/analysis/kuromoji/src/java/module-info.java ## @@ -24,7 +24,6 @@ exports org.apache.lucene.analysis.ja.completion; exports

[GitHub] [lucene] mocobeta commented on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori

2022-03-28 Thread GitBox
mocobeta commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1080432882 Just a quick note: I opened #772, which slightly improves the encapsulation of the dictionary-related internals. The whole refactoring was done by IDE and I think there wouldn't

[GitHub] [lucene] mocobeta commented on pull request #771: LUCENE-10184: add CONTRIBUTING.md; reorganize README.

2022-03-28 Thread GitBox
mocobeta commented on pull request #771: URL: https://github.com/apache/lucene/pull/771#issuecomment-1080405884 would anyone want to review this... i'll wait until tomorrow then merge it (if there are no objections). -- This is an automated message from the Apache Git Service. To

[GitHub] [lucene] mocobeta commented on pull request #772: LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict

2022-03-28 Thread GitBox
mocobeta commented on pull request #772: URL: https://github.com/apache/lucene/pull/772#issuecomment-1080368517 We don't have good tests for dictionary builders (testing them is difficult), `gradlew regenerate` tasks for kuromoji / nori works, and do not change generated resources. --

[GitHub] [lucene] mocobeta commented on a change in pull request #772: LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #772: URL: https://github.com/apache/lucene/pull/772#discussion_r836183526 ## File path: lucene/analysis/nori/src/java/org/apache/lucene/analysis/ko/dict/DictionaryConstants.java ## @@ -17,7 +17,7 @@ package

[GitHub] [lucene] mocobeta commented on a change in pull request #772: LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #772: URL: https://github.com/apache/lucene/pull/772#discussion_r836183038 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/TokenInfoMorphData.java ## @@ -26,7 +26,7 @@ import

[GitHub] [lucene] mocobeta commented on a change in pull request #772: LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko].dict

2022-03-28 Thread GitBox
mocobeta commented on a change in pull request #772: URL: https://github.com/apache/lucene/pull/772#discussion_r836182719 ## File path: lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/dict/DictionaryConstants.java ## @@ -17,7 +17,7 @@ package

[GitHub] [lucene] mocobeta opened a new pull request #772: LUCENE-10475: Merge o.a.l.a.[ja|ko].util into o.a.l.a.[ja|ko

2022-03-28 Thread GitBox
mocobeta opened a new pull request #772: URL: https://github.com/apache/lucene/pull/772 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach taken

[jira] [Created] (LUCENE-10487) Can IndexSearcher enable search concurrency by default?

2022-03-28 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10487: - Summary: Can IndexSearcher enable search concurrency by default? Key: LUCENE-10487 URL: https://issues.apache.org/jira/browse/LUCENE-10487 Project: Lucene - Core