[jira] [Commented] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515082#comment-17515082 ] Dawid Weiss commented on LUCENE-10485: -- Ok. If you want to use module patching the

[GitHub] [lucene] zacharymorn commented on a change in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-03-30 Thread GitBox
zacharymorn commented on a change in pull request #767: URL: https://github.com/apache/lucene/pull/767#discussion_r839159814 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldExistsQuery.java ## @@ -0,0 +1,165 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene] zacharymorn commented on a change in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-03-30 Thread GitBox
zacharymorn commented on a change in pull request #767: URL: https://github.com/apache/lucene/pull/767#discussion_r839158832 ## File path: lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java ## @@ -31,42 +28,21 @@ /** * A {@link Query} that matches

[GitHub] [lucene] zacharymorn commented on pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-03-30 Thread GitBox
zacharymorn commented on pull request #767: URL: https://github.com/apache/lucene/pull/767#issuecomment-1084053516 Thanks @mikemccand @jpountz for the reviews and suggestions! I've gone ahead and merge the test cases, and will remove the deprecated queries as well in follow-up PR. -- Th

[jira] [Updated] (LUCENE-10495) Fix bug in TaxonomyFacets

2022-03-30 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10495: Description: Found a bug in TaxonomyFacets when trying to use the siblingsLoaded function. sibli

[GitHub] [lucene] Yuti-G opened a new pull request #778: LUCENE-10495: Fix bug in TaxonomyFacets

2022-03-30 Thread GitBox
Yuti-G opened a new pull request #778: URL: https://github.com/apache/lucene/pull/778 # Description Found a bug in TaxonomyFacets when trying to use the siblingsLoaded function. Currently, siblingsLoaded() returns children!= null, but it should return siblings != null; # Solu

[jira] [Updated] (LUCENE-10495) Fix bug in TaxonomyFacets

2022-03-30 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10495: Description: Found a bug in TaxonomyFacets when trying to use the siblingsLoaded function. sibli

[jira] [Updated] (LUCENE-10495) Fix bug in TaxonomyFacets

2022-03-30 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10495: Attachment: Screen Shot 2022-03-30 at 8.02.15 PM.png > Fix bug in TaxonomyFacets > --

[jira] [Updated] (LUCENE-10495) Fix bug in TaxonomyFacets

2022-03-30 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10495: Description: Found a bug in TaxonomyFacets when trying to use the siblingsLoaded function.    

[jira] [Updated] (LUCENE-10495) Fix bug in TaxonomyFacets

2022-03-30 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10495: Priority: Minor (was: Blocker) > Fix bug in TaxonomyFacets > - > >

[jira] [Updated] (LUCENE-10495) Fix bug in TaxonomyFacets

2022-03-30 Thread Yuting Gan (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuting Gan updated LUCENE-10495: Description: Found a bug in TaxonomyFacets when trying to use the siblingsLoaded function    

[jira] [Created] (LUCENE-10495) Fix bug in TaxonomyFacets

2022-03-30 Thread Yuting Gan (Jira)
Yuting Gan created LUCENE-10495: --- Summary: Fix bug in TaxonomyFacets Key: LUCENE-10495 URL: https://issues.apache.org/jira/browse/LUCENE-10495 Project: Lucene - Core Issue Type: Bug

[GitHub] [lucene] Yuti-G edited a comment on pull request #777: LUCENE-10488: Optimize Facets#getTopDims across Facets implementations

2022-03-30 Thread GitBox
Yuti-G edited a comment on pull request #777: URL: https://github.com/apache/lucene/pull/777#issuecomment-1083703784 The changes in this PR is very similar to the changes in SortedSetDocValuesFacetCounts in [#747](https://github.com/apache/lucene/pull/747). Please see the benchmark result

[GitHub] [lucene] Yuti-G commented on pull request #777: LUCENE-10488: Optimize Facets#getTopDims across Facets implementations

2022-03-30 Thread GitBox
Yuti-G commented on pull request #777: URL: https://github.com/apache/lucene/pull/777#issuecomment-1083703784 The changes in this PR is very similar to the changes in SortedSetDocValuesFacetCounts [#747](https://github.com/apache/lucene/pull/747). Please see the benchmark results below, s

[GitHub] [lucene] Yuti-G opened a new pull request #777: LUCENE-10488: Optimize Facets#getTopDims across Facets implementations

2022-03-30 Thread GitBox
Yuti-G opened a new pull request #777: URL: https://github.com/apache/lucene/pull/777 # Description This change overrides getTopDims in ConcurrentSortedSetDocValuesFacetCounts to optimize the current method of getting dimCount, return FacetResult and resolve child paths for only the

[jira] [Comment Edited] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514917#comment-17514917 ] Tomoko Uchida edited comment on LUCENE-10485 at 3/30/22, 8:21 PM: ---

[GitHub] [lucene] gautamworah96 commented on a change in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch

2022-03-30 Thread GitBox
gautamworah96 commented on a change in pull request #762: URL: https://github.com/apache/lucene/pull/762#discussion_r838826469 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java ## @@ -0,0 +1,95 @@ +/* +

[jira] [Commented] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514917#comment-17514917 ] Tomoko Uchida commented on LUCENE-10485: I'm not trying to make a new test modu

[GitHub] [lucene] BaurzhanSakhariev commented on pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on pull request #770: URL: https://github.com/apache/lucene/pull/770#issuecomment-1083556811 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [lucene] gautamworah96 commented on a change in pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch

2022-03-30 Thread GitBox
gautamworah96 commented on a change in pull request #762: URL: https://github.com/apache/lucene/pull/762#discussion_r838826469 ## File path: lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java ## @@ -0,0 +1,95 @@ +/* +

[GitHub] [lucene] nknize edited a comment on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-30 Thread GitBox
nknize edited a comment on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1083444100 > In my opinion, long-term this IndexSortSortedNumericDocValuesRangeQuery should no longer be exposed to users. Lucene would have long/int/double/float fields ([LUCENE-10162

[GitHub] [lucene] nknize edited a comment on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-30 Thread GitBox
nknize edited a comment on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1083444100 > In my opinion, long-term this IndexSortSortedNumericDocValuesRangeQuery should no longer be exposed to users. Lucene would have long/int/double/float fields ([LUCENE-10162

[GitHub] [lucene] nknize commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-30 Thread GitBox
nknize commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1083444100 > In my opinion, long-term this IndexSortSortedNumericDocValuesRangeQuery should no longer be exposed to users. Lucene would have long/int/double/float fields ([LUCENE-10162](https

[jira] [Commented] (LUCENE-10162) Add IntField, LongField, FloatField and DoubleField classes to index both points and doc values

2022-03-30 Thread Nick Knize (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514866#comment-17514866 ] Nick Knize commented on LUCENE-10162: - +1 bq. The way I was thinking of addressing

[GitHub] [lucene] reta commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-30 Thread GitBox
reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1083437878 @jtibshirani comments addressed, thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [lucene] reta commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-30 Thread GitBox
reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1083423388 @jpountz thank you, sounds like everyone is on the same page, I will go ahead with the change proposed by @jtibshirani , thanks! -- This is an automated message from the Apache Git

[jira] [Resolved] (LUCENE-10494) Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-10494. -- Assignee: Dawid Weiss Resolution: Fixed > Implement method to bulk add all collection e

[GitHub] [lucene] dweiss commented on pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
dweiss commented on pull request #770: URL: https://github.com/apache/lucene/pull/770#issuecomment-1083420937 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] dweiss merged pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
dweiss merged pull request #770: URL: https://github.com/apache/lucene/pull/770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514831#comment-17514831 ] Dawid Weiss commented on LUCENE-10485: -- Hi [~tomoko] . If you can eliminate split

[GitHub] [lucene] dweiss commented on pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
dweiss commented on pull request #770: URL: https://github.com/apache/lucene/pull/770#issuecomment-1083411399 I've added a proper issue number (https://issues.apache.org/jira/browse/LUCENE-10494) and tweaked minor details of the implementation (exception types thrown in addAll and add were

[jira] [Updated] (LUCENE-10494) Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10494: - Description: PR at [https://github.com/apache/lucene/pull/770/files] > Implement method to bulk

[jira] [Created] (LUCENE-10494) Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10494: Summary: Implement method to bulk add all collection elements to a PriorityQueue Key: LUCENE-10494 URL: https://issues.apache.org/jira/browse/LUCENE-10494 Project: Lu

[jira] [Updated] (LUCENE-10494) Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10494: - Fix Version/s: 9.2 > Implement method to bulk add all collection elements to a PriorityQueue >

[GitHub] [lucene] jpountz commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-30 Thread GitBox
jpountz commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1083384716 Interestingly #687 would further specialize this query for longs by relying on the `LongPoint` encoding. cc @wjp719 > I was phasing out FLOAT / DOUBLE support, as per your c

[jira] [Resolved] (LUCENE-10491) TaxonomyFacetSumValueSource incorrectly provides scores to doc values

2022-03-30 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller resolved LUCENE-10491. -- Fix Version/s: 9.2 Resolution: Fixed Fixed and backported. > TaxonomyFacetSumValueSou

[jira] [Commented] (LUCENE-10491) TaxonomyFacetSumValueSource incorrectly provides scores to doc values

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514814#comment-17514814 ] ASF subversion and git services commented on LUCENE-10491: -- Co

[jira] [Commented] (LUCENE-10491) TaxonomyFacetSumValueSource incorrectly provides scores to doc values

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514809#comment-17514809 ] ASF subversion and git services commented on LUCENE-10491: -- Co

[GitHub] [lucene] gsmiller merged pull request #775: LUCENE-10491: Fix correctness bug in TaxonomyFacetSumValueSource score providing

2022-03-30 Thread GitBox
gsmiller merged pull request #775: URL: https://github.com/apache/lucene/pull/775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Updated] (LUCENE-10493) Can we unify the viterbi search logic in the tokenizers of kuromoji and nori?

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10493: --- Description: We now have common dictionary interfaces for kuromoji and nori ([LUCENE-10393

[GitHub] [lucene] jpountz merged pull request #763: LUCENE-10002: Replace usages of search(Query, Collector) in CheckHits

2022-03-30 Thread GitBox
jpountz merged pull request #763: URL: https://github.com/apache/lucene/pull/763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [lucene] jpountz commented on a change in pull request #763: LUCENE-10002: Replace usages of search(Query, Collector) in CheckHits

2022-03-30 Thread GitBox
jpountz commented on a change in pull request #763: URL: https://github.com/apache/lucene/pull/763#discussion_r838709808 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/search/CheckHits.java ## @@ -634,12 +694,13 @@ public static void checkTopScores(Random

[jira] [Updated] (LUCENE-10493) Can we unify the viterbi search logic in the tokenizers of kuromoji and nori?

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10493: --- Summary: Can we unify the viterbi search logic in the tokenizers of kuromoji and nori? (wa

[jira] [Created] (LUCENE-10493) Can we unify the tokenizer of kuromoji and nori?

2022-03-30 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-10493: -- Summary: Can we unify the tokenizer of kuromoji and nori? Key: LUCENE-10493 URL: https://issues.apache.org/jira/browse/LUCENE-10493 Project: Lucene - Core

[GitHub] [lucene] reta commented on pull request #749: LUCENE-10466: IndexSortSortedNumericDocValuesRangeQuery unconditionally assumes the usage of the LONG-encoded SortField

2022-03-30 Thread GitBox
reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1083295848 > To me it'd be best to only tackle the main bug you ran into, the ClassCastException when using integers. To prevent errors when using double and float values, we could add an expli

[GitHub] [lucene] gautamworah96 opened a new pull request #776: LUCENE-10492 Remove redundant taxonomy.8.10.0-cfs.zip backward compatibility index

2022-03-30 Thread GitBox
gautamworah96 opened a new pull request #776: URL: https://github.com/apache/lucene/pull/776 I discovered this hanging zip file in the main branch while working on trying to directly replace actual index files ([LUCENE-10482](https://issues.apache.org/jira/browse/LUCENE-10482)). I s

[GitHub] [lucene] javanna commented on a change in pull request #763: LUCENE-10002: Replace usages of search(Query, Collector) in CheckHits

2022-03-30 Thread GitBox
javanna commented on a change in pull request #763: URL: https://github.com/apache/lucene/pull/763#discussion_r838664696 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/search/CheckHits.java ## @@ -634,12 +694,13 @@ public static void checkTopScores(Random

[jira] [Commented] (LUCENE-10486) Avoid unnecessary overhead in TopScoreDoc and TopField collector manager

2022-03-30 Thread Luca Cavanna (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514766#comment-17514766 ] Luca Cavanna commented on LUCENE-10486: --- Thanks for the feedback, I am also not a

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-30 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838661197 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -46,7 +48,7 @@ * * @lucene.experimental */ -public ab

[jira] [Updated] (LUCENE-10492) Remove redundant taxonomy.8.10.0-cfs.zip backward compatibility index

2022-03-30 Thread Gautam Worah (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gautam Worah updated LUCENE-10492: -- Description: I discovered this hanging zip file in the {{main}} branch while working on tryi

[jira] [Created] (LUCENE-10492) Remove redundant taxonomy.8.10.0-cfs.zip backward compatibility index

2022-03-30 Thread Gautam Worah (Jira)
Gautam Worah created LUCENE-10492: - Summary: Remove redundant taxonomy.8.10.0-cfs.zip backward compatibility index Key: LUCENE-10492 URL: https://issues.apache.org/jira/browse/LUCENE-10492 Project: Lu

[jira] [Assigned] (LUCENE-10491) TaxonomyFacetSumValueSource incorrectly provides scores to doc values

2022-03-30 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Miller reassigned LUCENE-10491: Assignee: Greg Miller > TaxonomyFacetSumValueSource incorrectly provides scores to doc v

[GitHub] [lucene] gsmiller opened a new pull request #775: LUCENE-10491: Fix correctness bug in TaxonomyFacetSumValueSource score providing

2022-03-30 Thread GitBox
gsmiller opened a new pull request #775: URL: https://github.com/apache/lucene/pull/775 # Description Fixes a bug in TaxonomyFacetSumValueSource score providing # Solution Fixed the bug # Tests Added to an existing test case to demonstrate the bug #

[jira] [Created] (LUCENE-10491) TaxonomyFacetSumValueSource incorrectly provides scores to doc values

2022-03-30 Thread Greg Miller (Jira)
Greg Miller created LUCENE-10491: Summary: TaxonomyFacetSumValueSource incorrectly provides scores to doc values Key: LUCENE-10491 URL: https://issues.apache.org/jira/browse/LUCENE-10491 Project: Luce

[GitHub] [lucene] madrob commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-30 Thread GitBox
madrob commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838617372 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java ## @@ -46,7 +48,7 @@ * * @lucene.experimental */ -public ab

[GitHub] [lucene] gsmiller commented on a change in pull request #718: LUCENE-10444: Support alternate aggregation functions in association facets

2022-03-30 Thread GitBox
gsmiller commented on a change in pull request #718: URL: https://github.com/apache/lucene/pull/718#discussion_r838621313 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacetFloatAssociations.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apach

[GitHub] [lucene] jpountz commented on a change in pull request #763: LUCENE-10002: Replace usages of search(Query, Collector) in CheckHits

2022-03-30 Thread GitBox
jpountz commented on a change in pull request #763: URL: https://github.com/apache/lucene/pull/763#discussion_r838607150 ## File path: lucene/test-framework/src/java/org/apache/lucene/tests/search/CheckHits.java ## @@ -634,12 +694,13 @@ public static void checkTopScores(Random

[jira] [Commented] (LUCENE-10486) Avoid unnecessary overhead in TopScoreDoc and TopField collector manager

2022-03-30 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514733#comment-17514733 ] Adrien Grand commented on LUCENE-10486: --- It would be nice if we could avoid this

[jira] [Commented] (LUCENE-10002) Remove IndexSearcher#search(Query,Collector) in favor of IndexSearcher#search(Query,CollectorManager)

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514731#comment-17514731 ] ASF subversion and git services commented on LUCENE-10002: -- Co

[jira] [Commented] (LUCENE-10002) Remove IndexSearcher#search(Query,Collector) in favor of IndexSearcher#search(Query,CollectorManager)

2022-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514730#comment-17514730 ] ASF subversion and git services commented on LUCENE-10002: -- Co

[GitHub] [lucene] jpountz merged pull request #766: LUCENE-10002: Add FixedBitSetCollector and corresponding collector manager to test framework

2022-03-30 Thread GitBox
jpountz merged pull request #766: URL: https://github.com/apache/lucene/pull/766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514662#comment-17514662 ] Tomoko Uchida commented on LUCENE-10485: At this time I won't proceed with this

[GitHub] [lucene] wjp719 closed pull request #774: LUCENE-10490: Query implement Cloneable interface

2022-03-30 Thread GitBox
wjp719 closed pull request #774: URL: https://github.com/apache/lucene/pull/774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Updated] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10485: --- Attachment: hacky-poc-make-kuromoji-test-named-module.patch > Limit o.a.l.a.morph package v

[jira] [Updated] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10485: --- Attachment: (was: hacky-poc-make-kuromoji-test-named-module.patch) > Limit o.a.l.a.morp

[jira] [Updated] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10485: --- Attachment: (was: hacky-poc-make-kuromoji-test-named-module-1.patch) > Limit o.a.l.a.mo

[jira] [Updated] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10485: --- Attachment: hacky-poc-make-kuromoji-test-named-module-1.patch > Limit o.a.l.a.morph package

[jira] [Commented] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514623#comment-17514623 ] Tomoko Uchida commented on LUCENE-10485: The patch shows that it's possible to

[GitHub] [lucene] wjp719 commented on pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-30 Thread GitBox
wjp719 commented on pull request #731: URL: https://github.com/apache/lucene/pull/731#issuecomment-1083012369 @jpountz I refactor the test cases, please help to review again, thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-30 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838428950 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -761,4 +763,90 @@ public void testEqualsAndHashCode()

[GitHub] [lucene] wjp719 commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-30 Thread GitBox
wjp719 commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838428748 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -761,4 +763,90 @@ public void testEqualsAndHashCode()

[jira] [Comment Edited] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514609#comment-17514609 ] Tomoko Uchida edited comment on LUCENE-10485 at 3/30/22, 11:10 AM: --

[jira] [Commented] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514609#comment-17514609 ] Tomoko Uchida commented on LUCENE-10485: I'm playing around modularizing kuromo

[jira] [Updated] (LUCENE-10485) Limit o.a.l.a.morph package visibility only to kuromoji and nori

2022-03-30 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida updated LUCENE-10485: --- Attachment: hacky-poc-make-kuromoji-test-named-module.patch > Limit o.a.l.a.morph package v

[GitHub] [lucene] jpountz commented on pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-30 Thread GitBox
jpountz commented on pull request #731: URL: https://github.com/apache/lucene/pull/731#issuecomment-1082881124 I just looked at the cloning logic, it looks good to me, thanks for making this change! -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene] jpountz commented on a change in pull request #731: LUCENE-10456: Implement Weight#count for MultiRangeQuery

2022-03-30 Thread GitBox
jpountz commented on a change in pull request #731: URL: https://github.com/apache/lucene/pull/731#discussion_r838348390 ## File path: lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestMultiRangeQueries.java ## @@ -761,4 +763,90 @@ public void testEqualsAndHashCode(

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838341280 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838341280 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[jira] [Commented] (LUCENE-10490) Query implement Cloneable interface

2022-03-30 Thread jianping weng (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514564#comment-17514564 ] jianping weng commented on LUCENE-10490: ok i close this  > Query implement Cl

[GitHub] [lucene] dweiss commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
dweiss commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838264080 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() { assertEqu

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838245085 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838240191 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {

[GitHub] [lucene] BaurzhanSakhariev commented on a change in pull request #770: Implement method to bulk add all collection elements to a PriorityQueue

2022-03-30 Thread GitBox
BaurzhanSakhariev commented on a change in pull request #770: URL: https://github.com/apache/lucene/pull/770#discussion_r838240191 ## File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java ## @@ -163,6 +164,57 @@ public void testInsertWithOverflow() {