[
https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10485.
Resolution: Won't Fix
I'm closing this (at this moment).
Instead of trying to hide the `
zacharymorn commented on a change in pull request #767:
URL: https://github.com/apache/lucene/pull/767#discussion_r840250256
##
File path:
lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##
@@ -31,42 +28,21 @@
/**
* A {@link Query} that matches
zacharymorn commented on a change in pull request #767:
URL: https://github.com/apache/lucene/pull/767#discussion_r840249824
##
File path:
lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##
@@ -31,42 +28,21 @@
/**
* A {@link Query} that matches
[
https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515701#comment-17515701
]
Tomoko Uchida edited comment on LUCENE-10485 at 4/1/22 5:22 AM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515701#comment-17515701
]
Tomoko Uchida commented on LUCENE-10485:
Note: Found some IDE issues with white
nknize commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r840219946
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestIndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -155,15 +156,23 @@ public voi
reta commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r840135696
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -250,6 +255,10 @@ private BoundedDo
reta commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r840135295
##
File path:
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestIndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -155,15 +156,23 @@ public void
jtibshirani commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r840121029
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -70,6 +72,9 @@
* fie
Yuti-G commented on pull request #779:
URL: https://github.com/apache/lucene/pull/779#issuecomment-1085135788
I ran the benchmark and no regression found, please see attached:
TaskQPS baseline StdDevQPS candidate
StdDev Pct diff p-
[
https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515594#comment-17515594
]
Yuting Gan edited comment on LUCENE-10488 at 3/31/22 9:18 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515594#comment-17515594
]
Yuting Gan edited comment on LUCENE-10488 at 3/31/22 9:18 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515594#comment-17515594
]
Yuting Gan commented on LUCENE-10488:
-
Hi [~gsmiller] ,
I have brought the optimiz
zhaih commented on a change in pull request #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r840006141
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyReader.java
##
@@ -78,10 +78,20 @@
private volatile Taxonom
Yuti-G opened a new pull request #779:
URL: https://github.com/apache/lucene/pull/779
# Description
This change overrides and optimizes the default implementation of getTopDims
in IntTaxonomyFacets which is extended by FastTaxonomyFacetCounts and
TaxonomyFacetSumIntAssociations.
[
https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515567#comment-17515567
]
Yixun Xu edited comment on LUCENE-10470 at 3/31/22 8:07 PM:
yixunx edited a comment on pull request #756:
URL: https://github.com/apache/lucene/pull/756#issuecomment-1085046782
Thank you for fixing this @iverase. However I just ran into the same
Tessellation error using this branch on a different polygon (repro
[here](https://github.com/iverase/luc
[
https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yixun Xu updated LUCENE-10470:
--
Attachment: image-2022-03-31-16-06-33-051.png
> Unable to Tessellate polygon
> --
[
https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515567#comment-17515567
]
Yixun Xu commented on LUCENE-10470:
---
As mentioned in Github comment I ran into anothe
[
https://issues.apache.org/jira/browse/LUCENE-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yixun Xu updated LUCENE-10470:
--
Attachment: polygon2.geojson
> Unable to Tessellate polygon
>
>
>
yixunx commented on pull request #756:
URL: https://github.com/apache/lucene/pull/756#issuecomment-1085046782
Thank you for fixing this @iverase. However I just ran into the same
Tessellation error using this branch on a different polygon (repro
[here](https://github.com/iverase/lucene/com
mcimadamore edited a comment on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084961727
> Thanks for your great explanation. Makes a lot of sense.
>
> Do you know if the `MAP_SHARED` flag is set for mapped memory segments? I
guess this means that eve
mcimadamore commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084961727
> Thanks for your great explanation. Makes a lot of sense.
>
> Do you know if the `MAP_SHARED` flag is set for mapped memory segments? I
guess this means that even if I'
reta commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r839872948
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##
@@ -318,6 +326,17 @@ private static Va
reta commented on pull request #749:
URL: https://github.com/apache/lucene/pull/749#issuecomment-1084917861
@jtibshirani thanks a lot for guiding me through, I believe all your
comments have been addressed, thanks again!
--
This is an automated message from the Apache Git Service.
To res
jtibshirani commented on a change in pull request #749:
URL: https://github.com/apache/lucene/pull/749#discussion_r839809386
##
File path:
lucene/core/src/java/org/apache/lucene/search/SortedNumericSortField.java
##
@@ -62,7 +62,9 @@ public SortedNumericSortField(String field,
JohannesLichtenberger commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084809944
Thanks for your great explanation. Makes a lot of sense.
Do you know if the `MAP_SHARED` flag is set for mapped memory segments? I
guess this means that even i
uschindler edited a comment on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084758218
Thanks @rmuir for the clirifaction.
To add, because also @mcimadamore asked: We use shared segments, because we
only allocate and map the segment once. It is then
uschindler edited a comment on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084758218
Thanks @rmuir for the clirifaction.
To add, because also @mcimadamore asked: We use shared segments, because we
only allocate and map the segment once. It is then
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084758218
Thanks @rmuir for the clirifaction.
To add, because also @mcimadamore asked: We use shared segments, because we
only allocate and map the segment once. It is then used by
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-10315:
--
Attachment: cpu_profile_path.html
cpu_profile_baseline.html
Status: Re
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515397#comment-17515397
]
Ignacio Vera commented on LUCENE-10315:
---
I have been looking into this issue and
JohannesLichtenberger commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084634009
Oh right, thanks. That's the big difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rmuir commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084630849
quoting from Uwe:
> All files are write-once so there are no updates to files which were
written before.
This is the key piece that I think you are missing. We write fi
JohannesLichtenberger edited a comment on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084586608
So, if the writer adds something to the lucene index (not via mmap) new
index readers will create a new `IndexInput` with new mapped memory segments
plus clon
JohannesLichtenberger commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084586608
So, if the writer adds something to the lucene index (not via mmap) new
index readers will create a new `IndexInput` with new mapped memory segments
plus clones with
uschindler edited a comment on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084563803
> I'm working on a similar approach for my data store, but I'm currently not
sure if it's a good idea for multiple readers plus a single reader/writer to
map a segment f
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084563803
> I'm working on a similar approach for my data store, but I'm currently not
sure if it's a good idea for multiple readers plus a single reader/writer to
map a segment for each
JohannesLichtenberger commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084507956
I'm working on a similar approach for my data store, but I'm currently not
sure if it's a good idea for multiple readers plus a single reader/writer to
map a segment
wjp719 commented on pull request #731:
URL: https://github.com/apache/lucene/pull/731#issuecomment-1084419272
@jpountz I have added the CHANGES log, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r839468461
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -314,6 +388,36 @@ public Scorer scorer(LeafReaderContext co
jpountz commented on pull request #731:
URL: https://github.com/apache/lucene/pull/731#issuecomment-1084332206
Can you also add a CHANGES entry under version 9.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
jpountz commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r839388337
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -314,6 +388,36 @@ public Scorer scorer(LeafReaderContext c
jpountz commented on a change in pull request #767:
URL: https://github.com/apache/lucene/pull/767#discussion_r839380353
##
File path:
lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##
@@ -31,42 +28,21 @@
/**
* A {@link Query} that matches docu
[
https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515173#comment-17515173
]
Dawid Weiss commented on LUCENE-10485:
--
I think they make a lot of sense and it'd
[
https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515155#comment-17515155
]
Tomoko Uchida commented on LUCENE-10485:
Thanks for the pointer.
In practice, m
[
https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515128#comment-17515128
]
Dawid Weiss commented on LUCENE-10485:
--
I already explored that back here:
https:
[
https://issues.apache.org/jira/browse/LUCENE-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515122#comment-17515122
]
Tomoko Uchida commented on LUCENE-10485:
If my understanding is correct, we nee
48 matches
Mail list logo
