jpountz commented on code in PR #790:
URL: https://github.com/apache/lucene/pull/790#discussion_r844759861
##
lucene/core/src/java/org/apache/lucene/search/UsageTrackingQueryCachingPolicy.java:
##
@@ -58,12 +58,6 @@ private static boolean shouldNeverCache(Query query) {
r
zacharymorn commented on PR #790:
URL: https://github.com/apache/lucene/pull/790#issuecomment-1091130105
> Great. We should backport these changes but the actual removals to 9.x to
address deprecation warnings.
Thanks for the review! I've created the backporting PR for 9.x here
https
zacharymorn opened a new pull request, #798:
URL: https://github.com/apache/lucene/pull/798
Backporting PR https://github.com/apache/lucene/pull/790 without removal of
the deprecated queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/LUCENE-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518601#comment-17518601
]
ASF subversion and git services commented on LUCENE-10436:
--
Co
zacharymorn merged PR #791:
URL: https://github.com/apache/lucene/pull/791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
zacharymorn commented on code in PR #790:
URL: https://github.com/apache/lucene/pull/790#discussion_r844733404
##
lucene/core/src/java/org/apache/lucene/search/UsageTrackingQueryCachingPolicy.java:
##
@@ -58,12 +58,6 @@ private static boolean shouldNeverCache(Query query) {
zacharymorn commented on PR #790:
URL: https://github.com/apache/lucene/pull/790#issuecomment-1091119984
> > For the change entry, I assume this should go into version 10.0.0?
>
> Yes, we need a CHANGES entry under 10.0.0 and a new entry in
`lucene/MIGRATE.txt` that recommends replaci
wjp719 commented on PR #786:
URL: https://github.com/apache/lucene/pull/786#issuecomment-1091011881
@msokolov @jpountz Thank you for your comments, I refactored method name as
`ArrayUtil#growNoCopy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
[
https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated LUCENE-10292:
Attachment: LUCENE-10292-2.patch
Status: Open (was: Open)
I refactored t
gautamworah96 commented on code in PR #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r844502429
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/AlwaysRefreshDirectoryTaxonomyReader.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Soft
zhaih commented on code in PR #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r844486980
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/AlwaysRefreshDirectoryTaxonomyReader.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Fou
mikemccand commented on code in PR #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r844479016
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/AlwaysRefreshDirectoryTaxonomyReader.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Softwar
[
https://issues.apache.org/jira/browse/LUCENE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518474#comment-17518474
]
ASF subversion and git services commented on LUCENE-10444:
--
Co
gsmiller merged PR #718:
URL: https://github.com/apache/lucene/pull/718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
msokolov commented on code in PR #796:
URL: https://github.com/apache/lucene/pull/796#discussion_r844451157
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -349,8 +353,9 @@ private void testSearch(Path indexPath, Path queryPath,
Path outputPath, i
msokolov commented on code in PR #796:
URL: https://github.com/apache/lucene/pull/796#discussion_r89176
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -362,18 +367,19 @@ private void testSearch(Path indexPath, Path queryPath,
Path outputPath,
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518473#comment-17518473
]
Feng Guo commented on LUCENE-10315:
---
Here is the benchmark result I got on my machine
gf2121 opened a new pull request, #797:
URL: https://github.com/apache/lucene/pull/797
https://issues.apache.org/jira/browse/LUCENE-10315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
jtibshirani commented on code in PR #796:
URL: https://github.com/apache/lucene/pull/796#discussion_r844431197
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -362,18 +367,19 @@ private void testSearch(Path indexPath, Path queryPath,
Path outputPa
jtibshirani merged PR #789:
URL: https://github.com/apache/lucene/pull/789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
msokolov commented on PR #786:
URL: https://github.com/apache/lucene/pull/786#issuecomment-1090789978
I don't much like the name either. I wouldn't block, but perhaps
`growWithoutCopying`? or `growNoCopy`? The whole idea that we are growing the
existing array is deceptive though because rea
msokolov opened a new pull request, #796:
URL: https://github.com/apache/lucene/pull/796
This really has two changes:
1. it switches the vector searches it runs to use the Query impl, as the
description says
2. it becomes a bit more clever about managing its cache of "exact" NN tha
Michael Sokolov created LUCENE-10504:
Summary: KnnGraphTester should use KnnVectorQuery
Key: LUCENE-10504
URL: https://issues.apache.org/jira/browse/LUCENE-10504
Project: Lucene - Core
Is
gsmiller commented on PR #718:
URL: https://github.com/apache/lucene/pull/718#issuecomment-1090586015
@mikemccand or @msokolov, did either of you have additional feedback? It
didn't really look like it beyond the pre-existing bug (which I've since
addressed), but I wanted to check before me
[
https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated LUCENE-10292:
Attachment: LUCENE-10292-1.patch
Status: Open (was: Open)
{quote}I origi
[
https://issues.apache.org/jira/browse/LUCENE-10495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuting Gan updated LUCENE-10495:
Description:
Found a bug in TaxonomyFacets when trying to use the siblingsLoaded function.
sibli
Yuti-G commented on code in PR #778:
URL: https://github.com/apache/lucene/pull/778#discussion_r844156099
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -109,7 +109,7 @@ public boolean childrenLoaded() {
* @lucene.experimental
*/
Yuti-G commented on code in PR #778:
URL: https://github.com/apache/lucene/pull/778#discussion_r844156099
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java:
##
@@ -109,7 +109,7 @@ public boolean childrenLoaded() {
* @lucene.experimental
*/
zhaih commented on code in PR #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r844154121
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software
zhaih commented on code in PR #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r844154121
##
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java:
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518272#comment-17518272
]
Feng Guo commented on LUCENE-10315:
---
Thanks [~ivera], [~jpountz] for all effort and s
[
https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518271#comment-17518271
]
Tomoko Uchida commented on LUCENE-10493:
I'm trying to factor out the core algo
wjp719 commented on PR #786:
URL: https://github.com/apache/lucene/pull/786#issuecomment-1090235148
@jpountz Hi, can you help to take some time to review this PR, thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
[
https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517988#comment-17517988
]
Tomoko Uchida edited comment on LUCENE-10493 at 4/6/22 11:42 AM:
mocobeta opened a new pull request, #795:
URL: https://github.com/apache/lucene/pull/795
`org.apache.lucene.analysis.[ja|ko].dict.TokenInfoFST` are exactly the same
except for the range of cached FST root arcs; we can safely unify the cache
logic and I need this for LUCENE-10493.
--
This
[
https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517988#comment-17517988
]
Tomoko Uchida commented on LUCENE-10493:
I'm starting this with small steps. I'
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517976#comment-17517976
]
ASF subversion and git services commented on LUCENE-10002:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517977#comment-17517977
]
ASF subversion and git services commented on LUCENE-10002:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517962#comment-17517962
]
ASF subversion and git services commented on LUCENE-10002:
--
Co
jpountz merged PR #787:
URL: https://github.com/apache/lucene/pull/787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517958#comment-17517958
]
ASF subversion and git services commented on LUCENE-10002:
--
Co
jpountz merged PR #785:
URL: https://github.com/apache/lucene/pull/785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
jpountz opened a new pull request, #794:
URL: https://github.com/apache/lucene/pull/794
See https://issues.apache.org/jira/browse/LUCENE-10503.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Adrien Grand created LUCENE-10503:
-
Summary: Preserve more significant bits of scores in WANDScorer
Key: LUCENE-10503
URL: https://issues.apache.org/jira/browse/LUCENE-10503
Project: Lucene - Core
mocobeta opened a new pull request, #793:
URL: https://github.com/apache/lucene/pull/793
`JapaneseTokenizer.Position` and `KoreanTokenizer.Position` are almost the
same except for `backWordPos` array, which only exists in KoreanTokenizer. To
factor out the viterbi algorighm, the two `Positi
javanna commented on PR #788:
URL: https://github.com/apache/lucene/pull/788#issuecomment-1089977302
oh well if I had to apologize for every bug I committed... happy to help!
Also good to see that using collector managers in tests helped uncover this.
--
This is an automated message from
LuXugang opened a new pull request, #792:
URL: https://github.com/apache/lucene/pull/792
Since at search phase, vector's all docs of all fields will be fully loaded
into memory, could we use IndexedDISI to store docIds and
DirectMonotonicWriter/Reader to handle ordToDoc mapping?
--
This
[
https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10502:
---
Description: Since at search phase, vector's all docs of all fields will be
fully loaded into memor
[
https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10502:
---
Description: Since at search phase, vector's all docs of all fields will be
fully loaded into memor
[
https://issues.apache.org/jira/browse/LUCENE-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10502:
---
Description: Since at search phase, vector's all docs of all fields will be
fully loaded into memor
Lu Xugang created LUCENE-10502:
--
Summary: Use IndexedDISI to store docIds and
DirectMonotonicWriter/Reader to handle ordToDoc
Key: LUCENE-10502
URL: https://issues.apache.org/jira/browse/LUCENE-10502
Pr
[
https://issues.apache.org/jira/browse/LUCENE-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10500.
---
Fix Version/s: 9.2
Resolution: Fixed
> StringValueFacetCounts relies on sequential c
[
https://issues.apache.org/jira/browse/LUCENE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10233:
--
Summary: Store docIds as bitset when doc IDs are strictly sorted and dense
(was: Store docId
53 matches
Mail list logo
