spike-liu commented on PR #663:
URL: https://github.com/apache/lucene/pull/663#issuecomment-1107703092
> This change looks good to me, except why did we need to resurrect
`DirectDocValuesFormat`? Was it an accident to include that in this PR maybe?
Thanks for you review, Michael. "Dir
boicehuang commented on PR #816:
URL: https://github.com/apache/lucene/pull/816#issuecomment-1107689248
> `./gradlew check` still fails. looks like the new test catches
interruptedexception and doesn't use the exception. in our codebase
compiler/linter will fail on this. please annotate the
[
https://issues.apache.org/jira/browse/LUCENE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526873#comment-17526873
]
Tomoko Uchida commented on LUCENE-10532:
Hi, I'm not familiar with the origins
xiaoshi2013 commented on PR #816:
URL: https://github.com/apache/lucene/pull/816#issuecomment-1107515602
Great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526849#comment-17526849
]
Tomoko Uchida commented on LUCENE-10528:
bq. I'm against marking a test slow wh
rmuir opened a new pull request, #832:
URL: https://github.com/apache/lucene/pull/832
This annotation is such an antipattern, it is so harmful to our codebase.
* gives the impression that "slow tests are ok"
* it is like "support for slow tests"
* allows certain privileged ppl to ski
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526846#comment-17526846
]
Robert Muir commented on LUCENE-10528:
--
I opened followup: LUCENE-10532
> TestScr
Robert Muir created LUCENE-10532:
Summary: Remove @Slow annotation
Key: LUCENE-10532
URL: https://issues.apache.org/jira/browse/LUCENE-10532
Project: Lucene - Core
Issue Type: Task
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526845#comment-17526845
]
ASF subversion and git services commented on LUCENE-10528:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10528.
--
Fix Version/s: 9.2
Resolution: Fixed
> TestScripts.testLukeCanBeLaunched creates X Win
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526844#comment-17526844
]
Robert Muir commented on LUCENE-10528:
--
I merged this PR so that i can cleanly -1
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526843#comment-17526843
]
ASF subversion and git services commented on LUCENE-10528:
--
Co
rmuir merged PR #828:
URL: https://github.com/apache/lucene/pull/828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.or
rmuir commented on PR #828:
URL: https://github.com/apache/lucene/pull/828#issuecomment-1107459835
I'm against making the test slow. i'm gonna merge this PR to separate this
from such craziness.
i just want the tests not messing around with my desktop.
--
This is an automated messa
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526842#comment-17526842
]
Robert Muir commented on LUCENE-10528:
--
I'm against marking a test slow when it is
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526842#comment-17526842
]
Robert Muir edited comment on LUCENE-10528 at 4/23/22 11:57 AM:
-
gf2121 opened a new pull request, #831:
URL: https://github.com/apache/lucene/pull/831
I'll merge if nightly benchmark works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
[
https://issues.apache.org/jira/browse/LUCENE-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526829#comment-17526829
]
ASF subversion and git services commented on LUCENE-10315:
--
Co
gf2121 merged PR #797:
URL: https://github.com/apache/lucene/pull/797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.o
LuXugang commented on code in PR #792:
URL: https://github.com/apache/lucene/pull/792#discussion_r856877670
##
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsWriter.java:
##
@@ -207,15 +210,41 @@ private void writeMeta(
// write docIDs
int co
LuXugang commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1107447562
vector source:
- 3 dimensions
- 667179 vectors within 1M documents in one segment
- do `KnnVectorQuery`
| NumberOfDocumentsToFind | baseline（search）ms | candidate（sear
[
https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10531:
---
Description:
We are going to allow running the test on Xvfb (a virtual display that speaks
[
https://issues.apache.org/jira/browse/LUCENE-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526799#comment-17526799
]
Tomoko Uchida commented on LUCENE-10528:
I opened [LUCENE-10531] to describe wh
[
https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526796#comment-17526796
]
Tomoko Uchida commented on LUCENE-10531:
I have little time for this right now,
[
https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10531:
---
Description:
We are going to allow running the test on Xvfb (a virtual display that speaks
Tomoko Uchida created LUCENE-10531:
--
Summary: Mark testLukeCanBeLaunched @Slow test and make a
dedicated Github CI workflow for it
Key: LUCENE-10531
URL: https://issues.apache.org/jira/browse/LUCENE-10531
26 matches
Mail list logo
