wjp719 opened a new pull request, #863:
URL: https://github.com/apache/lucene/pull/863
fix `TestBKD` case `testTooManyPoints1D` sort logic error and java doc error
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for
jianping weng created LUCENE-10554:
--
Summary: fix bkd test case logic error and java doc error
Key: LUCENE-10554
URL: https://issues.apache.org/jira/browse/LUCENE-10554
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531022#comment-17531022
]
ASF subversion and git services commented on LUCENE-10524:
--
Commit
mocobeta merged PR #853:
URL: https://github.com/apache/lucene/pull/853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wjp719 closed pull request #780: LUCENE-10496: avoid unnecessary attempts to
evaluate skipping doc if index sort and search sort are in opposite direction
URL: https://github.com/apache/lucene/pull/780
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17531015#comment-17531015
]
spike liu commented on LUCENE-10188:
It is my pleasure, Michael.
> Give SortedSetDocValues a
spike-liu commented on PR #663:
URL: https://github.com/apache/lucene/pull/663#issuecomment-1115571121
> Thanks @spike-liu -- I pushed this to `main` and will backport to 9.x
shortly.
It is my pleasure, Michael.
--
This is an automated message from the Apache Git Service.
To
risdenk commented on PR #2651:
URL: https://github.com/apache/lucene-solr/pull/2651#issuecomment-1115467396
I created https://github.com/apache/solr/pull/831 which updates this for
main. Adds integration test for configsets api and avoids the race condition.
--
This is an automated
risdenk commented on code in PR #2651:
URL: https://github.com/apache/lucene-solr/pull/2651#discussion_r863258880
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -2503,7 +2503,8 @@ public static int
persistConfigResourceToZooKeeper(ZkSolrResourceLoader
[
https://issues.apache.org/jira/browse/LUCENE-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang resolved LUCENE-10552.
Fix Version/s: 9.2
Resolution: Fixed
> KnnVectorQuery has incorrect equals/ hashCode
>
LuXugang commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1115431812
> We can merge this work into a temporary feature branch in the upstream
Hi @mayya-sharipova, could you create a temporary branch base on the latest
`main` branch and let me know,
msokolov commented on PR #859:
URL: https://github.com/apache/lucene/pull/859#issuecomment-1115412496
Oh, I changed the commit message to be positive about what the changes is,
rather than describing the problem, but did not update the CHANGES. I guess
it's minor
--
This is an
[
https://issues.apache.org/jira/browse/LUCENE-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530956#comment-17530956
]
ASF subversion and git services commented on LUCENE-10552:
--
Commit
msokolov merged PR #859:
URL: https://github.com/apache/lucene/pull/859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mayya-sharipova commented on PR #792:
URL: https://github.com/apache/lucene/pull/792#issuecomment-1115375748
> After renaming modified Lucene91HnswVectorsXXX to Lucene92HnswVectorsXXX ,
deleted TestBackwardsCompatibility could be reverted.
@LuXugang Thanks for explanation, this makes
mayya-sharipova commented on code in PR #792:
URL: https://github.com/apache/lucene/pull/792#discussion_r863191870
##
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java:
##
@@ -320,13 +323,19 @@ private static class FieldEntry {
final int
mayya-sharipova commented on code in PR #792:
URL: https://github.com/apache/lucene/pull/792#discussion_r863189510
##
lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java:
##
@@ -258,14 +257,18 @@ public TopDocs search(String field, float[]
[
https://issues.apache.org/jira/browse/LUCENE-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530905#comment-17530905
]
Greg Miller commented on LUCENE-10538:
--
We discussed this in the PR but I wanted to bring the
gautamworah96 commented on code in PR #853:
URL: https://github.com/apache/lucene/pull/853#discussion_r863079957
##
CONTRIBUTING.md:
##
@@ -66,6 +66,16 @@ In case your contribution fixes a bug, please create a new
test case that fails
- *Eclipse* - Basic support
msokolov commented on code in PR #859:
URL: https://github.com/apache/lucene/pull/859#discussion_r863048001
##
lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java:
##
@@ -56,7 +56,6 @@ public void testEquals() {
Query filter1 = new TermQuery(new
msokolov commented on code in PR #862:
URL: https://github.com/apache/lucene/pull/862#discussion_r863041170
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -21,32 +21,64 @@
/**
* NeighborArray encodes the neighbors of a node and their mutual
msokolov commented on PR #861:
URL: https://github.com/apache/lucene/pull/861#issuecomment-1115149720
I see, got it thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10534:
--
Fix Version/s: 9.2
> MinFloatFunction / MaxFloatFunction calls exists twice
>
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10534:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks [~hossman]
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530847#comment-17530847
]
ASF subversion and git services commented on LUCENE-10534:
--
Commit
risdenk merged PR #837:
URL: https://github.com/apache/lucene/pull/837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530844#comment-17530844
]
ASF subversion and git services commented on LUCENE-10534:
--
Commit
mikemccand commented on PR #861:
URL: https://github.com/apache/lucene/pull/861#issuecomment-1115117109
> I came here to find out what a PUAFIF is! TBH I'm not really sure why this
is better than the ISE it replaces?
Oh sorry -- see [the discussion on the previous
LuXugang commented on code in PR #859:
URL: https://github.com/apache/lucene/pull/859#discussion_r863001028
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -288,15 +288,20 @@ public void visit(QueryVisitor visitor) {
@Override
public boolean
[
https://issues.apache.org/jira/browse/LUCENE-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530816#comment-17530816
]
Julie Tibshirani commented on LUCENE-10552:
---
Great catch, thanks [~ChrisLu] ! Luckily I don't
[
https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530811#comment-17530811
]
Peixin Li commented on LUCENE-10551:
i'm using JDK 1.8.0_311
> LowercaseAsciiCompression should
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530810#comment-17530810
]
Chris M. Hostetter edited comment on LUCENE-10534 at 5/2/22 4:26 PM:
mayya-sharipova commented on PR #862:
URL: https://github.com/apache/lucene/pull/862#issuecomment-1115093505
I've run benchmarks on 2 datasets:
baseline – main branch
candidate – this PR:
Indexing time was the same or slightly better.
Recall slightly increased: 1-3%
QPS
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530810#comment-17530810
]
Chris M. Hostetter commented on LUCENE-10534:
-
1
> MinFloatFunction / MaxFloatFunction
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530809#comment-17530809
]
Kevin Risden commented on LUCENE-10534:
---
Thanks I just pushed changes to simplify the tests based
mayya-sharipova opened a new pull request, #862:
URL: https://github.com/apache/lucene/pull/862
Sort HNSW graph neighbors when applying diversity criterion
During HNSW graph construction, when a node has already a number of
connections larger than maximum allowed (maxConn), we need
msokolov commented on code in PR #859:
URL: https://github.com/apache/lucene/pull/859#discussion_r862982712
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -288,15 +288,20 @@ public void visit(QueryVisitor visitor) {
@Override
public boolean
[
https://issues.apache.org/jira/browse/LUCENE-10552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530801#comment-17530801
]
Michael Sokolov commented on LUCENE-10552:
--
Yes, I think so too. Nice catch - please feel free
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530797#comment-17530797
]
Chris M. Hostetter commented on LUCENE-10534:
-
I assume these test changes pass w/o your
msokolov commented on PR #861:
URL: https://github.com/apache/lucene/pull/861#issuecomment-1115037568
I came here to find out what a PUAFIF is! TBH I'm not really sure why this
is better than the IAE it replaces?
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-10188.
-
Fix Version/s: 10.0 (main)
9.2
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530769#comment-17530769
]
Michael McCandless commented on LUCENE-10188:
-
Thanks [~spike.liu] – I just pushed this and
[
https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530767#comment-17530767
]
ASF subversion and git services commented on LUCENE-10188:
--
Commit
[
https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530766#comment-17530766
]
ASF subversion and git services commented on LUCENE-10188:
--
Commit
mikemccand commented on PR #663:
URL: https://github.com/apache/lucene/pull/663#issuecomment-1114982009
Thanks @spike-liu -- I pushed this to `main` and will backport to 9.x
shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/LUCENE-10188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530761#comment-17530761
]
ASF subversion and git services commented on LUCENE-10188:
--
Commit
mikemccand merged PR #663:
URL: https://github.com/apache/lucene/pull/663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mikemccand commented on code in PR #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r862905078
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/MockRandomMergePolicy.java:
##
@@ -86,6 +86,20 @@ public MergeSpecification findMerges(
return
[
https://issues.apache.org/jira/browse/LUCENE-10545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10545.
Fix Version/s: 10.0 (main)
9.2
Resolution: Fixed
> Allow
mocobeta merged PR #854:
URL: https://github.com/apache/lucene/pull/854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mikemccand commented on code in PR #858:
URL: https://github.com/apache/lucene/pull/858#discussion_r862869056
##
lucene/core/src/java/org/apache/lucene/util/compress/LowercaseAsciiCompression.java:
##
@@ -111,14 +111,13 @@ public static boolean compress(byte[] in, int len,
mikemccand opened a new pull request, #861:
URL: https://github.com/apache/lucene/pull/861
Just a fast follow from https://github.com/apache/lucene/pull/858, switching
from `if` to `PUAFIF`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/LUCENE-10534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530743#comment-17530743
]
Kevin Risden commented on LUCENE-10534:
---
[~hossman] I added some edge case tests to
mikemccand commented on code in PR #858:
URL: https://github.com/apache/lucene/pull/858#discussion_r862855939
##
lucene/core/src/java/org/apache/lucene/util/compress/LowercaseAsciiCompression.java:
##
@@ -111,14 +111,13 @@ public static boolean compress(byte[] in, int len,
jpountz opened a new pull request, #860:
URL: https://github.com/apache/lucene/pull/860
The computation of the scaling factor has special cases for these two values,
but the current logic is backwards.
--
This is an automated message from the Apache Git Service.
To respond to the
jpountz commented on code in PR #858:
URL: https://github.com/apache/lucene/pull/858#discussion_r862850093
##
lucene/core/src/java/org/apache/lucene/util/compress/LowercaseAsciiCompression.java:
##
@@ -111,14 +111,13 @@ public static boolean compress(byte[] in, int len, byte[]
mikemccand commented on code in PR #858:
URL: https://github.com/apache/lucene/pull/858#discussion_r862846952
##
lucene/core/src/java/org/apache/lucene/util/compress/LowercaseAsciiCompression.java:
##
@@ -111,14 +111,13 @@ public static boolean compress(byte[] in, int len,
mikemccand commented on code in PR #858:
URL: https://github.com/apache/lucene/pull/858#discussion_r862846952
##
lucene/core/src/java/org/apache/lucene/util/compress/LowercaseAsciiCompression.java:
##
@@ -111,14 +111,13 @@ public static boolean compress(byte[] in, int len,
[
https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530738#comment-17530738
]
Michael McCandless commented on LUCENE-10551:
-
I committed some simple test improvements –
[
https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530736#comment-17530736
]
ASF subversion and git services commented on LUCENE-10551:
--
Commit
jpountz commented on code in PR #858:
URL: https://github.com/apache/lucene/pull/858#discussion_r862837603
##
lucene/core/src/java/org/apache/lucene/util/compress/LowercaseAsciiCompression.java:
##
@@ -111,14 +111,13 @@ public static boolean compress(byte[] in, int len, byte[]
Adrien Grand created LUCENE-10553:
-
Summary: WANDScorer's handling of 0 and +Infty is backwards
Key: LUCENE-10553
URL: https://issues.apache.org/jira/browse/LUCENE-10553
Project: Lucene - Core
mikemccand commented on PR #812:
URL: https://github.com/apache/lucene/pull/812#issuecomment-1114815361
Curiously, the [`dayOfYear` flat
facets](https://home.apache.org/~mikemccand/lucenebench/BrowseDayOfYearSSDVFacets.html)
performance seems to have already improved, though perhaps with
[
https://issues.apache.org/jira/browse/LUCENE-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530721#comment-17530721
]
ASF subversion and git services commented on LUCENE-10551:
--
Commit
mikemccand merged PR #858:
URL: https://github.com/apache/lucene/pull/858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/LUCENE-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530719#comment-17530719
]
Michael McCandless commented on LUCENE-10550:
-
+1
> Add getAllChildren functionality to
LuXugang opened a new pull request, #859:
URL: https://github.com/apache/lucene/pull/859
filter query could impact document-filtering properties, so maybe it should
be a condition in Query#equals and Query#hashCode ?
--
This is an automated message from the Apache Git Service.
To respond
Lu Xugang created LUCENE-10552:
--
Summary: KnnVectorQuery has incorrect equals/ hashCode
Key: LUCENE-10552
URL: https://issues.apache.org/jira/browse/LUCENE-10552
Project: Lucene - Core
Issue
68 matches
Mail list logo
