shaie commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r874371423
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/DoublePointFacetField.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mdmarshmallow commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r874247714
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/DoubleHyperRectangle.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537820#comment-17537820
]
Julie Tibshirani commented on LUCENE-10564:
---
That makes sense, I just backported to
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537819#comment-17537819
]
ASF subversion and git services commented on LUCENE-10564:
--
Commit
madrob commented on code in PR #2655:
URL: https://github.com/apache/lucene-solr/pull/2655#discussion_r874178663
##
solr/CHANGES.txt:
##
@@ -48,6 +48,8 @@ Bug Fixes
* SOLR-16075: ShowFileHandler path parameter is now validated to be relative
to instance conf dir in
jtibshirani commented on PR #833:
URL: https://github.com/apache/lucene/pull/833#issuecomment-1128143188
Thanks @zacharymorn, it's nice this made it to the 9.2 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r874090898
##
lucene/distribution.tests/build.gradle:
##
@@ -50,10 +50,15 @@ test {
jvmArgumentProviders.add(new CommandLineArgumentProvider() {
@Override
Iterable
dsmiley commented on code in PR #2655:
URL: https://github.com/apache/lucene-solr/pull/2655#discussion_r874086689
##
solr/CHANGES.txt:
##
@@ -48,6 +48,8 @@ Bug Fixes
* SOLR-16075: ShowFileHandler path parameter is now validated to be relative
to instance conf dir in
dweiss commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1128054906
The duke is awesome (as are the others on your site)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uschindler commented on PR #895:
URL: https://github.com/apache/lucene/pull/895#issuecomment-1128022492
Hi,
The lower limit should definitely stay at 1. I tend to agree to change the
upper limit, but the formula as is if correct.
As Robert said, that's a background thing. I tend to
rmuir commented on PR #895:
URL: https://github.com/apache/lucene/pull/895#issuecomment-1128016323
I don't think the formula should be changed personally. If you want to
increase the default limit of `4` to say `6` for some good reason, I'm not
entirely opposed to that, but the formula
risdenk commented on PR #895:
URL: https://github.com/apache/lucene/pull/895#issuecomment-1128011527
So just to clarify - today (and ever since spins = false either detected or
default) - the minimum has been 4 threads.
I'm not sure I understand "I'd just change the upper limit. But
madrob opened a new pull request, #2655:
URL: https://github.com/apache/lucene-solr/pull/2655
(cherry picked from commit 3ed851fc84015f092271ccf8f93c1d20737804ca)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rmuir commented on PR #895:
URL: https://github.com/apache/lucene/pull/895#issuecomment-1128002097
I agree with @uschindler . I only have 2 cores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1127993496
while waiting for review... here's `Randomizedtesting Luke`,
rough-and-tumble boy (based on the "Tumble Duke") - the latest addition to my
[fan-art
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned LUCENE-10576:
-
Assignee: Kevin Risden
> ConcurrentMergeScheduler maxThreadCount calculation is
risdenk commented on PR #895:
URL: https://github.com/apache/lucene/pull/895#issuecomment-1127982468
I'm not sure this is a great change since it could drastically increase the
number of max threads and therefore merges allowed - especially with some of
the high CPU core boxes. However,
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Status: Patch Available (was: Open)
> ConcurrentMergeScheduler maxThreadCount calculation
risdenk opened a new pull request, #895:
URL: https://github.com/apache/lucene/pull/895
# Description
ConcurrentMergeScheduler tries to calculate number of max threads. This is
artificially low and capped at 4 due to the logic in the calculation.
# Solution
This updates
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Priority: Minor (was: Major)
> ConcurrentMergeScheduler maxThreadCount calculation is
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
[
https://issues.apache.org/jira/browse/LUCENE-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated LUCENE-10576:
--
Description:
Kevin Risden created LUCENE-10576:
-
Summary: ConcurrentMergeScheduler maxThreadCount calculation is
artificially low
Key: LUCENE-10576
URL: https://issues.apache.org/jira/browse/LUCENE-10576
Project:
[
https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated LUCENE-10481:
---
Fix Version/s: 8.11.2
> FacetsCollector does not need scores when not keeping them
>
[
https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537689#comment-17537689
]
ASF subversion and git services commented on LUCENE-10481:
--
Commit
madrob merged PR #2654:
URL: https://github.com/apache/lucene-solr/pull/2654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873987904
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
[
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537670#comment-17537670
]
Adrien Grand commented on LUCENE-10544:
---
I don't think there is any issue with custom bulk
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873972923
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10564:
--
Fix Version/s: (was: 8.11)
> SparseFixedBitSet#or doesn't update memory accounting
>
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-10564:
--
Fix Version/s: 8.11
> SparseFixedBitSet#or doesn't update memory accounting
>
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537664#comment-17537664
]
Adrien Grand commented on LUCENE-10564:
---
[~julietibs] It looks like this bug affects 8.x too,
[
https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537663#comment-17537663
]
Adrien Grand commented on LUCENE-10477:
---
[~cpoerschke] Should we backport it to 8.11 now that a
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873963691
##
lucene/distribution.tests/build.gradle:
##
@@ -50,10 +50,15 @@ test {
jvmArgumentProviders.add(new CommandLineArgumentProvider() {
@Override
Iterable
msokolov commented on PR #870:
URL: https://github.com/apache/lucene/pull/870#issuecomment-1127885286
Thanks Mayya, I love the rapid iterations here. It's kind of funny to me
that we have moved to use IndexedDISI to track docids here since it
hearkens back to the first prototype I had
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1127809075
surprisingly, it worked on the first try... I'll open this and try to
address https://github.com/apache/lucene/pull/893#discussion_r873546269
--
This is an automated message from the
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1127771394
This worked on Windows VM - looks fairly slow (the whole workflow takes 7.5
minutes) as compared to Ubuntu (3 minutes) though.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537577#comment-17537577
]
Michael McCandless commented on LUCENE-10572:
-
OK I ran a simple {{luceneutil}} benchmark,
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-10572:
Attachment: Screen Shot 2022-05-16 at 10.28.22 AM.png
> Can we optimize
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873784334
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873784334
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
mayya-sharipova commented on PR #870:
URL: https://github.com/apache/lucene/pull/870#issuecomment-1127730405
@msokolov Sorry that we moved fast without letting you to study changes
properly; we were trying to catch up the upcoming 9.2 release.
About standalone
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873759662
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
[
https://issues.apache.org/jira/browse/LUCENE-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537544#comment-17537544
]
ASF subversion and git services commented on LUCENE-10575:
--
Commit
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873730908
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
[
https://issues.apache.org/jira/browse/LUCENE-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537538#comment-17537538
]
ASF subversion and git services commented on LUCENE-10575:
--
Commit
romseygeek commented on PR #894:
URL: https://github.com/apache/lucene/pull/894#issuecomment-1127672697
Thanks both!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
romseygeek merged PR #894:
URL: https://github.com/apache/lucene/pull/894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
romseygeek opened a new pull request, #894:
URL: https://github.com/apache/lucene/pull/894
* ExternalRefSorter.ByteSequenceIterator should be public, as it's designed
for external use
* MatchRegionRetriever refers to a private class in its public javadoc.
I've just removed the link for
Alan Woodward created LUCENE-10575:
--
Summary: Broken links in some javadocs
Key: LUCENE-10575
URL: https://issues.apache.org/jira/browse/LUCENE-10575
Project: Lucene - Core
Issue Type: Bug
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537477#comment-17537477
]
Uwe Schindler commented on LUCENE-10572:
BytesRefHash has this field already: {{int[]
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873580622
##
.github/workflows/distribution.yml:
##
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
Review
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873579845
##
.github/workflows/distribution.yml:
##
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ -
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873578148
##
.github/workflows/distribution.yml:
##
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ -
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873570217
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
[
https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537457#comment-17537457
]
Deepika Sharma commented on LUCENE-10544:
-
For unit test I am thinking that since in the
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873565003
##
.github/workflows/hunspell.yml:
##
@@ -28,9 +28,9 @@ jobs:
with:
path: |
~/.gradle/caches
-key: ${{ runner.os }}-gradle-solrj-${{
[
https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537453#comment-17537453
]
Robert Muir commented on LUCENE-10574:
--
Seems like this issue definitely isn't fixed as long as
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873556370
##
.github/workflows/distribution.yml:
##
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ -
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873553627
##
.github/workflows/distribution.yml:
##
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ -
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873546269
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873545503
##
.github/workflows/distribution.yml:
##
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
Review
[
https://issues.apache.org/jira/browse/LUCENE-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-10569.
--
Resolution: Won't Fix
I'm closing this as won't fix because it isn't enough to change a
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873544584
##
.github/workflows/distribution.yml:
##
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ -
dweiss commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873544355
##
.github/workflows/distribution.yml:
##
@@ -0,0 +1,42 @@
+name: Distribution nightly tests
+
+on:
+ pull_request:
+branches:
+ - 'main'
+paths:
+ -
mocobeta commented on PR #893:
URL: https://github.com/apache/lucene/pull/893#issuecomment-1127470140
The added workflow takes 3 minutes on ubuntu-latest, and it takes 5 minutes
on macos-latest.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-10574:
-
Description:
Remove {{floorSegmentBytes}} parameter, or change lucene's default to a merge
Robert Muir created LUCENE-10574:
Summary: Remove O(n^2) from TieredMergePolicy or change defaults
to one that doesn't do this
Key: LUCENE-10574
URL: https://issues.apache.org/jira/browse/LUCENE-10574
[
https://issues.apache.org/jira/browse/LUCENE-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537437#comment-17537437
]
Robert Muir commented on LUCENE-10573:
--
Fix TieredMergePolicy, don't hack around its shortcomings
rmuir commented on PR #892:
URL: https://github.com/apache/lucene/pull/892#issuecomment-1127459083
I'm strongly against the change. we need to fix the merge policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mocobeta commented on code in PR #893:
URL: https://github.com/apache/lucene/pull/893#discussion_r873520231
##
lucene/distribution.tests/src/test/org/apache/lucene/distribution/AbstractLuceneDistributionTest.java:
##
@@ -47,6 +52,19 @@ public abstract class
mocobeta opened a new pull request, #893:
URL: https://github.com/apache/lucene/pull/893
Mark `TestScripts` as `@Nightly` and add an Actions workflow for
distribution tests that runs all distribution tests including nightly tests.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537410#comment-17537410
]
Dawid Weiss commented on LUCENE-10572:
--
> Nevertheless, the main limiting factor of the
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537405#comment-17537405
]
Uwe Schindler edited comment on LUCENE-10572 at 5/16/22 8:56 AM:
-
Hi
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537405#comment-17537405
]
Uwe Schindler commented on LUCENE-10572:
Hi Dawid,
thats a nice issue. When looking at the
jpountz opened a new pull request, #892:
URL: https://github.com/apache/lucene/pull/892
With this change, if the first segment of the merge is too dirty, stored
fields
would still perform a bulk merge until the first dirty chunk. In the
degenerate
case when the first segment keeps
Adrien Grand created LUCENE-10573:
-
Summary: Improve stored fields bulk merge for degenerate O(n^2)
merges
Key: LUCENE-10573
URL: https://issues.apache.org/jira/browse/LUCENE-10573
Project: Lucene -
[
https://issues.apache.org/jira/browse/LUCENE-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-10541.
--
Fix Version/s: 9.2
Resolution: Fixed
> What to do about massive terms in our
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537354#comment-17537354
]
Dawid Weiss commented on LUCENE-10572:
--
This is the issue I filed it under, actually - note it's
[
https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537353#comment-17537353
]
Dawid Weiss commented on LUCENE-10572:
--
As much as I love BE (long live M68k), I think it's
shaie commented on code in PR #841:
URL: https://github.com/apache/lucene/pull/841#discussion_r873326117
##
lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/DoubleHyperRectangle.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
88 matches
Mail list logo
