[GitHub] [lucene] mocobeta commented on a diff in pull request #941: LUCENE-10578: check java minor/patch version when building

2022-06-01 Thread GitBox
mocobeta commented on code in PR #941: URL: https://github.com/apache/lucene/pull/941#discussion_r887623243 ## buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java: ## @@ -55,9 +64,18 @@ public static void main(String[] args) { } public static void chec

[GitHub] [lucene] dweiss commented on a diff in pull request #941: LUCENE-10578: check java minor/patch version when building

2022-06-01 Thread GitBox
dweiss commented on code in PR #941: URL: https://github.com/apache/lucene/pull/941#discussion_r887599889 ## buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java: ## @@ -39,6 +39,15 @@ * Has no dependencies outside of standard java libraries */ public clas

[jira] [Commented] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-01 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545286#comment-17545286 ] Vigya Sharma commented on LUCENE-10600: --- I'm curious why this is the case. Is it

[GitHub] [lucene] mocobeta opened a new pull request, #941: LUCENE-10578: check runtime java minor/patch version

2022-06-01 Thread GitBox
mocobeta opened a new pull request, #941: URL: https://github.com/apache/lucene/pull/941 ### Description (or a Jira issue link if you have one) https://issues.apache.org/jira/browse/LUCENE-10578 This pretty straight check works for me. Older major Java than 17. ``` ERRO

[GitHub] [lucene] jtibshirani commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-06-01 Thread GitBox
jtibshirani commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r887525645 ## lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java: ## @@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) { return new BitS

[jira] [Commented] (LUCENE-10578) Make minimum required Java version for build more specific

2022-06-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545246#comment-17545246 ] Tomoko Uchida commented on LUCENE-10578: https://docs.oracle.com/en/java/javase

[jira] [Comment Edited] (LUCENE-10578) Make minimum required Java version for build more specific

2022-06-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545237#comment-17545237 ] Tomoko Uchida edited comment on LUCENE-10578 at 6/2/22 2:53 AM: -

[jira] [Comment Edited] (LUCENE-10578) Make minimum required Java version for build more specific

2022-06-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545237#comment-17545237 ] Tomoko Uchida edited comment on LUCENE-10578 at 6/2/22 2:35 AM: -

[jira] [Commented] (LUCENE-10578) Make minimum required Java version for build more specific

2022-06-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545237#comment-17545237 ] Tomoko Uchida commented on LUCENE-10578: I picked some major distributions that

[jira] [Resolved] (LUCENE-10597) Move globalMaxScore to MaxScoreCache from ImpactsDISI?

2022-06-01 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10597. Fix Version/s: 10.0 (main) 9.3 Resolution: Fixed > Move globalM

[jira] [Commented] (LUCENE-10597) Move globalMaxScore to MaxScoreCache from ImpactsDISI?

2022-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545220#comment-17545220 ] ASF subversion and git services commented on LUCENE-10597: -- Co

[jira] [Commented] (LUCENE-10597) Move globalMaxScore to MaxScoreCache from ImpactsDISI?

2022-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545219#comment-17545219 ] ASF subversion and git services commented on LUCENE-10597: -- Co

[GitHub] [lucene] mocobeta merged pull request #931: LUCENE-10597: move globalMaxScore to MaxScoreCache

2022-06-01 Thread GitBox
mocobeta merged PR #931: URL: https://github.com/apache/lucene/pull/931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[GitHub] [lucene] pminkov opened a new pull request, #940: Use similarity.tf() in MoreLikeThis

2022-06-01 Thread GitBox
pminkov opened a new pull request, #940: URL: https://github.com/apache/lucene/pull/940 ### Description MoreLikeThis picks terms by their TF-IDF score. The TF part of the score was used by taking the term frequency directly, without applying a square root through ClassicSimilarity.tf

[GitHub] [lucene] pminkov closed pull request #939: Use similarity.tf() in MoreLikeThis

2022-06-01 Thread GitBox
pminkov closed pull request #939: Use similarity.tf() in MoreLikeThis URL: https://github.com/apache/lucene/pull/939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [lucene] pminkov opened a new pull request, #939: Use similarity.tf() in MoreLikeThis

2022-06-01 Thread GitBox
pminkov opened a new pull request, #939: URL: https://github.com/apache/lucene/pull/939 ### Description MoreLikeThis picks terms by their TF-IDF score. The TF part of the score was used by taking the term frequency directly, without applying a square root through ClassicSimilarity.tf

[jira] [Commented] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545080#comment-17545080 ] ASF subversion and git services commented on LUCENE-10598: -- Co

[GitHub] [lucene] mocobeta closed pull request #938: LUCENE-10558: Skip opening initial dialog in test

2022-06-01 Thread GitBox
mocobeta closed pull request #938: LUCENE-10558: Skip opening initial dialog in test URL: https://github.com/apache/lucene/pull/938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545052#comment-17545052 ] ASF subversion and git services commented on LUCENE-10598: -- Co

[GitHub] [lucene] LuXugang merged pull request #934: LUCENE-10598: SortedSetDocValues#docValueCount() should be always greater than zero

2022-06-01 Thread GitBox
LuXugang merged PR #934: URL: https://github.com/apache/lucene/pull/934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[GitHub] [lucene] mocobeta opened a new pull request, #938: LUCENE-10558: Skip opening initial dialog in test

2022-06-01 Thread GitBox
mocobeta opened a new pull request, #938: URL: https://github.com/apache/lucene/pull/938 ### Description (or a Jira issue link if you have one) Try to re-enable the gui test on windows. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-01 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544882#comment-17544882 ] Lu Xugang commented on LUCENE-10600: After [https://github.com/apache/lucene/pull/9

[jira] [Assigned] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-01 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Xugang reassigned LUCENE-10600: -- Assignee: Lu Xugang > SortedSetDocValues#docValueCount should be an int, not long >

[jira] [Commented] (LUCENE-10588) Make Luke launching code faster

2022-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544863#comment-17544863 ] ASF subversion and git services commented on LUCENE-10588: -- Co

[GitHub] [lucene] mocobeta commented on pull request #937: LUCENE-10588: log elapsed time for initializing gui

2022-06-01 Thread GitBox
mocobeta commented on PR #937: URL: https://github.com/apache/lucene/pull/937#issuecomment-1143515948 Improvements will come later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (LUCENE-10588) Make Luke launching code faster

2022-06-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544860#comment-17544860 ] ASF subversion and git services commented on LUCENE-10588: -- Co

[GitHub] [lucene] mocobeta merged pull request #937: LUCENE-10588: log elapsed time for initializing gui

2022-06-01 Thread GitBox
mocobeta merged PR #937: URL: https://github.com/apache/lucene/pull/937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[GitHub] [lucene] mocobeta opened a new pull request, #937: LUCENE-10588: log elapsed time for initializing gui

2022-06-01 Thread GitBox
mocobeta opened a new pull request, #937: URL: https://github.com/apache/lucene/pull/937 ### Description (or a Jira issue link if you have one) Just emit the elapsed time for initializing gui components for LUCENE-10588. It takes 2000 to 3000 msec on my Linux box. On windows, it

[GitHub] [lucene] mocobeta commented on pull request #931: LUCENE-10597: move globalMaxScore to MaxScoreCache

2022-06-01 Thread GitBox
mocobeta commented on PR #931: URL: https://github.com/apache/lucene/pull/931#issuecomment-1143401670 Thanks @jpountz for your review! I'll merge this in shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] mocobeta commented on a diff in pull request #931: LUCENE-10597: move globalMaxScore to MaxScoreCache

2022-06-01 Thread GitBox
mocobeta commented on code in PR #931: URL: https://github.com/apache/lucene/pull/931#discussion_r886621261 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreCache.java: ## @@ -78,8 +85,15 @@ int getLevel(int upTo) throws IOException { return -1; } + float getM

[jira] [Commented] (LUCENE-10563) Unable to Tessellate polygon

2022-06-01 Thread Craig Taverner (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544784#comment-17544784 ] Craig Taverner commented on LUCENE-10563: - I've created a PR with a fix for thi

[GitHub] [lucene] jpountz commented on a diff in pull request #931: LUCENE-10597: move globalMaxScore to MaxScoreCache

2022-06-01 Thread GitBox
jpountz commented on code in PR #931: URL: https://github.com/apache/lucene/pull/931#discussion_r886555453 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreCache.java: ## @@ -78,8 +85,15 @@ int getLevel(int upTo) throws IOException { return -1; } + float getMa

[GitHub] [lucene] mocobeta commented on a diff in pull request #931: LUCENE-10597: move globalMaxScore to MaxScoreCache

2022-06-01 Thread GitBox
mocobeta commented on code in PR #931: URL: https://github.com/apache/lucene/pull/931#discussion_r886554085 ## lucene/core/src/java/org/apache/lucene/search/MaxScoreCache.java: ## @@ -78,8 +85,15 @@ int getLevel(int upTo) throws IOException { return -1; } + float getM

[GitHub] [lucene] jpountz commented on a diff in pull request #892: LUCENE-10581: Optimize stored fields bulk merges on the first segment

2022-06-01 Thread GitBox
jpountz commented on code in PR #892: URL: https://github.com/apache/lucene/pull/892#discussion_r886550379 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java: ## @@ -553,14 +554,20 @@ private void copyChunks( fin

[jira] [Created] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-01 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10600: - Summary: SortedSetDocValues#docValueCount should be an int, not long Key: LUCENE-10600 URL: https://issues.apache.org/jira/browse/LUCENE-10600 Project: Lucene - Cor