[GitHub] [lucene] wormday opened a new pull request, #953: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation…

2022-06-09 Thread GitBox
wormday opened a new pull request, #953: URL: https://github.com/apache/lucene/pull/953 https://issues.apache.org/jira/browse/LUCENE-10605 ArrayUtil.oversize() The generated array length cannot eliminate the Object alignment gap, wasting some space -- This is an automated message

[jira] [Resolved] (LUCENE-10604) Improve ability to test and debug triangulation algorithm in Tessellator

2022-06-09 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignacio Vera resolved LUCENE-10604. --- Fix Version/s: 9.3 Assignee: Ignacio Vera Resolution: Fixed Thanks Craig!

[GitHub] [lucene] wormday closed pull request #952: LUCENE-10605: Fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
wormday closed pull request #952: LUCENE-10605: Fix error in 32bit jvm object alignment gap calculation URL: https://github.com/apache/lucene/pull/952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-10604) Improve ability to test and debug triangulation algorithm in Tessellator

2022-06-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552564#comment-17552564 ] ASF subversion and git services commented on LUCENE-10604: -- Commit

[GitHub] [lucene] iverase commented on pull request #946: LUCENE-10604: Add Tessellation monitor for easier debugging of triangulation algorithm

2022-06-09 Thread GitBox
iverase commented on PR #946: URL: https://github.com/apache/lucene/pull/946#issuecomment-1151965031 thank you @craigtaverner! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] wormday opened a new pull request, #952: LUCENE-10605: Fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
wormday opened a new pull request, #952: URL: https://github.com/apache/lucene/pull/952 ### Description https://issues.apache.org/jira/browse/LUCENE-10605 ArrayUtil.oversize() The generated array length cannot eliminate the Object alignment gap, wasting some space -- This is an

[jira] [Commented] (LUCENE-10604) Improve ability to test and debug triangulation algorithm in Tessellator

2022-06-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552562#comment-17552562 ] ASF subversion and git services commented on LUCENE-10604: -- Commit

[GitHub] [lucene] iverase merged pull request #946: LUCENE-10604: Add Tessellation monitor for easier debugging of triangulation algorithm

2022-06-09 Thread GitBox
iverase merged PR #946: URL: https://github.com/apache/lucene/pull/946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (LUCENE-10411) Add NN vectors support to ExitableDirectoryReader

2022-06-09 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach Chen resolved LUCENE-10411. Assignee: Zach Chen Resolution: Implemented > Add NN vectors support to

[jira] [Comment Edited] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-06-09 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552556#comment-17552556 ] Zach Chen edited comment on LUCENE-10480 at 6/10/22 5:15 AM: - Hi [~jpountz] 

[jira] [Commented] (LUCENE-10480) Specialize 2-clauses disjunctions

2022-06-09 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552556#comment-17552556 ] Zach Chen commented on LUCENE-10480: Hi [~jpountz] , this issue reminded me of our experiments last

[jira] [Comment Edited] (LUCENE-10603) Improve iteration of ords for SortedSetDocValues

2022-06-09 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552534#comment-17552534 ] Lu Xugang edited comment on LUCENE-10603 at 6/10/22 5:01 AM: - Hi,

[jira] [Commented] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-09 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552542#comment-17552542 ] Kaival Parikh commented on LUCENE-10606: Sure, Thank you! I have created a PR now > Optimize

[GitHub] [lucene] kaivalnp opened a new pull request, #951: LUCENE-10606: Optimize Prefilter Hit Collection

2022-06-09 Thread GitBox
kaivalnp opened a new pull request, #951: URL: https://github.com/apache/lucene/pull/951 ### Description Link to [Jira](https://issues.apache.org/jira/browse/LUCENE-10606) ### Solution Instead of collecting hit-by-hit using a `LeafCollector`, we break down the search by

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-09 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1151926798 > So unless I'm totally missing something, I think we should keep the `matches(byte[])` method. I don't think you're missing something, but perhaps to give a different POV, I am

[jira] [Commented] (LUCENE-10603) Improve iteration of ords for SortedSetDocValues

2022-06-09 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552534#comment-17552534 ] Lu Xugang commented on LUCENE-10603: Hi, [~gsmiller] , my initial thought was just wanna to keep

[jira] [Updated] (LUCENE-10607) NRTSuggesterBuilder扩展input时溢出

2022-06-09 Thread chaseny (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chaseny updated LUCENE-10607: - Component/s: core/FSTs (was: core/search) > NRTSuggesterBuilder扩展input时溢出 >

[jira] [Commented] (LUCENE-10607) NRTSuggesterBuilder扩展input时溢出

2022-06-09 Thread ChasenYang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552511#comment-17552511 ] ChasenYang commented on LUCENE-10607: - [~tangdh] 感谢, 我之后尝试一下英文提问(y) >

[GitHub] [lucene] zhaih commented on pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
zhaih commented on PR #949: URL: https://github.com/apache/lucene/pull/949#issuecomment-1151871592 Hmmm I think we'll only update Lucene8 if there's a bug need to be fixed, so not actively developed. Let's merge this change into `branch_9x` anyway, since in the CHANGES.txt we claim

[GitHub] [lucene] wormday commented on pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
wormday commented on PR #949: URL: https://github.com/apache/lucene/pull/949#issuecomment-1151850709 @zhaih Thank you very much. I see. But there seems to be no 32bit since JDK9. Lucene9 does not run under JDK8. If so, this change only makes sense for Lucene8. But does the

[jira] [Created] (LUCENE-10609) Phrase queries using SpanNearQuery highlight suspected bugs.

2022-06-09 Thread FengFeng Cheng (Jira)
FengFeng Cheng created LUCENE-10609: --- Summary: Phrase queries using SpanNearQuery highlight suspected bugs. Key: LUCENE-10609 URL: https://issues.apache.org/jira/browse/LUCENE-10609 Project: Lucene

[GitHub] [lucene] zhaih commented on pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
zhaih commented on PR #949: URL: https://github.com/apache/lucene/pull/949#issuecomment-1151829538 @wormday Ah basically just apply the same change to `branch_9x` and open a PR, because the main branch is actually next major version, so if the change is intended to be merged into lucene 9

[GitHub] [lucene] wormday commented on pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
wormday commented on PR #949: URL: https://github.com/apache/lucene/pull/949#issuecomment-1151802350 > backport PR @zhaih Sorry, I don't know how to operate it. Is there a tutorial? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [lucene] zhaih commented on a diff in pull request #950: LUCENE-10608: Implement Weight#count on pure conjunctions.

2022-06-09 Thread GitBox
zhaih commented on code in PR #950: URL: https://github.com/apache/lucene/pull/950#discussion_r894079898 ## lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java: ## @@ -344,6 +344,45 @@ public BulkScorer bulkScorer(LeafReaderContext context) throws IOException {

[GitHub] [lucene] zhaih commented on pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
zhaih commented on PR #949: URL: https://github.com/apache/lucene/pull/949#issuecomment-1151774470 Merged, thank you! Do you want to open a backport PR yourself? @wormday -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (LUCENE-10605) fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552491#comment-17552491 ] ASF subversion and git services commented on LUCENE-10605: -- Commit

[GitHub] [lucene] zhaih merged pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
zhaih merged PR #949: URL: https://github.com/apache/lucene/pull/949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] wormday commented on pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
wormday commented on PR #949: URL: https://github.com/apache/lucene/pull/949#issuecomment-1151716168 > Please add an entry in [CHANGES.txt](https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt) Thanks for reminding -- This is an automated message from the Apache Git

[GitHub] [lucene] gsmiller commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-09 Thread GitBox
gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1151548324 Regarding this "long matches API", I'm fairly confused. Why would we need this? I think I'm missing a chunk of previous conversation? But looking at this latest code, I can't imagine why

[jira] [Commented] (LUCENE-10602) Dynamic Index Cache Sizing

2022-06-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552394#comment-17552394 ] Robert Muir commented on LUCENE-10602: -- thanks for giving the context. I was confused whether

[jira] [Commented] (LUCENE-10603) Improve iteration of ords for SortedSetDocValues

2022-06-09 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552390#comment-17552390 ] Greg Miller commented on LUCENE-10603: -- Seems reasonable. Is there an expected benefit of moving

[GitHub] [lucene] gsmiller commented on pull request #922: Index only the docs for FacetField posting list

2022-06-09 Thread GitBox
gsmiller commented on PR #922: URL: https://github.com/apache/lucene/pull/922#issuecomment-1151492288 @gautamworah96 can you add a CHANGES entry please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene] gsmiller commented on a diff in pull request #922: Index only the docs for FacetField posting list

2022-06-09 Thread GitBox
gsmiller commented on code in PR #922: URL: https://github.com/apache/lucene/pull/922#discussion_r893860958 ## lucene/facet/src/java/org/apache/lucene/facet/FacetField.java: ## @@ -30,14 +30,12 @@ */ public class FacetField extends Field { - /** Field type used for

[GitHub] [lucene] gsmiller commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-09 Thread GitBox
gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1151477547 Thanks @shaie! I'll have a look at the code you pushed. Before doing so, I'm going to take the opportunity to respond to your and Marc's questions/comments above :) @mdmarshmallow:

[jira] [Commented] (LUCENE-10607) NRTSuggesterBuilder扩展input时溢出

2022-06-09 Thread tangdh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552361#comment-17552361 ] tangdh commented on LUCENE-10607: - 第一个问题,看上去描述的是一个事实?是问为什么速度慢吗?感觉可以用profiler看一下耗时。

[jira] [Commented] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-09 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552328#comment-17552328 ] Julie Tibshirani commented on LUCENE-10606: --- These results are great and the sample code

[jira] [Commented] (LUCENE-10603) Improve iteration of ords for SortedSetDocValues

2022-06-09 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552280#comment-17552280 ] Adrien Grand commented on LUCENE-10603: --- +1 I'd be curious to get thoughts from other people but

[jira] [Commented] (LUCENE-10602) Dynamic Index Cache Sizing

2022-06-09 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552279#comment-17552279 ] Adrien Grand commented on LUCENE-10602: --- We sure can build something custom in Elasticsearch, I

[jira] [Resolved] (LUCENE-10599) Improve LogMergePolicy's handling of maxMergeSize

2022-06-09 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10599. --- Fix Version/s: 9.3 Resolution: Fixed > Improve LogMergePolicy's handling of

[jira] [Commented] (LUCENE-10599) Improve LogMergePolicy's handling of maxMergeSize

2022-06-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552278#comment-17552278 ] ASF subversion and git services commented on LUCENE-10599: -- Commit

[jira] [Commented] (LUCENE-10599) Improve LogMergePolicy's handling of maxMergeSize

2022-06-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552275#comment-17552275 ] ASF subversion and git services commented on LUCENE-10599: -- Commit

[GitHub] [lucene] jpountz commented on pull request #935: LUCENE-10599: Improve LogMergePolicy's handling of maxMergeSize.

2022-06-09 Thread GitBox
jpountz commented on PR #935: URL: https://github.com/apache/lucene/pull/935#issuecomment-1151300171 Thanks @zhaih ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] jpountz merged pull request #935: LUCENE-10599: Improve LogMergePolicy's handling of maxMergeSize.

2022-06-09 Thread GitBox
jpountz merged PR #935: URL: https://github.com/apache/lucene/pull/935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] jpountz opened a new pull request, #950: LUCENE-10608: Implement Weight#count on pure conjunctions.

2022-06-09 Thread GitBox
jpountz opened a new pull request, #950: URL: https://github.com/apache/lucene/pull/950 https://issues.apache.org/jira/browse/LUCENE-10608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (LUCENE-10608) Implement Weight#count for pure conjunctions

2022-06-09 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10608: - Summary: Implement Weight#count for pure conjunctions Key: LUCENE-10608 URL: https://issues.apache.org/jira/browse/LUCENE-10608 Project: Lucene - Core

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-09 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1151141806 @gsmiller, @mdmarshmallow I pushed another commit with the following changes: 1. Assertion that all read facet sets have the same dimensionality (it's currently an `assert` to not

[GitHub] [lucene] alessandrobenedetti commented on pull request #926: VectorSimilarityFunction reverse removal

2022-06-09 Thread GitBox
alessandrobenedetti commented on PR #926: URL: https://github.com/apache/lucene/pull/926#issuecomment-1151131741 I had to pause this contribution to work with some clients and to prepare Berlin Buzzword, I'll resume it after the conference and hopefully merge it soon! -- This is an

[jira] [Commented] (LUCENE-10607) NRTSuggesterBuilder扩展input时溢出

2022-06-09 Thread ChasenYang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552189#comment-17552189 ] ChasenYang commented on LUCENE-10607: - 谢谢你的回答,我会尝试创建一个pull request,还有个其他的问题也请教一下? #

[jira] [Updated] (LUCENE-10607) NRTSuggesterBuilder扩展input时溢出

2022-06-09 Thread ChasenYang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChasenYang updated LUCENE-10607: Description: suggest模块在创建索引时,调用NRTSuggestBuilder的finishTerm来写入suggest索引。

[jira] [Updated] (LUCENE-10607) NRTSuggesterBuilder扩展input

2022-06-09 Thread ChasenYang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ChasenYang updated LUCENE-10607: Component/s: core/search (was: core/FSTs) > NRTSuggesterBuilder扩展input >

[GitHub] [lucene] kaivalnp commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-06-09 Thread GitBox
kaivalnp commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r893419386 ## lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java: ## @@ -730,4 +774,79 @@ protected int comparePivot(int j) { return

[jira] [Updated] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-09 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaival Parikh updated LUCENE-10606: --- Lucene Fields: (was: New) > Optimize hit collection of prefilter in KnnVectorQuery for

[jira] [Commented] (LUCENE-10607) NRTSuggesterBuilder扩展input

2022-06-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552125#comment-17552125 ] Dawid Weiss commented on LUCENE-10607: -- Could you provide a github pull request (or a patch),

[jira] [Commented] (LUCENE-10607) NRTSuggesterBuilder扩展input

2022-06-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17552124#comment-17552124 ] Dawid Weiss commented on LUCENE-10607: -- Thank you, ChasenYang (and Google translate...) I think

[jira] [Created] (LUCENE-10607) NRTSuggesterBuilder扩展input

2022-06-09 Thread ChasenYang (Jira)
ChasenYang created LUCENE-10607: --- Summary: NRTSuggesterBuilder扩展input Key: LUCENE-10607 URL: https://issues.apache.org/jira/browse/LUCENE-10607 Project: Lucene - Core Issue Type: Bug

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-09 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1150940692 > For the single point case (`ExactFSM`), this is crazy right? Even if there are a small number of provided `ExactFSM` instances we're matching against, doing a linear scan of all of them for

[GitHub] [lucene] wormday commented on a diff in pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
wormday commented on code in PR #949: URL: https://github.com/apache/lucene/pull/949#discussion_r893268734 ## lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java: ## @@ -191,15 +191,17 @@ public static int oversize(int minTargetSize, int bytesPerElement) {

[GitHub] [lucene] dweiss merged pull request #945: Try to fix the gradle compilation in idea

2022-06-09 Thread GitBox
dweiss merged PR #945: URL: https://github.com/apache/lucene/pull/945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene] wormday commented on a diff in pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
wormday commented on code in PR #949: URL: https://github.com/apache/lucene/pull/949#discussion_r893267816 ## lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java: ## @@ -191,15 +191,17 @@ public static int oversize(int minTargetSize, int bytesPerElement) {

[GitHub] [lucene] zhaih commented on a diff in pull request #949: LUCENE-10605: fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread GitBox
zhaih commented on code in PR #949: URL: https://github.com/apache/lucene/pull/949#discussion_r893146609 ## lucene/core/src/java/org/apache/lucene/util/ArrayUtil.java: ## @@ -191,15 +191,17 @@ public static int oversize(int minTargetSize, int bytesPerElement) {

[jira] [Commented] (LUCENE-10605) fix error in 32bit jvm object alignment gap calculation

2022-06-09 Thread Patrick Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551992#comment-17551992 ] Patrick Zhai commented on LUCENE-10605: --- I'm definitely not an expert on this but after some

[jira] [Comment Edited] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-09 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551976#comment-17551976 ] Kaival Parikh edited comment on LUCENE-10606 at 6/9/22 6:29 AM: Instead

[GitHub] [lucene] kaivalnp commented on a diff in pull request #932: LUCENE-10559: Add Prefilter Option to KnnGraphTester

2022-06-09 Thread GitBox
kaivalnp commented on code in PR #932: URL: https://github.com/apache/lucene/pull/932#discussion_r893116012 ## lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java: ## @@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) { return new

[jira] [Comment Edited] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-09 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551976#comment-17551976 ] Kaival Parikh edited comment on LUCENE-10606 at 6/9/22 6:21 AM: Instead

[jira] [Updated] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-09 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaival Parikh updated LUCENE-10606: --- Description: While working on this [PR|https://github.com/apache/lucene/pull/932] to add

[jira] [Commented] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-09 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551976#comment-17551976 ] Kaival Parikh commented on LUCENE-10606: Instead of collecting hit-by-hit using a