[GitHub] [lucene] gsmiller commented on a diff in pull request #1021: LUCENE-10603: Remove SSDV#NO_MORE_ORDS definition

2022-07-15 Thread GitBox
gsmiller commented on code in PR #1021: URL: https://github.com/apache/lucene/pull/1021#discussion_r922620035 ## lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java: ## @@ -391,11 +386,7 @@ public boolean advanceExact(int target) throws IOException {

[GitHub] [lucene-jira-archive] mocobeta closed issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub"

2022-07-15 Thread GitBox
mocobeta closed issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub" URL: https://github.com/apache/lucene-jira-archive/issues/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-jira-archive] mocobeta commented on issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub"

2022-07-15 Thread GitBox
mocobeta commented on issue #15: URL: https://github.com/apache/lucene-jira-archive/issues/15#issuecomment-1186068253 Merged #15 Note that this sends notifications to issues@ mail list (per POST API call). I think it's fine to let users know about the migration - an announcement for

[GitHub] [lucene-jira-archive] mocobeta merged pull request #47: Add a script to add 'moved to' comments to Jira issues

2022-07-15 Thread GitBox
mocobeta merged PR #47: URL: https://github.com/apache/lucene-jira-archive/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #47: Add a script to add 'moved to' comments to Jira issues

2022-07-15 Thread GitBox
mocobeta commented on PR #47: URL: https://github.com/apache/lucene-jira-archive/pull/47#issuecomment-1186062124 Looks to work fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (LUCENE-10557) Migrate to GitHub issue from Jira

2022-07-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567435#comment-17567435 ] Tomoko Uchida commented on LUCENE-10557: [TEST] This was moved to GitHub issue:

[jira] [Commented] (LUCENE-10622) Prepare complete migration script to GitHub issue from Jira (best effort)

2022-07-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567434#comment-17567434 ] Tomoko Uchida commented on LUCENE-10622: [TEST] This was moved to GitHub issue:

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #47: Add a script to add 'moved to' comments to Jira issues

2022-07-15 Thread GitBox
mocobeta opened a new pull request, #47: URL: https://github.com/apache/lucene-jira-archive/pull/47 With a [personal access token](https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html) (of a committer?), it is possible to add comments to ASF Jira issues.

[jira] [Commented] (LUCENE-10622) Prepare complete migration script to GitHub issue from Jira (best effort)

2022-07-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567432#comment-17567432 ] Tomoko Uchida commented on LUCENE-10622: [TEST] This was moved to GitHub issue:

[jira] [Commented] (LUCENE-10622) Prepare complete migration script to GitHub issue from Jira (best effort)

2022-07-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567431#comment-17567431 ] Tomoko Uchida commented on LUCENE-10622: [TEST] This was moved to GitHub issue:

[GitHub] [lucene-jira-archive] mikemccand commented on issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub"

2022-07-15 Thread GitBox
mikemccand commented on issue #15: URL: https://github.com/apache/lucene-jira-archive/issues/15#issuecomment-1186048071 It's possible this might still work even once we've made Jira "read-only" by disabling all workflows! Then we can take our time after the migration (and Jira becoming

[jira] [Commented] (LUCENE-10622) Prepare complete migration script to GitHub issue from Jira (best effort)

2022-07-15 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567429#comment-17567429 ] Tomoko Uchida commented on LUCENE-10622: This is a test comment from API. > Prepare complete

[GitHub] [lucene-jira-archive] mocobeta commented on issue #15: Make a script to add comments to all Jira issues to indicate that "this was moved to GitHub"

2022-07-15 Thread GitBox
mocobeta commented on issue #15: URL: https://github.com/apache/lucene-jira-archive/issues/15#issuecomment-1186041151 Adding a comment: examples https://developer.atlassian.com/server/jira/platform/jira-rest-api-examples/#adding-a-comment--examples -- This is an automated message

[GitHub] [lucene-jira-archive] mocobeta closed issue #26: Make a script to set colors and descriptions for labels

2022-07-15 Thread GitBox
mocobeta closed issue #26: Make a script to set colors and descriptions for labels URL: https://github.com/apache/lucene-jira-archive/issues/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene-jira-archive] mocobeta merged pull request #46: Add a script to update issue labels and descriptions

2022-07-15 Thread GitBox
mocobeta merged PR #46: URL: https://github.com/apache/lucene-jira-archive/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #46: Add a script to update issue labels and descriptions

2022-07-15 Thread GitBox
mocobeta opened a new pull request, #46: URL: https://github.com/apache/lucene-jira-archive/pull/46 Close #26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (LUCENE-10655) can we optimize visited bitset usage in HNSW graph search/indexing?

2022-07-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567366#comment-17567366 ] Michael Sokolov commented on LUCENE-10655: -- meh, I tried a few things, but nothing really

[GitHub] [lucene] rmuir commented on pull request #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-07-15 Thread GitBox
rmuir commented on PR #947: URL: https://github.com/apache/lucene/pull/947#issuecomment-1185833705 I think the title of the PR is wrong? We shouldn't be quantizing anything. The user should be supplying a `byte[]` vector for 8-bit vectors. Floats should not be involved. -- This is an

[jira] [Comment Edited] (LUCENE-10655) can we optimize visited bitset usage in HNSW graph search/indexing?

2022-07-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567358#comment-17567358 ] Michael Sokolov edited comment on LUCENE-10655 at 7/15/22 6:41 PM: ---

[jira] [Comment Edited] (LUCENE-10655) can we optimize visited bitset usage in HNSW graph search/indexing?

2022-07-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567358#comment-17567358 ] Michael Sokolov edited comment on LUCENE-10655 at 7/15/22 6:39 PM: ---

[jira] [Commented] (LUCENE-10655) can we optimize visited bitset usage in HNSW graph search/indexing?

2022-07-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567358#comment-17567358 ] Michael Sokolov commented on LUCENE-10655: -- OK I was confused, and in fact we already do use

[jira] [Commented] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field

2022-07-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567334#comment-17567334 ] Michael Sokolov commented on LUCENE-10633: -- Adrien that's crazy ! > Dynamic pruning for

[jira] [Commented] (LUCENE-10151) Add timeout support to IndexSearcher

2022-07-15 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567330#comment-17567330 ] Michael Sokolov commented on LUCENE-10151: -- > Did you forget to push to branch_9x? I cannot

[jira] [Commented] (LUCENE-10151) Add timeout support to IndexSearcher

2022-07-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567328#comment-17567328 ] ASF subversion and git services commented on LUCENE-10151: -- Commit

[jira] [Commented] (LUCENE-10151) Add timeout support to IndexSearcher

2022-07-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567329#comment-17567329 ] ASF subversion and git services commented on LUCENE-10151: -- Commit

[GitHub] [lucene] nknize commented on pull request #1017: LUCENE-10654: Add new ShapeDocValuesField for LatLonShape and XYShape

2022-07-15 Thread GitBox
nknize commented on PR #1017: URL: https://github.com/apache/lucene/pull/1017#issuecomment-1185733826 Hey @iverase; here's the PR related to the ShapeDocValuesField for the 9.3 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (LUCENE-10649) Failure in TestDemoParallelLeafReader.testRandomMultipleSchemaGensSameField

2022-07-15 Thread Vigya Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567317#comment-17567317 ] Vigya Sharma commented on LUCENE-10649: --- Created https://github.com/apache/lucene/pull/1025 >

[GitHub] [lucene] vigyasharma opened a new pull request, #1025: LUCENE-10649: Fix failures in TestDemoParallelLeafReader

2022-07-15 Thread GitBox
vigyasharma opened a new pull request, #1025: URL: https://github.com/apache/lucene/pull/1025 With merge-on-refresh enabled, the `ReindexingMergePolicy` in this test, needs to overide `findFullFlushMerges()`, to wrap the input reader, so that merged segment gets fields from the parallel

[jira] [Created] (LUCENE-10655) can we optimize visited bitset usage in HNSW graph search/indexing?

2022-07-15 Thread Michael Sokolov (Jira)
Michael Sokolov created LUCENE-10655: Summary: can we optimize visited bitset usage in HNSW graph search/indexing? Key: LUCENE-10655 URL: https://issues.apache.org/jira/browse/LUCENE-10655

[GitHub] [lucene] msokolov commented on pull request #947: LUCENE-10577: enable quantization of HNSW vectors to 8 bits

2022-07-15 Thread GitBox
msokolov commented on PR #947: URL: https://github.com/apache/lucene/pull/947#issuecomment-1185649145 I pushed an updated luceneutil PR adapting to these changes https://github.com/mikemccand/luceneutil/pull/181. Running that perf test I saw consistent gains (20-55% depending on the test

[GitHub] [lucene] mocobeta commented on pull request #1024: LUCENE-10557: Add GitHub issue templates

2022-07-15 Thread GitBox
mocobeta commented on PR #1024: URL: https://github.com/apache/lucene/pull/1024#issuecomment-1185631535 This is also a proposal for issue management. Feedback is welcome - I'm going to merge this in a week to proceed with the migration (if there are no comments). -- This is an automated

[GitHub] [lucene] mocobeta opened a new pull request, #1024: LUCENE-10557: Add GitHub issue templates

2022-07-15 Thread GitBox
mocobeta opened a new pull request, #1024: URL: https://github.com/apache/lucene/pull/1024 ### Description (or a Jira issue link if you have one) LUCENE-10557 This adds GitHub issue templates and a draft how-to manual for organizing issues with labels/templates. -- This is

[GitHub] [lucene] jpountz opened a new pull request, #1023: LUCENE-10633: Dynamic pruning for sorting on SORTED(_SET) fields.

2022-07-15 Thread GitBox
jpountz opened a new pull request, #1023: URL: https://github.com/apache/lucene/pull/1023 This commit enables dynamic pruning for queries sorted on SORTED(_SET) fields by using postings to filter competitive documents. JIRA:

[jira] [Commented] (LUCENE-10633) Dynamic pruning for queries sorted by SORTED(_SET) field

2022-07-15 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567268#comment-17567268 ] Adrien Grand commented on LUCENE-10633: --- I played with a prototype that starts dynamically

[GitHub] [lucene] jpountz commented on pull request #1007: Small tweak to PointRangeQuery#visit logic

2022-07-15 Thread GitBox
jpountz commented on PR #1007: URL: https://github.com/apache/lucene/pull/1007#issuecomment-1185610823 This looks right to me, hopefully @iverase can confirm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] jpountz commented on a diff in pull request #1018: LUCENE-10480: Use BulkScorer to limit BMMScorer to only top-level disjunctions

2022-07-15 Thread GitBox
jpountz commented on code in PR #1018: URL: https://github.com/apache/lucene/pull/1018#discussion_r97906 ## lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java: ## @@ -191,6 +191,69 @@ public long cost() { // or null if it is not applicable // pkg-private

[GitHub] [lucene-jira-archive] mocobeta commented on issue #6: Document issue label / template management policy

2022-07-15 Thread GitBox
mocobeta commented on issue #6: URL: https://github.com/apache/lucene-jira-archive/issues/6#issuecomment-1185547448 Issue templates proposal: - Bug Report - this is associated with `type:bug` label - Enhancement Request - this is associated with `type:enhancement` label - Test

[GitHub] [lucene-jira-archive] mocobeta closed issue #45: Bug

2022-07-15 Thread GitBox
mocobeta closed issue #45: Bug URL: https://github.com/apache/lucene-jira-archive/issues/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-jira-archive] mocobeta commented on issue #45: Bug

2022-07-15 Thread GitBox
mocobeta commented on issue #45: URL: https://github.com/apache/lucene-jira-archive/issues/45#issuecomment-1185540048 Ok, the label was set as expected. (looks like it has to be created beforehand). -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #45: Bug

2022-07-15 Thread GitBox
mocobeta opened a new issue, #45: URL: https://github.com/apache/lucene-jira-archive/issues/45 ### Description This is a test issue (take 2). ### Version and Environments _No response_ -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-jira-archive] mocobeta commented on issue #44: Bug

2022-07-15 Thread GitBox
mocobeta commented on issue #44: URL: https://github.com/apache/lucene-jira-archive/issues/44#issuecomment-1185537568 The issue label was not set... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-jira-archive] mocobeta closed issue #44: Bug

2022-07-15 Thread GitBox
mocobeta closed issue #44: Bug URL: https://github.com/apache/lucene-jira-archive/issues/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #44: Bug

2022-07-15 Thread GitBox
mocobeta opened a new issue, #44: URL: https://github.com/apache/lucene-jira-archive/issues/44 ### Description This is a test bug report. ### Version and Environments _No response_ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-jira-archive] mocobeta commented on issue #4: Which GitHub accont we should/can use for migration?

2022-07-15 Thread GitBox
mocobeta commented on issue #4: URL: https://github.com/apache/lucene-jira-archive/issues/4#issuecomment-1185506588 There have been no additional comments/requests. I decided to use my account for the second pass (updating step after importing) since I don't think we should bother infra

[GitHub] [lucene-jira-archive] mocobeta commented on issue #3: Create mapping on Jira user id -> GitHub account

2022-07-15 Thread GitBox
mocobeta commented on issue #3: URL: https://github.com/apache/lucene-jira-archive/issues/3#issuecomment-1185499857 Tasks to be done: - [ ] regenerate a candidate mapping (on July 24th) - [ ] manually make a "verified" mapping and commit it to `main` (on July 24th or 25th) - [

[GitHub] [lucene-jira-archive] mocobeta merged pull request #34: Add a tool to generate account mapping

2022-07-15 Thread GitBox
mocobeta merged PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #34: Add a tool to generate account mapping

2022-07-15 Thread GitBox
mocobeta commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1185491422 Here's the re-taken candidate and verified (with [the above criteria](https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1185313945)) mapping.

[jira] [Commented] (LUCENE-7713) Optimize TopFieldDocCollector for the sorted case

2022-07-15 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567202#comment-17567202 ] Lu Xugang commented on LUCENE-7713: --- Hi [~jpountz], it seems like there is no need to do comparison or

[GitHub] [lucene-jira-archive] mikemccand commented on pull request #34: Add a tool to generate account mapping

2022-07-15 Thread GitBox
mikemccand commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1185412128 Wow, the mapping file is massive! 5,793 developers. We've had so many contributors over the years ;) Inspiring. > I'd put priority on avoiding false positives.

[GitHub] [lucene-jira-archive] mocobeta commented on pull request #34: Add a tool to generate account mapping

2022-07-15 Thread GitBox
mocobeta commented on PR #34: URL: https://github.com/apache/lucene-jira-archive/pull/34#issuecomment-1185313945 For verification, I'll do 1. Check if the candidate github account has push access on apache/lucene repo. 2. Check if the candidate github account has been logged as

[GitHub] [lucene] LuXugang commented on a diff in pull request #767: LUCENE-10436: Deprecate DocValuesFieldExistsQuery, NormsFieldExistsQuery and KnnVectorFieldExistsQuery with FieldExistsQuery

2022-07-15 Thread GitBox
LuXugang commented on code in PR #767: URL: https://github.com/apache/lucene/pull/767#discussion_r845715708 ## lucene/core/src/java/org/apache/lucene/search/FieldExistsQuery.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene] LuXugang commented on a diff in pull request #1021: LUCENE-10603: Remove SSDV#NO_MORE_ORDS definition

2022-07-15 Thread GitBox
LuXugang commented on code in PR #1021: URL: https://github.com/apache/lucene/pull/1021#discussion_r921847372 ## lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java: ## @@ -391,11 +386,7 @@ public boolean advanceExact(int target) throws IOException {

[GitHub] [lucene] LuXugang commented on a diff in pull request #1021: LUCENE-10603: Remove SSDV#NO_MORE_ORDS definition

2022-07-15 Thread GitBox
LuXugang commented on code in PR #1021: URL: https://github.com/apache/lucene/pull/1021#discussion_r921847372 ## lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java: ## @@ -391,11 +386,7 @@ public boolean advanceExact(int target) throws IOException {