zacharymorn commented on PR #1018:
URL: https://github.com/apache/lucene/pull/1018#issuecomment-1188668774
> It appears this implementation would bring a -4% performance impact to
OrXNotY tasks in general.
I limited the implementation to pure disjunctions here
https://github.com/apac
zacharymorn commented on PR #1018:
URL: https://github.com/apache/lucene/pull/1018#issuecomment-1188612201
Here are the latest benchmark results:
`wikinightly`
```
TaskQPS baseline StdDevQPS
my_modified_version StdDevPct di
zacharymorn commented on code in PR #1018:
URL: https://github.com/apache/lucene/pull/1018#discussion_r924065392
##
lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java:
##
@@ -191,6 +191,66 @@ public long cost() {
// or null if it is not applicable
// pkg-priv
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568321#comment-17568321
]
ASF subversion and git services commented on LUCENE-10557:
--
Co
mocobeta merged PR #1036:
URL: https://github.com/apache/lucene/pull/1036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
mocobeta opened a new pull request, #1036:
URL: https://github.com/apache/lucene/pull/1036
Follow-up of #1024.
This refines issue label texts as suggested in
https://github.com/apache/lucene-jira-archive/issues/53
--
This is an automated message from the Apache Git Service.
To respond
mayya-sharipova commented on code in PR #947:
URL: https://github.com/apache/lucene/pull/947#discussion_r923807979
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java:
##
@@ -89,4 +123,67 @@ public abstract TopDocs search(
public KnnVectorsReader getMergeIn
mayya-sharipova commented on code in PR #947:
URL: https://github.com/apache/lucene/pull/947#discussion_r923800118
##
lucene/core/src/java/org/apache/lucene/util/VectorUtil.java:
##
@@ -213,4 +213,38 @@ public static void add(float[] u, float[] v) {
u[i] += v[i];
}
mayya-sharipova commented on code in PR #947:
URL: https://github.com/apache/lucene/pull/947#discussion_r923672692
##
lucene/core/src/java/org/apache/lucene/codecs/lucene93/Lucene93HnswVectorsReader.java:
##
@@ -169,7 +173,12 @@ private void validateFieldEntry(FieldInfo info, Fi
luyuncheng commented on code in PR #1034:
URL: https://github.com/apache/lucene/pull/1034#discussion_r923663218
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:
##
@@ -309,6 +309,30 @@ public byte[] toArrayCopy() {
return arr;
}
+ @Override
luyuncheng commented on code in PR #1034:
URL: https://github.com/apache/lucene/pull/1034#discussion_r923662970
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:
##
@@ -309,6 +309,24 @@ public byte[] toArrayCopy() {
return arr;
}
+ @Override
uschindler commented on code in PR #1034:
URL: https://github.com/apache/lucene/pull/1034#discussion_r923642311
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:
##
@@ -309,6 +309,30 @@ public byte[] toArrayCopy() {
return arr;
}
+ @Override
uschindler commented on code in PR #1034:
URL: https://github.com/apache/lucene/pull/1034#discussion_r923642311
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:
##
@@ -309,6 +309,30 @@ public byte[] toArrayCopy() {
return arr;
}
+ @Override
uschindler commented on code in PR #1034:
URL: https://github.com/apache/lucene/pull/1034#discussion_r923639294
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:
##
@@ -309,6 +309,24 @@ public byte[] toArrayCopy() {
return arr;
}
+ @Override
uschindler commented on code in PR #1034:
URL: https://github.com/apache/lucene/pull/1034#discussion_r923639294
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:
##
@@ -309,6 +309,24 @@ public byte[] toArrayCopy() {
return arr;
}
+ @Override
Yuti-G opened a new pull request, #1035:
URL: https://github.com/apache/lucene/pull/1035
### Description
In [LUCENE-10614](https://issues.apache.org/jira/browse/LUCENE-10614), we
modified the behavior of getTopChildren to actually return top-n ranges ordered
by count. The original b
luyuncheng commented on PR #1034:
URL: https://github.com/apache/lucene/pull/1034#issuecomment-1187753914
> This looks good to me, can you add a CHANGES entry that copyBytes now
saves one memory copy on ByteBuffersDataOutput?
Thanks for your review and suggestions, I have been updated
[
https://issues.apache.org/jira/browse/LUCENE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568116#comment-17568116
]
Adrien Grand commented on LUCENE-10651:
---
I'm not familiar with the simple query p
[
https://issues.apache.org/jira/browse/LUCENE-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LuYunCheng updated LUCENE-10657:
Summary: CopyBytes now saves one memory copy on ByteBuffersDataOutput
(was: Reduce memory copy i
[
https://issues.apache.org/jira/browse/LUCENE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568114#comment-17568114
]
Adrien Grand commented on LUCENE-10651:
---
bq. But I like your fix – it prevents a
[
https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568109#comment-17568109
]
Adrien Grand commented on LUCENE-10633:
---
I opened https://github.com/mikemccand/l
luyuncheng commented on PR #1034:
URL: https://github.com/apache/lucene/pull/1034#issuecomment-1187675144
> The logic makes sense to me, can you add unit tests?
Thanks for your review, in commits
[926dd](https://github.com/luyuncheng/lucene/commit/926dd0c159c314430a6ace3ec55e50f7ee155
luyuncheng commented on code in PR #1034:
URL: https://github.com/apache/lucene/pull/1034#discussion_r923536318
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:
##
@@ -309,6 +309,24 @@ public byte[] toArrayCopy() {
return arr;
}
+ @Override
nknize commented on PR #1017:
URL: https://github.com/apache/lucene/pull/1017#issuecomment-1187657941
> Early versions of XYShape where using encoded rectangles to perform
bounding box queries. That proved to be wrong
That has to do with the query not the field. This does not affect t
[
https://issues.apache.org/jira/browse/LUCENE-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17568068#comment-17568068
]
Michael McCandless commented on LUCENE-10651:
-
It's a bit depressing that {
hcqs33 commented on PR #1028:
URL: https://github.com/apache/lucene/pull/1028#issuecomment-1187639318
> This looks good to me, can you add a CHANGES entry under version `9.3` so
that users know about this bug fix?
Sure. I have added a CHANGES entry for this PR.
--
This is an automa
mocobeta opened a new pull request, #55:
URL: https://github.com/apache/lucene-jira-archive/pull/55
This refines label texts as suggested in #53.
1. Rename `component:module/xyz` to `module:xyz`
2. Rename `fixVersion:x.x.x` to `fix-version:x.x.x`
3. Rename `affectsVersion:x.x.x`
iverase commented on PR #1017:
URL: https://github.com/apache/lucene/pull/1017#issuecomment-1187570816
Hey @nknize!
I went through the PR and my feeling is that it is still half-cooked and I
worry about adding a new encoding into core that it is not properly worked on.
If later we ne
jpountz merged PR #1019:
URL: https://github.com/apache/lucene/pull/1019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
jpountz commented on code in PR #1022:
URL: https://github.com/apache/lucene/pull/1022#discussion_r923424214
##
lucene/core/src/test/org/apache/lucene/search/TestDisiPriorityQueue.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
jpountz commented on code in PR #1034:
URL: https://github.com/apache/lucene/pull/1034#discussion_r923411342
##
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java:
##
@@ -309,6 +309,24 @@ public byte[] toArrayCopy() {
return arr;
}
+ @Override
+
mikemccand commented on issue #53:
URL:
https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1187491522
> I agree that it looks redundant, perhaps it would be better to change the
common label prefix from `component` to `module` like `module:core/index`,
`module:analysis`,
mocobeta commented on issue #53:
URL:
https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1187483046
> Also, could we maybe use `fix-version` and `affects-version` instead of
`fixVersion` and `affectsVersion`? I think it is more readable on quick glance
with a `-`?
>
mocobeta commented on issue #53:
URL:
https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1187457057
> Could we remove the `module/` prefix for `core`? It would make the core
component strings shorter, which is meaningful/helpful since they are so
frequently used?
W
mayya-sharipova commented on PR #992:
URL: https://github.com/apache/lucene/pull/992#issuecomment-1187314554
@jpountz I am wondering if you have further comments for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/LUCENE-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567972#comment-17567972
]
ASF subversion and git services commented on LUCENE-10649:
--
Co
mocobeta merged PR #52:
URL: https://github.com/apache/lucene-jira-archive/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lu
[
https://issues.apache.org/jira/browse/LUCENE-10649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567968#comment-17567968
]
ASF subversion and git services commented on LUCENE-10649:
--
Co
jpountz merged PR #1025:
URL: https://github.com/apache/lucene/pull/1025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
luyuncheng commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r923284236
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java:
##
@@ -519,7 +518,13 @@ private void
copyOneDoc(Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
LuYunCheng updated LUCENE-10657:
Description:
This is derived from [LUCENE-10627|[https://github.com/apache/lucene/pull/987]]
Cod
luyuncheng opened a new pull request, #1034:
URL: https://github.com/apache/lucene/pull/1034
This is derived from
[LUCENE-10627](https://issues.apache.org/jira/browse/LUCENE-10627) at #987
Jira: https://issues.apache.org/jira/browse/LUCENE-10657
The abstract method `copyBytes` in
LuYunCheng created LUCENE-10657:
---
Summary: Reduce memory copy in DataOutput copyBytes
Key: LUCENE-10657
URL: https://issues.apache.org/jira/browse/LUCENE-10657
Project: Lucene - Core
Issue Type
mikemccand opened a new issue, #54:
URL: https://github.com/apache/lucene-jira-archive/issues/54
### Description
I found this example comment, where commitbot had embedded a hyperlink, and
in Jira it is a hyperlink, but in the imported GitHub issue (in my test repo),
it is just plain
mikemccand commented on issue #53:
URL:
https://github.com/apache/lucene-jira-archive/issues/53#issuecomment-1187165708
Also, could we maybe use `fix-version` and `affects-version` instead of
`fixVersion` and `affectsVersion`? I think it is more readable on quick glance
with a `-`?
mikemccand opened a new issue, #53:
URL: https://github.com/apache/lucene-jira-archive/issues/53
### Description
I noticed we have components like `component:module/core/hnsw`.
Could we remove the `module/` prefix for `core`? It would make the core
component strings shorter, w
[
https://issues.apache.org/jira/browse/LUCENE-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567913#comment-17567913
]
Michael McCandless commented on LUCENE-10633:
-
{quote}I plan on opening a P
mikemccand closed issue #37: Why are some Jira issues completely missing?
URL: https://github.com/apache/lucene-jira-archive/issues/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
mikemccand commented on issue #37:
URL:
https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1187016028
Whoa! I found two of the issues! Check it out:
https://markmail.org/message/ntz5hxrm4lli57oe and
https://markmail.org/message/d5t346iwopaqj45x
Apparently it is p
mikemccand commented on issue #37:
URL:
https://github.com/apache/lucene-jira-archive/issues/37#issuecomment-1187013700
> Some issues were probably moved to SOLR issues?
Oooh I love that theory!
But then, wouldn't they have left some digital breadcrumbs? Initial email
sent to
luyuncheng commented on PR #987:
URL: https://github.com/apache/lucene/pull/987#issuecomment-1186947659
> Thanks for the iteration, the high-level idea looks good to me, I left
some suggestions.
@jpountz Thanks for your nice suggestions. at latest commits
[ebcbdd](https://github.com/
luyuncheng commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r923100057
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/DeflateWithPresetDictCompressionMode.java:
##
@@ -163,12 +165,16 @@ private static class DeflateWithPresetDictC
luyuncheng commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r923100057
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/DeflateWithPresetDictCompressionMode.java:
##
@@ -163,12 +165,16 @@ private static class DeflateWithPresetDictC
[
https://issues.apache.org/jira/browse/LUCENE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10493.
Fix Version/s: 10.0 (main)
Assignee: Tomoko Uchida
Resolution: Fixed
> Ca
[
https://issues.apache.org/jira/browse/LUCENE-10497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10497.
Fix Version/s: 10.0 (main)
Assignee: Tomoko Uchida
Resolution: Fixed
> Un
jpountz commented on code in PR #1018:
URL: https://github.com/apache/lucene/pull/1018#discussion_r923041831
##
lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java:
##
@@ -191,6 +191,66 @@ public long cost() {
// or null if it is not applicable
// pkg-private
56 matches
Mail list logo
