jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1061991840
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -143,10 +148,64 @@ public OnHeapHnswGraph build(RandomAccessVectorValues
vectorsTo
zhaih commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1061976538
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -143,10 +148,64 @@ public OnHeapHnswGraph build(RandomAccessVectorValues
vectorsToAdd)
zhaih commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1061955216
##
lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java:
##
@@ -94,36 +93,83 @@ public int size() {
}
/**
- * Add node on the given level
+
jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1061916872
##
lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java:
##
@@ -94,36 +93,83 @@ public int size() {
}
/**
- * Add node on the given level
jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1061905607
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -143,10 +148,64 @@ public OnHeapHnswGraph build(RandomAccessVectorValues
vectorsTo
jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1061902971
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java:
##
@@ -461,6 +467,126 @@ public void mergeOneField(FieldInfo fieldInfo, Me
jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1061902422
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java:
##
@@ -461,6 +467,126 @@ public void mergeOneField(FieldInfo fieldInfo, Me
jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1061902120
##
lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java:
##
@@ -461,6 +467,126 @@ public void mergeOneField(FieldInfo fieldInfo, Me
benwtrent commented on PR #12064:
URL: https://github.com/apache/lucene/pull/12064#issuecomment-1371336800
@jpountz
> One thing I'd like to see is whether we can avoid making
AbstractVectorValues public and duplicate logic for byte and float vector
values in e.g. VectorScorer and Ch
uschindler merged PR #12066:
URL: https://github.com/apache/lucene/pull/12066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
jpountz commented on code in PR #12064:
URL: https://github.com/apache/lucene/pull/12064#discussion_r1061739690
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene94/Lucene94HnswVectorsReader.java:
##
@@ -233,12 +234,19 @@ public void checkIntegrity() thr
vstrout opened a new issue, #12067:
URL: https://github.com/apache/lucene/issues/12067
### Description
After upgrading from Lucene 9.3.0 to Lucene 9.4.2 the index search with
sorting by description throws the following exception:
Caused by: java.lang.IllegalStateException: Term
jpountz commented on PR #12053:
URL: https://github.com/apache/lucene/pull/12053#issuecomment-1371197803
I pushed a new commit that also disallows term vector offsets on binary
fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jpountz commented on PR #12054:
URL: https://github.com/apache/lucene/pull/12054#issuecomment-1371192608
Thanks for looking @gsmiller. The test that fails is because this PR relies
on behavior introduced by https://github.com/apache/lucene/pull/12053. I'll
rebase when this other PR is merge
ErikPelli commented on code in PR #12034:
URL: https://github.com/apache/lucene/pull/12034#discussion_r1061673383
##
lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java:
##
@@ -314,19 +314,15 @@ private static TermStates adjustFrequencies(
IndexReaderConte
ErikPelli commented on code in PR #12034:
URL: https://github.com/apache/lucene/pull/12034#discussion_r1061649853
##
lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java:
##
@@ -314,19 +314,15 @@ private static TermStates adjustFrequencies(
IndexReaderConte
uschindler commented on PR #12066:
URL: https://github.com/apache/lucene/pull/12066#issuecomment-1370980047
I cleaned up the code more:
- removed the useless doPrivileged block around the actual unmapping. We
just call a MethodHandle and the Java 9+ version has no security checks.
- pu
17 matches
Mail list logo
