Re: [PR] Add Facets#getBulkSpecificValues method [lucene]

2024-01-08 Thread via GitHub
epotyom commented on PR #12862: URL: https://github.com/apache/lucene/pull/12862#issuecomment-1882551314 @mikemccand oh I just realised that replying to code line comment doesn't send a notification! Thank you for reviewing, I listed some alternatives above, but I still think that

Re: [PR] Split taxonomy arrays across chunks [lucene]

2024-01-08 Thread via GitHub
msfroh commented on PR #12995: URL: https://github.com/apache/lucene/pull/12995#issuecomment-1882537143 > As far as testing, can we add some unit tests that allocate more than one chunk and exercise the new functionality? Should we also run some benchmarks to understand if there's any sort

Re: [PR] Copy collected acc(maxFreqs) into empty acc, rather than merge them. [lucene]

2024-01-08 Thread via GitHub
vsop-479 commented on code in PR #12846: URL: https://github.com/apache/lucene/pull/12846#discussion_r1445677720 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99SkipWriter.java: ## @@ -202,7 +202,11 @@ protected void writeSkipData(int level, DataOutput

Re: [PR] Avoid reset BlockDocsEnum#freqBuffer when indexHasFreq is false [lucene]

2024-01-08 Thread via GitHub
easyice commented on PR #12997: URL: https://github.com/apache/lucene/pull/12997#issuecomment-1882374457 > another approach could consist of filling at most docFreq entries in the freq buffer It's a nice idea! > I didn't know we had such leniency around

Re: [PR] LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-1882027747 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-9634: Fix highlighting of extended intervals matched using offset [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #16: URL: https://github.com/apache/lucene/pull/16#issuecomment-1882027687 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-9798 : Fix looping bug when calculating full KNN results in KnnGraphTester [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #83: URL: https://github.com/apache/lucene/pull/83#issuecomment-1882027628 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] Expunge big segment with oversize deletePct caused by continuously updating a batch of data [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #92: URL: https://github.com/apache/lucene/pull/92#issuecomment-1882027550 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-9869 allow for configuring a custom cache purge scheduler in Monitor (aka Luwak) [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #99: URL: https://github.com/apache/lucene/pull/99#issuecomment-1882027460 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #101: URL: https://github.com/apache/lucene/pull/101#issuecomment-1882027391 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-9335: [Discussion Only] Implement BMM with BulkScorer interface [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #113: URL: https://github.com/apache/lucene/pull/113#issuecomment-1882027328 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] Update spanish_stop.txt [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #117: URL: https://github.com/apache/lucene/pull/117#issuecomment-1882027252 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10073: Reduce merging overhead of NRT by using a greater mergeFactor on tiny segments. [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #266: URL: https://github.com/apache/lucene/pull/266#issuecomment-1882027143 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10059: Additional fix to handle n_best backtrace [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #284: URL: https://github.com/apache/lucene/pull/284#issuecomment-1882027059 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10086: Fix an AssertionError when KoreanTokenizer tries to backtrace from and to the same position [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #285: URL: https://github.com/apache/lucene/pull/285#issuecomment-1882026999 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10099: Add -Ptests.asyncprofile option. [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #295: URL: https://github.com/apache/lucene/pull/295#issuecomment-1882026931 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] SOLR-15665: Move polling logic under main [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #328: URL: https://github.com/apache/lucene/pull/328#issuecomment-1882026857 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10133: Specialize the write path for sorted doc values. [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #330: URL: https://github.com/apache/lucene/pull/330#issuecomment-1882026779 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10202: spatial: feature-variants [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #411: URL: https://github.com/apache/lucene/pull/411#issuecomment-1882026665 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10195: Improve Gradle build speed [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #414: URL: https://github.com/apache/lucene/pull/414#issuecomment-1882026595 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-1882026525 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10230 make demo builds easier to execute [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #433: URL: https://github.com/apache/lucene/pull/433#issuecomment-1882026451 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-8739: custom codec providing Zstandard compression/decompression [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #439: URL: https://github.com/apache/lucene/pull/439#issuecomment-1882026368 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10247 - reduce size of FSTs by relative coding [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #460: URL: https://github.com/apache/lucene/pull/460#issuecomment-1882026303 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10157 - Added IndriOr, IndriWeightedSum, and IndriQueryParser [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #463: URL: https://github.com/apache/lucene/pull/463#issuecomment-1882026237 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10251: Add the compliant "Direct" doc-value format [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #464: URL: https://github.com/apache/lucene/pull/464#issuecomment-1882026172 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10254: Remove Scorable#smoothingScore. [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #469: URL: https://github.com/apache/lucene/pull/469#issuecomment-1882026092 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-9619: Remove IntersectVisitor from PointsTree API [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #486: URL: https://github.com/apache/lucene/pull/486#issuecomment-1882026028 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10333: Speed up BinaryDocValues with a batch reading on LongValues [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #557: URL: https://github.com/apache/lucene/pull/557#issuecomment-1882025949 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] Avoid use docsSeen in BKDWriter [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12658: URL: https://github.com/apache/lucene/pull/12658#issuecomment-1882024454 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Fix a bug in ShapeTestUtil [lucene]

2024-01-08 Thread via GitHub
heemin32 commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1881932572 There are existing tests which should fails. https://github.com/apache/lucene/blob/main/lucene/core/src/test/org/apache/lucene/document/TestShapeDocValues.java#L67 However

[PR] use Automaton for SurroundQuery prefix/pattern matching [lucene]

2024-01-08 Thread via GitHub
magibney opened a new pull request, #12999: URL: https://github.com/apache/lucene/pull/12999 SurroundQuery still does matching using `java.util.Pattern` (quite slow). This PR switches over SrndTruncQuery and SrndPrefixQuery to use Automaton-based matching. -- This is an

Re: [PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]

2024-01-08 Thread via GitHub
dweiss merged PR #12973: URL: https://github.com/apache/lucene/pull/12973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]

2024-01-08 Thread via GitHub
dweiss commented on code in PR #12973: URL: https://github.com/apache/lucene/pull/12973#discussion_r1445347859 ## lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/EscapeQuerySyntaxImpl.java: ## @@ -40,105 +40,109 @@ public class

Re: [PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]

2024-01-08 Thread via GitHub
dweiss commented on code in PR #12973: URL: https://github.com/apache/lucene/pull/12973#discussion_r1445345012 ## lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/EscapeQuerySyntaxImpl.java: ## @@ -184,7 +186,7 @@ public CharSequence

Re: [I] There may be can simpler in DefaultIndexingChain [LUCENE-9303] [lucene]

2024-01-08 Thread via GitHub
janhoy closed issue #10343: There may be can simpler in DefaultIndexingChain [LUCENE-9303] URL: https://github.com/apache/lucene/issues/10343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] upgrade to OpenNLP 2.3.1 [lucene]

2024-01-08 Thread via GitHub
dweiss commented on PR #12674: URL: https://github.com/apache/lucene/pull/12674#issuecomment-1881823621 Hi @cpoerschke - apologies for the delay. This looks ok to me. It is a pity the dependency sucks in so much other software (slf4j included). I guess this is unavoidable if somebody wants

Re: [PR] [Minor] Fix the only use of java.lang.String#toLowerCase() with no Locale [lucene]

2024-01-08 Thread via GitHub
dweiss merged PR #12856: URL: https://github.com/apache/lucene/pull/12856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Remove unnecessary fields loop from extractWeightedSpanTerms() [lucene]

2024-01-08 Thread via GitHub
dweiss commented on PR #12965: URL: https://github.com/apache/lucene/pull/12965#issuecomment-1881815163 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Remove unnecessary fields loop from extractWeightedSpanTerms() [lucene]

2024-01-08 Thread via GitHub
dweiss merged PR #12965: URL: https://github.com/apache/lucene/pull/12965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] There may be can simpler in DefaultIndexingChain [LUCENE-9303] [lucene]

2024-01-08 Thread via GitHub
shaikhu commented on issue #10343: URL: https://github.com/apache/lucene/issues/10343#issuecomment-1881735389 Hi @janhoy @kkewwei, I think this issues can be closed now? It looks like the followng [PR ](https://github.com/apache/lucene-solr/pull/2076) fixed the issue on master. -- This

Re: [PR] Fix for the bug where JapaneseReadingFormFilter cannot convert some hiragana to romaji [lucene]

2024-01-08 Thread via GitHub
zhaih commented on PR #12885: URL: https://github.com/apache/lucene/pull/12885#issuecomment-1881591349 Thank you bot I obviously forgot to merge this one. @kuramitsu could you please add an CHANGES.txt entry under Lucene 9.10? -- This is an automated message from the Apache Git Service.

Re: [PR] GITHUB#11728: Improve code clarity for OrdinalMap [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1881513260 Oops, sorry about that. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] GITHUB#11728: Improve code clarity for OrdinalMap [lucene]

2024-01-08 Thread via GitHub
mdmarshmallow commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1881511709 Hi @jpountz, thanks for pushing! I took a look back at the comment and I think it references some variable names changes that were added with some of the code changes that weren't

Re: [PR] Avoid reset BlockDocsEnum#freqBuffer when indexHasFreq is false [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #12997: URL: https://github.com/apache/lucene/pull/12997#issuecomment-1881470555 Sorry I might have put you on the wrong track, I didn't know we had such leniency around frequencies/positions/offsets. Out of curiosity, I tried to add checks to AssertingLeafReader to

Re: [PR] LUCENE-10366: Override #readVInt and #readVLong for ByteBufferDataInput to avoid the abstraction confusion of #readByte. [lucene]

2024-01-08 Thread via GitHub
uschindler commented on PR #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1881225703 Does this also affect `MemorySegmentIndexInput`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Use `instanceof` pattern-matching where possible [lucene]

2024-01-08 Thread via GitHub
JarvisCraft commented on PR #12295: URL: https://github.com/apache/lucene/pull/12295#issuecomment-1881153765 Apologies for the late reply, I've lost the track of the message in the thread. I will soon coma back to it and see what should be changed. -- This is an automated message from

Re: [PR] Avoid reset BlockDocsEnum#freqBuffer when indexHasFreq is false [lucene]

2024-01-08 Thread via GitHub
easyice commented on code in PR #12997: URL: https://github.com/apache/lucene/pull/12997#discussion_r1444747244 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99PostingsReader.java: ## @@ -399,7 +400,9 @@ public PostingsEnum reset(IntBlockTermState termState,

Re: [PR] Speed up disjunctions by computing estimations of the score of the k-th top hit up-front. [lucene]

2024-01-08 Thread via GitHub
mikemccand commented on PR #12526: URL: https://github.com/apache/lucene/pull/12526#issuecomment-188101 > > Maybe we should add OrHighVeryLow to nightly benchy too? > > @mikemccand I started looking into this, but my enwiki (`enwiki-20120502-lines-with-random-label.txt`) seems to

Re: [PR] Optimize FST on-heap BytesReader [lucene]

2024-01-08 Thread via GitHub
dungba88 commented on PR #12879: URL: https://github.com/apache/lucene/pull/12879#issuecomment-1881083302 Thanks @mikemccand for merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField #12125 [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #12821: URL: https://github.com/apache/lucene/pull/12821#issuecomment-1881081841 @SreehariG73 Do you plan on removing the unintended changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Copy collected acc(maxFreqs) into empty acc, rather than merge them. [lucene]

2024-01-08 Thread via GitHub
jpountz commented on code in PR #12846: URL: https://github.com/apache/lucene/pull/12846#discussion_r1444698183 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99SkipWriter.java: ## @@ -202,7 +202,11 @@ protected void writeSkipData(int level, DataOutput

Re: [PR] Speed up disjunctions by computing estimations of the score of the k-th top hit up-front. [lucene]

2024-01-08 Thread via GitHub
jpountz closed pull request #12526: Speed up disjunctions by computing estimations of the score of the k-th top hit up-front. URL: https://github.com/apache/lucene/pull/12526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Speed up disjunctions by computing estimations of the score of the k-th top hit up-front. [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #12526: URL: https://github.com/apache/lucene/pull/12526#issuecomment-1881064294 I'll reopen when I have time to get back to this, this could be a useful optimization, though the benefit has become lower thanks to other optimizations to disjunctions. -- This is

Re: [PR] [Fix] Binary search the entries when all suffixes have the same length in a leaf block. [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #11888: URL: https://github.com/apache/lucene/pull/11888#issuecomment-1881059520 @mikemccand I could use your help to review this change, it's quite deep in the guts of block tree. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Remove redundant code in Lucene search [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #12035: URL: https://github.com/apache/lucene/pull/12035#issuecomment-1881058014 Sorry for the very long delay. This sort of detection of loop invariants is indeed handled by C1/C2 compilers, not javac. Without a benchmark suggesting that there is no performance

Re: [PR] LockVerifyServer does not need to reuse addresses nor set accept timeout [lucene]

2024-01-08 Thread via GitHub
mikemccand commented on PR #12535: URL: https://github.com/apache/lucene/pull/12535#issuecomment-1881040587 Aha, thank you @uschindler! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] LockVerifyServer does not need to reuse addresses nor set accept timeout [lucene]

2024-01-08 Thread via GitHub
uschindler commented on PR #12535: URL: https://github.com/apache/lucene/pull/12535#issuecomment-1881005988 Hi @mikemccand, I merged this stale PR. Thanks for taking care. Let's see what Jenkins says. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Clean up sleep in TestBackwardsCompatibility#testCreateMoreTermsIndex [lucene]

2024-01-08 Thread via GitHub
uschindler commented on PR #12914: URL: https://github.com/apache/lucene/pull/12914#issuecomment-1881005112 Thanks @gf2121, I merged this stale PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GITHUB#11728: Improve code clarity for OrdinalMap [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1880971838 Hey @mdmarshmallow. There have been some changes in the meantime that introduced many conflicts, so what I did is that I took your main comment that describes the OrdinalMap algorithm

Re: [PR] GITHUB#11728: Improve code clarity for OrdinalMap [lucene]

2024-01-08 Thread via GitHub
jpountz closed pull request #11729: GITHUB#11728: Improve code clarity for OrdinalMap URL: https://github.com/apache/lucene/pull/11729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Improve code clarity for OrdinalMap [lucene]

2024-01-08 Thread via GitHub
jpountz closed issue #11728: Improve code clarity for OrdinalMap URL: https://github.com/apache/lucene/issues/11728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Reduce ArrayUtil#grow in decompress [lucene]

2024-01-08 Thread via GitHub
easyice commented on code in PR #12996: URL: https://github.com/apache/lucene/pull/12996#discussion_r1444591749 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java: ## @@ -128,10 +128,12 @@ public void decompress(DataInput in, int

Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery [lucene]

2024-01-08 Thread via GitHub
uschindler commented on PR #12135: URL: https://github.com/apache/lucene/pull/12135#issuecomment-1880959801 I think we can also close this one, correct? I already closed my proposal: #12141 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach) [lucene]

2024-01-08 Thread via GitHub
uschindler commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1880958137 We have another solution for this already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach) [lucene]

2024-01-08 Thread via GitHub
uschindler closed pull request #12141: Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach) URL: https://github.com/apache/lucene/pull/12141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] LockVerifyServer does not need to reuse addresses nor set accept timeout [lucene]

2024-01-08 Thread via GitHub
uschindler merged PR #12535: URL: https://github.com/apache/lucene/pull/12535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Clean up sleep in TestBackwardsCompatibility#testCreateMoreTermsIndex [lucene]

2024-01-08 Thread via GitHub
uschindler merged PR #12914: URL: https://github.com/apache/lucene/pull/12914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] LUCENE-10634: Speed up WANDScorer. [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #999: URL: https://github.com/apache/lucene/pull/999#issuecomment-1880941055 I'm closing for now, I may revisit this later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] LUCENE-10634: Speed up WANDScorer. [lucene]

2024-01-08 Thread via GitHub
jpountz closed pull request #999: LUCENE-10634: Speed up WANDScorer. URL: https://github.com/apache/lucene/pull/999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] LUCENE-10519: Improvement for CloseableThreadLocal [lucene]

2024-01-08 Thread via GitHub
jpountz commented on PR #816: URL: https://github.com/apache/lucene/pull/816#issuecomment-1880940378 I'm closing this PR. Since this PR got opened, we removed threadlocals from `SegmentReader` (#11998) so the number of threadlocal objects no longer scales with the number of open segments,

Re: [PR] LUCENE-10519: Improvement for CloseableThreadLocal [lucene]

2024-01-08 Thread via GitHub
jpountz closed pull request #816: LUCENE-10519: Improvement for CloseableThreadLocal URL: https://github.com/apache/lucene/pull/816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] LUCENE-10366: Override #readVInt and #readVLong for ByteBufferDataInput to avoid the abstraction confusion of #readByte. [lucene]

2024-01-08 Thread via GitHub
mikemccand commented on PR #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1880939587 Hello @gf2121! Looks like @uschindler wants you to have to honor of merging this (now stale!) PR! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Reduce duplication in taxonomy facets; always do counts [lucene]

2024-01-08 Thread via GitHub
mikemccand commented on PR #12966: URL: https://github.com/apache/lucene/pull/12966#issuecomment-1880935940 > 3\. Is it important to preserve a default aggregation value of the right type in the results (i.e. `-1` for int aggregations, `-1f` for float aggregations)? If not, we can make a

Re: [PR] Reduce duplication in taxonomy facets; always do counts [lucene]

2024-01-08 Thread via GitHub
mikemccand commented on code in PR #12966: URL: https://github.com/apache/lucene/pull/12966#discussion_r1444557053 ## lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java: ## @@ -202,7 +202,7 @@ public FacetResult getTopChildren(int topN, String dim,

Re: [PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]

2024-01-08 Thread via GitHub
sabi0 commented on code in PR #12973: URL: https://github.com/apache/lucene/pull/12973#discussion_r1444504974 ## lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/EscapeQuerySyntaxImpl.java: ## @@ -184,7 +186,7 @@ public CharSequence

Re: [PR] LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues [lucene]

2024-01-08 Thread via GitHub
mikemccand commented on PR #562: URL: https://github.com/apache/lucene/pull/562#issuecomment-1880919115 Hi @gf2121 -- did we ever performance test this change? It sounds compelling! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] LUCENE-10334: Introduce a BlockReader based on ForUtil and use it for NumericDocValues [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #562: URL: https://github.com/apache/lucene/pull/562#issuecomment-1880905213 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10409: Improve BKDWriter's DocIdsWriter to better encode decreasing sequences of doc IDs [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #666: URL: https://github.com/apache/lucene/pull/666#issuecomment-1880905011 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] Lucene-10336: DirectDocValueFormat: use RandomAccessSlice instead of loading giant byte[] arrays [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #662: URL: https://github.com/apache/lucene/pull/662#issuecomment-1880905067 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] Lucene-10254: Remove Scorable#smoothingScore [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #669: URL: https://github.com/apache/lucene/pull/669#issuecomment-1880904947 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] Lucene-10177: Rename VectorValues#dimension to VectorValues#getNumDimensions [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #670: URL: https://github.com/apache/lucene/pull/670#issuecomment-1880904898 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10311: remove complex cost estimation and abstraction leakage around it [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #709: URL: https://github.com/apache/lucene/pull/709#issuecomment-1880904794 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] Use similarity.tf() in MoreLikeThis [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #940: URL: https://github.com/apache/lucene/pull/940#issuecomment-1880904681 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10519: Improvement for CloseableThreadLocal [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #816: URL: https://github.com/apache/lucene/pull/816#issuecomment-1880904741 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] LUCENE-10322: Enable -Xlint:path and -Xlint:-exports [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #681: URL: https://github.com/apache/lucene/pull/681#issuecomment-1880904855 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] [LUCENE-10624] Binary Search for Sparse IndexedDISI advanceWithinBloc… [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #968: URL: https://github.com/apache/lucene/pull/968#issuecomment-1880904641 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contribution!

Re: [PR] [LUCENE-2587] Highlighter fragment bug [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #1069: URL: https://github.com/apache/lucene/pull/1069#issuecomment-1880904461 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] LUCENE-10616: optimizing decompress when only retrieving some fields [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #1003: URL: https://github.com/apache/lucene/pull/1003#issuecomment-1880904534 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Remove redundant code in Lucene geo [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12036: URL: https://github.com/apache/lucene/pull/12036#issuecomment-1880903913 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12135: URL: https://github.com/apache/lucene/pull/12135#issuecomment-1880903859 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Remove redundant code in Lucene search [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12035: URL: https://github.com/apache/lucene/pull/12035#issuecomment-1880903973 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Reproduce multi-word synonym regression (SOLR-16652) [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12157: URL: https://github.com/apache/lucene/pull/12157#issuecomment-1880903735 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Avoid duplicate sorting in KeywordField#newSetQuery (alternative approach) [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12141: URL: https://github.com/apache/lucene/pull/12141#issuecomment-1880903779 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Add Romanian stopwords with s with comma [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12172: URL: https://github.com/apache/lucene/pull/12172#issuecomment-1880903620 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Change offset to start when data is all equals in StoredFieldsInts.java [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12258: URL: https://github.com/apache/lucene/pull/12258#issuecomment-1880903287 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] simplify PrefixQuery to avoid requiring Automaton [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12207: URL: https://github.com/apache/lucene/pull/12207#issuecomment-1880903543 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Deduplicate ensureValidMerge check [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12237: URL: https://github.com/apache/lucene/pull/12237#issuecomment-1880903404 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Avoid Redundant Loop for Checking Array Element Equality [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12262: URL: https://github.com/apache/lucene/pull/12262#issuecomment-1880903226 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

Re: [PR] Exclude words ending in -ion from Swedish minimal and light stemmers. [lucene]

2024-01-08 Thread via GitHub
github-actions[bot] commented on PR #12247: URL: https://github.com/apache/lucene/pull/12247#issuecomment-1880903343 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your

  1   2   >