vsop-479 commented on PR #13252:
URL: https://github.com/apache/lucene/pull/13252#issuecomment-2027939691
@mikemccand
Please take a look when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
vsop-479 commented on code in PR #11888:
URL: https://github.com/apache/lucene/pull/11888#discussion_r1543957681
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -642,6 +651,97 @@ public SeekStatus scanToTermLeaf(BytesRef targ
rmuir commented on issue #13240:
URL: https://github.com/apache/lucene/issues/13240#issuecomment-2027767666
We can doc the workaround as a possible solution. When I run into trouble I
just go to the `help/`
--
This is an automated message from the Apache Git Service.
To respond to the mes
ojwb commented on PR #13227:
URL: https://github.com/apache/lucene/pull/13227#issuecomment-2027763407
> The only downside is that we can't detect anymore if snowball code calls
unsafe shit like forgetting locales or charsets.
Speaking for snowball, we'd likely take patches adding usef
benwtrent commented on code in PR #13200:
URL: https://github.com/apache/lucene/pull/13200#discussion_r1544871330
##
lucene/core/src/java/org/apache/lucene/codecs/FloatVectorProvider.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
dweiss commented on issue #13240:
URL: https://github.com/apache/lucene/issues/13240#issuecomment-2027719698
Eh. This is something that wasn't there in previous gradle versions. Now
it's a bit paranoid about inputs/outputs overlapping because of caches (I
think...). The suggestions it gives
benwtrent opened a new issue, #13251:
URL: https://github.com/apache/lucene/issues/13251
### Description
Tangentially related to: https://github.com/apache/lucene/issues/13158
But, I have observed, that as the corpus reaches a fairly large size, the
actual quantiles aren't chan
benwtrent merged PR #13235:
URL: https://github.com/apache/lucene/pull/13235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
original-brownbear commented on issue #13249:
URL: https://github.com/apache/lucene/issues/13249#issuecomment-2027531712
Here we go: https://github.com/apache/lucene/pull/13250 turns out we need to
be a little tricky here after all for singletons + ram estimation.
--
This is an automated
original-brownbear commented on issue #13249:
URL: https://github.com/apache/lucene/issues/13249#issuecomment-2027511152
@benwtrent sure thing taking a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
benwtrent commented on issue #13249:
URL: https://github.com/apache/lucene/issues/13249#issuecomment-2027508615
Git bisect shows: c41eb227ea7b569b2df112d0cfdd1f2cc3459f9d
https://github.com/apache/lucene/pull/13232
@original-brownbear mind taking a look?
--
This is an automat
benwtrent opened a new issue, #13249:
URL: https://github.com/apache/lucene/issues/13249
### Description
TestPackedInts.testPackedLongValues fails repeatably, example trace:
```
org.apache.lucene.util.packed.TestPackedInts > testPackedLongValues FAILED
java.lang.Assert
benwtrent commented on code in PR #13197:
URL: https://github.com/apache/lucene/pull/13197#discussion_r1544695975
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestGenerateBwcIndices.java:
##
@@ -82,6 +82,16 @@ public void testCreateSortedIndex() throws IOE
zacharymorn commented on code in PR #13238:
URL: https://github.com/apache/lucene/pull/13238#discussion_r1544688498
##
lucene/MIGRATE.md:
##
@@ -185,6 +185,34 @@ enum.
`IOContext#LOAD` has been replaced with `IOContext#PRELOAD`.
+### IndexSearch#search(Query, Collector) bei
zacharymorn commented on code in PR #13238:
URL: https://github.com/apache/lucene/pull/13238#discussion_r1544685493
##
lucene/MIGRATE.md:
##
@@ -185,6 +185,34 @@ enum.
`IOContext#LOAD` has been replaced with `IOContext#PRELOAD`.
+### IndexSearch#search(Query, Collector) bei
gf2121 commented on PR #13246:
URL: https://github.com/apache/lucene/pull/13246#issuecomment-2027473579
> Out of curiosity, are you seeing a speedup from this change?
On `wikimedium10m`, this patch is slightly faster with little P-value:
```
TaskQPS ba
jpountz commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1544670843
##
lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java:
##
@@ -59,6 +59,11 @@ protected long missingValueAsComparableLong() {
return N
gf2121 commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1544668141
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -85,6 +83,16 @@ public void disableSkipping() {
pruning = Pruning.NONE;
benwtrent commented on code in PR #13235:
URL: https://github.com/apache/lucene/pull/13235#discussion_r1544645006
##
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java:
##
@@ -140,6 +140,10 @@ protected TopDocs approximateSearch(
benwtrent merged PR #13248:
URL: https://github.com/apache/lucene/pull/13248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
benwtrent opened a new pull request, #13248:
URL: https://github.com/apache/lucene/pull/13248
With the 9.10.1 release, the main branch doesn't have the corresponding
version.
Adding this version to main. I ran into this missing version while writing
some new BWC tests.
--
This is
jpountz commented on code in PR #13235:
URL: https://github.com/apache/lucene/pull/13235#discussion_r1544585326
##
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java:
##
@@ -140,6 +140,10 @@ protected TopDocs approximateSearch(
if
jpountz merged PR #13243:
URL: https://github.com/apache/lucene/pull/13243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
benwtrent commented on code in PR #13235:
URL: https://github.com/apache/lucene/pull/13235#discussion_r1544581927
##
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java:
##
@@ -140,6 +140,10 @@ protected TopDocs approximateSearch(
jpountz commented on code in PR #13246:
URL: https://github.com/apache/lucene/pull/13246#discussion_r1544579639
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -321,42 +307,52 @@ private void updateSkipInterval(boolean success) {
uschindler commented on PR #13244:
URL: https://github.com/apache/lucene/pull/13244#issuecomment-2027327717
I think this idea is not too bad, because as Robert said, unless we merge or
flush, access is always random, so readahead is bad.
We should still compare results under memory pr
gf2121 commented on code in PR #13221:
URL: https://github.com/apache/lucene/pull/13221#discussion_r1544575799
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -193,170 +209,160 @@ public void setHitsThresholdReached() throws
IOExceptio
uschindler merged PR #13247:
URL: https://github.com/apache/lucene/pull/13247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler merged PR #13245:
URL: https://github.com/apache/lucene/pull/13245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
jpountz commented on code in PR #13235:
URL: https://github.com/apache/lucene/pull/13235#discussion_r1544485782
##
lucene/join/src/java/org/apache/lucene/search/join/DiversifyingChildrenByteKnnVectorQuery.java:
##
@@ -140,6 +140,10 @@ protected TopDocs approximateSearch(
if
benwtrent merged PR #13237:
URL: https://github.com/apache/lucene/pull/13237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
jpountz merged PR #13232:
URL: https://github.com/apache/lucene/pull/13232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
ChrisHegarty commented on code in PR #13200:
URL: https://github.com/apache/lucene/pull/13200#discussion_r158539
##
lucene/core/src/java/org/apache/lucene/codecs/FloatVectorProvider.java:
##
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
gf2121 commented on code in PR #13221:
URL: https://github.com/apache/lucene/pull/13221#discussion_r1544434866
##
lucene/core/src/java/org/apache/lucene/search/comparators/DoubleComparator.java:
##
@@ -54,6 +54,11 @@ public Double value(int slot) {
return Double.valueOf(val
gf2121 opened a new pull request, #13246:
URL: https://github.com/apache/lucene/pull/13246
Simplify complex byte array comparisons as long comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
original-brownbear commented on code in PR #13232:
URL: https://github.com/apache/lucene/pull/13232#discussion_r1544399427
##
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
##
@@ -566,10 +566,20 @@ public String toString() {
/** A {@link Reader} which has
uschindler commented on PR #13245:
URL: https://github.com/apache/lucene/pull/13245#issuecomment-2027117060
I think last one is shortest. EnumMap would have been fine, but as it is all
internal cache a simple array on enum's ordinal number is enough (same approach
like switch statements on
uschindler commented on code in PR #13242:
URL: https://github.com/apache/lucene/pull/13242#discussion_r1544334488
##
lucene/core/src/java/org/apache/lucene/store/IOContext.java:
##
@@ -87,12 +86,13 @@ public IOContext(MergeInfo mergeInfo) {
/**
* Return an updated {@li
jpountz commented on code in PR #13221:
URL: https://github.com/apache/lucene/pull/13221#discussion_r1544316035
##
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java:
##
@@ -193,170 +209,160 @@ public void setHitsThresholdReached() throws
IOExcepti
Priyanshu-Madhup commented on issue #13218:
URL: https://github.com/apache/lucene/issues/13218#issuecomment-2026958805
is this for 10.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
kaivalnp commented on PR #13243:
URL: https://github.com/apache/lucene/pull/13243#issuecomment-2026952509
Makes sense, added now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jpountz closed pull request #13236: Split IOContext.DEFAULT into WRITE and READ.
URL: https://github.com/apache/lucene/pull/13236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jpountz commented on PR #13236:
URL: https://github.com/apache/lucene/pull/13236#issuecomment-2026951354
Closed in favor of #13242.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jpountz merged PR #13242:
URL: https://github.com/apache/lucene/pull/13242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
uschindler commented on PR #13236:
URL: https://github.com/apache/lucene/pull/13236#issuecomment-2026950362
Perfect. Let's close this PR as won't fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jpountz commented on PR #13223:
URL: https://github.com/apache/lucene/pull/13223#issuecomment-2026945157
> the alternative approach of using a MADV_RANDOM all the time for
IOContext.READ
I opened #13244 to show what this could look like.
--
This is an automated message from the Apa
jpountz opened a new pull request, #13244:
URL: https://github.com/apache/lucene/pull/13244
This effectively forces index inputs to be either open with a SEQUENTIAL or
RANDOM advice, with nothing in between.
--
This is an automated message from the Apache Git Service.
To respond to th
uschindler commented on code in PR #13242:
URL: https://github.com/apache/lucene/pull/13242#discussion_r1544287471
##
lucene/core/src/java/org/apache/lucene/store/IOContext.java:
##
@@ -87,12 +86,13 @@ public IOContext(MergeInfo mergeInfo) {
/**
* Return an updated {@li
jpountz commented on code in PR #13238:
URL: https://github.com/apache/lucene/pull/13238#discussion_r1544270671
##
lucene/MIGRATE.md:
##
@@ -185,6 +185,34 @@ enum.
`IOContext#LOAD` has been replaced with `IOContext#PRELOAD`.
+### IndexSearch#search(Query, Collector) being d
jpountz commented on PR #13243:
URL: https://github.com/apache/lucene/pull/13243#issuecomment-2026922517
Can you add an entry to `lucene/MIGRATE.txt` suggesting to use
`IndexSearcher#setTimeout` instead?
--
This is an automated message from the Apache Git Service.
To respond to the messag
kaivalnp commented on PR #13220:
URL: https://github.com/apache/lucene/pull/13220#issuecomment-2026920169
Created a follow-up to remove `TimeLimitingCollector` from `main` after
deprecation: #13243
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
kaivalnp opened a new pull request, #13243:
URL: https://github.com/apache/lucene/pull/13243
### Description
Follow up to #13220: Delete `TimeLimitingCollector` on `main` after
deprecation
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
jpountz merged PR #13128:
URL: https://github.com/apache/lucene/pull/13128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on code in PR #13237:
URL: https://github.com/apache/lucene/pull/13237#discussion_r1544264043
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswVectorsReader.java:
##
@@ -200,9 +200,18 @@ private VectorSimilarityFunction
jpountz commented on PR #13236:
URL: https://github.com/apache/lucene/pull/13236#issuecomment-2026911614
@uschindler See #13242.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
jpountz commented on PR #13236:
URL: https://github.com/apache/lucene/pull/13236#issuecomment-2026883623
That should work as well, let me give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
uschindler commented on PR #13236:
URL: https://github.com/apache/lucene/pull/13236#issuecomment-2026876507
Actually my suggestion is now a rather simple rename so should be easy to
apply with IDE. The diff should also get shorter.
--
This is an automated message from the Apache Git Servi
uschindler commented on PR #13236:
URL: https://github.com/apache/lucene/pull/13236#issuecomment-2026865084
Hi,
I was thinking about it. Why do we need to differentiate between read and
write? If you open an IndexInput you read, if you open IndexOutput you're going
to write. If you copy,
jpountz commented on PR #13236:
URL: https://github.com/apache/lucene/pull/13236#issuecomment-2026853503
For what it's worth, the change is huge because lots of tests used to use
`IOContext.DEFAULT` and had to be fixed. If you filter the diff to only look at
the non-test source folders, thi
uschindler commented on PR #13229:
URL: https://github.com/apache/lucene/pull/13229#issuecomment-2026851640
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
jpountz merged PR #13229:
URL: https://github.com/apache/lucene/pull/13229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #13220:
URL: https://github.com/apache/lucene/pull/13220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz commented on PR #13220:
URL: https://github.com/apache/lucene/pull/13220#issuecomment-2026847843
Thanks for confirming, I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
vsop-479 commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1544202746
##
lucene/core/src/java/org/apache/lucene/util/automaton/RunAutomaton.java:
##
@@ -96,6 +101,35 @@ protected RunAutomaton(Automaton a, int alphabetSize) {
}
}
tteofili merged PR #13225:
URL: https://github.com/apache/lucene/pull/13225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
stefanvodita commented on PR #12966:
URL: https://github.com/apache/lucene/pull/12966#issuecomment-2026779113
Hi reviewers! This PR has become stale. Could anyone have a look at it? It
has several nice improvements for taxonomy facets, with no API changes, and it
sets us up to launch new fe
66 matches
Mail list logo
