Re: [PR] [GITHUB-11915] Make Lucene smarter about long runs of matches via new API on DISI [lucene]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-2067417365 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] update commons-compress from 1.19 to 1.21 [lucene]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #13270: URL: https://github.com/apache/lucene/pull/13270#issuecomment-2067416705 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #13276: URL: https://github.com/apache/lucene/pull/13276#issuecomment-2067416686 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-19 Thread via GitHub
uschindler commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1572278447 ## lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java: ## @@ -302,7 +301,6 @@ private static VectorSimilarityFunction getDistFunc

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-19 Thread via GitHub
ChrisHegarty commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1572273717 ## lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java: ## @@ -302,7 +301,6 @@ private static VectorSimilarityFunction getDistFu

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-19 Thread via GitHub
uschindler commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1572253289 ## lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java: ## @@ -61,24 +60,6 @@ public float compare(byte[] v1, byte[] v2) { } }, -

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-19 Thread via GitHub
uschindler commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1572253289 ## lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java: ## @@ -61,24 +60,6 @@ public float compare(byte[] v1, byte[] v2) { } }, -

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-19 Thread via GitHub
uschindler commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1572250272 ## lucene/core/src/java/org/apache/lucene/codecs/lucene94/Lucene94FieldInfosFormat.java: ## @@ -302,7 +301,6 @@ private static VectorSimilarityFunction getDistFunc

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-19 Thread via GitHub
uschindler commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1572248253 ## lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java: ## @@ -61,24 +60,6 @@ public float compare(byte[] v1, byte[] v2) { } }, -

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-19 Thread via GitHub
uschindler commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1572245689 ## lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java: ## @@ -61,24 +60,6 @@ public float compare(byte[] v1, byte[] v2) { } }, -

Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-19 Thread via GitHub
uschindler commented on code in PR #13308: URL: https://github.com/apache/lucene/pull/13308#discussion_r1572243002 ## lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java: ## @@ -61,24 +60,6 @@ public float compare(byte[] v1, byte[] v2) { } }, -

Re: [I] Suggestion about LRUQueryCache Optimization [lucene]

2024-04-19 Thread via GitHub
boicehuang commented on issue #13318: URL: https://github.com/apache/lucene/issues/13318#issuecomment-2066195833 @jpountz what you think on this? Any help will be appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[I] Suggestion about LRUQueryCache Optimization [lucene]

2024-04-19 Thread via GitHub
boicehuang opened a new issue, #13318: URL: https://github.com/apache/lucene/issues/13318 ### Description https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java#L747 Can we use ReentrantReadWriteLock in `LRUQueryCache` to al

Re: [PR] Use Arrays.compareUnsigned instead of iterating compare. [lucene]

2024-04-19 Thread via GitHub
uschindler merged PR #13252: URL: https://github.com/apache/lucene/pull/13252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.