[GitHub] [lucene] benwtrent commented on pull request #12004: Move byte vector queries into new KnnByteVectorQuery

2022-12-14 Thread GitBox
benwtrent commented on PR #12004: URL: https://github.com/apache/lucene/pull/12004#issuecomment-1351211685 @uschindler 100%! I can get the backport PR done asap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene] benwtrent commented on pull request #12004: Move byte vector queries into new KnnByteVectorQuery

2022-12-12 Thread GitBox
benwtrent commented on PR #12004: URL: https://github.com/apache/lucene/pull/12004#issuecomment-1346600559 > Since we're changing this stuff, I wonder if BytesRef is the right abstraction for a vector of bytes or if we should switch to a plain byte[] I adjusted the query API there an

[GitHub] [lucene] benwtrent commented on pull request #12004: Move byte vector queries into new KnnByteVectorQuery

2022-12-08 Thread GitBox
benwtrent commented on PR #12004: URL: https://github.com/apache/lucene/pull/12004#issuecomment-1343454137 @rmuir the first of the multiple refactors. I attempted first to do it all in one change, but this proved to be an absolutely huge change (6k+ LOC churn) that spread across many