[GitHub] [lucene] gsmiller commented on a change in pull request #578: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

gsmiller commented on a change in pull request #578: URL: https://github.com/apache/lucene/pull/578#discussion_r781315189 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -74,11 +74,6 @@ protected boolean useHashTable(FacetsColl

[GitHub] [lucene] gsmiller commented on a change in pull request #578: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

gsmiller commented on a change in pull request #578: URL: https://github.com/apache/lucene/pull/578#discussion_r779786913 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java ## @@ -69,7 +69,7 @@ public FastTaxonomyFacetCounts(

[GitHub] [lucene] gsmiller commented on a change in pull request #578: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

gsmiller commented on a change in pull request #578: URL: https://github.com/apache/lucene/pull/578#discussion_r779785273 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -74,11 +74,6 @@ protected boolean useHashTable(FacetsColl

[GitHub] [lucene] gsmiller commented on a change in pull request #578: LUCENE-10350: Avoid some null checking for FastTaxonomyFacetCounts#countAll()

gsmiller commented on a change in pull request #578: URL: https://github.com/apache/lucene/pull/578#discussion_r779174169 ## File path: lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java ## @@ -74,11 +74,6 @@ protected boolean useHashTable(FacetsColl