[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-22 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r856809167 ## lucene/distribution/src/binary-release/bin/luke.sh: ## @@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then else # We are integration-testing. Force UTF-8 as the encodi

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-22 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r856765168 ## help/tests.txt: ## @@ -128,6 +128,24 @@ specifying the project and test task or a fully qualified task path. Example: gradlew -p lucene/core test -Ptests.verbose=true

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-22 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r856754362 ## lucene/distribution/src/binary-release/bin/luke.sh: ## @@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then else # We are integration-testing. Force UTF-8 as the encodi

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-21 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r855707897 ## lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java: ## @@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception { boolean sanit

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-21 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r855698828 ## lucene/distribution/src/binary-release/bin/luke.sh: ## @@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then else # We are integration-testing. Force UTF-8 as the encodi

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-21 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r855698566 ## lucene/distribution/src/binary-release/bin/luke.sh: ## @@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then else # We are integration-testing. Force UTF-8 as the encodi

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-21 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r855687014 ## gradlew: ## @@ -217,4 +217,8 @@ if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then cd "$(dirname "$0")" fi -exec "$JAVACMD" "$@" +if command -v xvfb-run >

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-21 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r855687014 ## gradlew: ## @@ -217,4 +217,8 @@ if [ "$(uname)" = "Darwin" ] && [ "$HOME" = "$PWD" ]; then cd "$(dirname "$0")" fi -exec "$JAVACMD" "$@" +if command -v xvfb-run >

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-21 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r855685351 ## lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java: ## @@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception { boolean sanit

[GitHub] [lucene] mocobeta commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

2022-04-21 Thread GitBox
mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r855685351 ## lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java: ## @@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception { boolean sanit