[GitHub] [lucene-solr] ErickErickson commented on pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

2020-11-09 Thread GitBox
ErickErickson commented on pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723990436 +1 > On Nov 8, 2020, at 3:30 PM, David Smiley wrote: > > > So @dsmiley @ErickErickson do we all agree that we throw an exception in in

[GitHub] [lucene-solr] ErickErickson commented on pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

2020-11-08 Thread GitBox
ErickErickson commented on pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723577563 David: I’ve no objection to removing all the if (transientHandler==null) tests if we fail on initialization. Bruno: Yeah, I think 9.0 only is the