ErickErickson commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723990436


   +1
   
   > On Nov 8, 2020, at 3:30 PM, David Smiley <notificati...@github.com> wrote:
   > 
   > 
   > So @dsmiley @ErickErickson do we all agree that we throw an exception in 
in TransientSolrCoreCacheFactory.newInstance() line 60 and we never return null?
   > 
   > +1 definitely
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   > 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to