bruno-roustant commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-724113057
@dsmiley I pushed a new commit to have a NO OP TransientSolrCacheFactory
before SolrCores.load() is called.
This is to have your opinion, whether to keep it or remo
bruno-roustant commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723960636
Ok, now I think I integrated all comments.
This is an automated message from the Apache Git Service.
bruno-roustant commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723587255
So @dsmiley @ErickErickson do we all agree that we throw an exception in in
TransientSolrCoreCacheFactory.newInstance() line 60 and we never return null?
---
bruno-roustant commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723586994
Finally I optimized SolrCore.getCoreDescriptors(). The version in this
commit is the one for the 8.x branch -
TransientSolrCoreCache.getTransientDescriptors() stays c
bruno-roustant commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723568609
I'm looking at optimizing SolrCores.getCoreDescriptors() but actually it
would require to add a new TransientSolrCoreCache.getTransientDescriptors()
method. This mean
bruno-roustant commented on pull request #2066:
URL: https://github.com/apache/lucene-solr/pull/2066#issuecomment-723503967
I'll continue soon with two other improvements:
- Optimize SolrCores.getCoreDescriptors().
- NOOP TransientSolrCoreCache.
--
