[GitHub] [lucene-solr] ctargett commented on pull request #1869: SOLR-14866 autowidth tables in ref guide

2020-09-22 Thread GitBox
ctargett commented on pull request #1869: URL: https://github.com/apache/lucene-solr/pull/1869#issuecomment-696366569 I'm a little confused what's going on here at this point. It seems the latest commits increase the mixing of styles, which as I said is fine with me in general, but sort

[GitHub] [lucene-solr] ctargett commented on pull request #1869: SOLR-14866 autowidth tables in ref guide

2020-09-21 Thread GitBox
ctargett commented on pull request #1869: URL: https://github.com/apache/lucene-solr/pull/1869#issuecomment-696366569 I'm a little confused what's going on here at this point. It seems the latest commits increase the mixing of styles, which as I said is fine with me in general, but sort

[GitHub] [lucene-solr] ctargett commented on pull request #1869: SOLR-14866 autowidth tables in ref guide

2020-09-16 Thread GitBox
ctargett commented on pull request #1869: URL: https://github.com/apache/lucene-solr/pull/1869#issuecomment-693491731 I don't view the syntax of "leave a blank line after the first line to make it a header row" as simpler (which is what I think you mean), at least it isn't for me. Until I

[GitHub] [lucene-solr] ctargett commented on pull request #1869: SOLR-14866 autowidth tables in ref guide

2020-09-16 Thread GitBox
ctargett commented on pull request #1869: URL: https://github.com/apache/lucene-solr/pull/1869#issuecomment-693403436 bq. Having consistent best practices encoded in the document The place that codifies our asciidoc best practices is in `meta-docs/asciidoc-syntax.adoc`, which is

[GitHub] [lucene-solr] ctargett commented on pull request #1869: SOLR-14866 autowidth tables in ref guide

2020-09-15 Thread GitBox
ctargett commented on pull request #1869: URL: https://github.com/apache/lucene-solr/pull/1869#issuecomment-693000958 So, the changes look fine enough to me, but I don't think they're actually needed. The `%autowidth.spread` works by setting a `spread` class on the element. This