[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r535921190 ## File path: lucene/misc/native/build.gradle ## @@ -51,11 +47,7 @@ tasks.withType(CppCompile).configureEach { // is present.

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r534851417 ## File path: lucene/misc/native/build.gradle ## @@ -51,11 +47,7 @@ tasks.withType(CppCompile).configureEach { // is present.

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r528111453 ## File path: lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java ## @@ -745,7 +745,7 @@ public synchronized IndexInput

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524972056 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524961331 ## File path: lucene/misc/src/test/org/apache/lucene/misc/store/DirectIODirectoryTest.java ## @@ -18,29 +18,37 @@ import

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524958131 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r524942578 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -74,12 +65,12 @@ * * @lucene.experimental */