[GitHub] [lucene-solr] janhoy commented on pull request #2430: SOLR-15194: relax requirements and allow http urls.

2021-02-26 Thread GitBox
janhoy commented on pull request #2430: URL: https://github.com/apache/lucene-solr/pull/2430#issuecomment-786956265 Could you bring the or up to date with master? Lots of unrelated stuff in the diff now. This is an automated

[GitHub] [lucene-solr] janhoy commented on pull request #2430: SOLR-15194: relax requirements and allow http urls.

2021-02-26 Thread GitBox
janhoy commented on pull request #2430: URL: https://github.com/apache/lucene-solr/pull/2430#issuecomment-786612766 > Do you think the WARN logic is EVEN useful since we have a parameter now that you have to intentionally set. I'm wondering what your thought is on removing the warning in t

[GitHub] [lucene-solr] janhoy commented on pull request #2430: SOLR-15194: relax requirements and allow http urls.

2021-02-25 Thread GitBox
janhoy commented on pull request #2430: URL: https://github.com/apache/lucene-solr/pull/2430#issuecomment-786317911 It's difficult to review since it suddenly contains unrelated edits. Think you should merge in latest master again... ---