[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-03 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482772181 ## File path: lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java ## @@ -202,4 +203,63 @@ public BytesRef binaryValue() {

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-02 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482419163 ## File path: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java ## @@ -165,4 +166,62 @@ public long longValue() { retur

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-02 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482434175 ## File path: lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java ## @@ -202,4 +203,63 @@ public BytesRef binaryValue() {

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-02 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r482418961 ## File path: lucene/core/src/java/org/apache/lucene/index/NumericDocValuesWriter.java ## @@ -165,4 +166,62 @@ public long longValue() { retur

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-09-02 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r481823967 ## File path: lucene/core/src/java/org/apache/lucene/index/BinaryDocValuesWriter.java ## @@ -202,4 +203,63 @@ public BytesRef binaryValue() {

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-08-31 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r480385432 ## File path: lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java ## @@ -1090,20 +1150,64 @@ public Bits getLiveDocs() { } @O