[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

noblepaul commented on a change in pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#discussion_r501367533 ## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ## @@ -1110,10 +,10 @@ private void addVal(NamedList nl, String

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

noblepaul commented on a change in pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#discussion_r501367533 ## File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java ## @@ -1110,10 +,10 @@ private void addVal(NamedList nl, String

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

noblepaul commented on a change in pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#discussion_r500216190 ## File path: solr/core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java ## @@ -308,19 +318,24 @@ public void testKeyMetrics() throws

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

noblepaul commented on a change in pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#discussion_r500206089 ## File path: solr/core/src/java/org/apache/solr/util/stats/MetricUtils.java ## @@ -385,10 +406,10 @@ static double nsToMs(boolean convert, double v