noblepaul commented on a change in pull request #1951:
URL: https://github.com/apache/lucene-solr/pull/1951#discussion_r501367533
##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -1110,10 +1111,10 @@ private void addVal(NamedList<Object> nl, String key,
Properties props, @Suppres
}
}
- private void addVal(Map<String, Object> map, String key, Properties props,
@SuppressWarnings({"rawtypes"})Class clzz) {
+ private void addVal(MapWriter.EntryWriter ew, String key, Properties props,
@SuppressWarnings({"rawtypes"})Class clzz) {
Object val = formatVal(key, props, clzz);
if (val != null) {
- map.put(key, val);
+ ew.putNoEx(key, val);
Review comment:
there is a putIfNotNull()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
