noblepaul commented on pull request #1951:
URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-705248728
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
noblepaul commented on pull request #1951:
URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704677008
>Not in branch_8x - it's a part of the public API.
We can have both and mark the old as deprecated. The guages are creating too
many Map objects
--
noblepaul commented on pull request #1951:
URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704676764
>Again, we're limited by back-compat in 8x. We could add another set of
methods in MetricUtils that use Predicate and deprecate PropertyFilter
... but that would double th
noblepaul commented on pull request #1951:
URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704237134
Is it possible to change `MetricsMap implements Gauge>`
to
` MetricsMap implements Gauge`
Th
noblepaul commented on pull request #1951:
URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704215473
Can we get rid of the interface `PropertyFilter` and replace it with a
`Predicate`?
You can use the class `ConditionalKeyMapWriter` to filter
`MetricUtils.add
