noblepaul commented on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704215473
Can we get rid of the interface `PropertyFilter` and replace it with a `Predicate<String>`? You can use the class `ConditionalKeyMapWriter` to filter `MetricUtils.addMetrics()` : Why can't we just have an anonymous class that implements `MapWriter` and avoid creation of `NamedList` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
