[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-19 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539786#comment-17539786 ] Adrien Grand commented on LUCENE-10481: --- I pushed an annotation to luceneutil, this triggered a

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-18 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538904#comment-17538904 ] Mike Drob commented on LUCENE-10481: The relevant results are part of

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538891#comment-17538891 ] Michael McCandless commented on LUCENE-10481: - {quote}Hmm... some slightly disappointing

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17538889#comment-17538889 ] Michael McCandless commented on LUCENE-10481: - I think the reason why it may sometimes need

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537689#comment-17537689 ] ASF subversion and git services commented on LUCENE-10481: -- Commit

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-12 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536228#comment-17536228 ] Adrien Grand commented on LUCENE-10481: --- [~mdrob] It sounds reasonable to me, the change is safe.

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-12 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17536218#comment-17536218 ] Mike Drob commented on LUCENE-10481: [~jpountz] - what would you think about a back port to 8.11.2?

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511290#comment-17511290 ] ASF subversion and git services commented on LUCENE-10481: -- Commit

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-23 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511129#comment-17511129 ] Adrien Grand commented on LUCENE-10481: --- It's still a good change. :) > FacetsCollector does not

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510880#comment-17510880 ] Mike Drob commented on LUCENE-10481: Hmm... some slightly disappointing results - although we saw

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-22 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510809#comment-17510809 ] Mike Drob commented on LUCENE-10481: I _think_ the use case would be to collect facets over only

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-03-22 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510793#comment-17510793 ] Adrien Grand commented on LUCENE-10481: --- Your change looks good, but this makes me wonder why the