[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308990#comment-17308990 ] ASF subversion and git services commented on LUCENE-9864: - Commit

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308846#comment-17308846 ] Dawid Weiss commented on LUCENE-9864: - I'll take a look at making this jflex task saner as part of

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308844#comment-17308844 ] Robert Muir commented on LUCENE-9864: - Thank you [~dweiss]. Congratulations, you made it into

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308829#comment-17308829 ] Dawid Weiss commented on LUCENE-9864: - {code} gradlew regenerate -x jflexUAX29URLEmailTokenizerImpl

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308826#comment-17308826 ] Robert Muir commented on LUCENE-9864: - I'm working on the queryparser pieces. It is just slow

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308812#comment-17308812 ] Robert Muir commented on LUCENE-9864: - Sorry, I missed seeing the modified queryparser sources

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308794#comment-17308794 ] Robert Muir commented on LUCENE-9864: - I only saw issues with snowball generated code: I updated the

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308556#comment-17308556 ] Dawid Weiss commented on LUCENE-9864: - It's simpler because you don't need to know what gets

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308555#comment-17308555 ] Dawid Weiss commented on LUCENE-9864: - Yes, we could do this. Alternatively, we a much simpler way

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308540#comment-17308540 ] Uwe Schindler commented on LUCENE-9864: --- Especially the missing overrides at beginning of file in

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308474#comment-17308474 ] Dawid Weiss commented on LUCENE-9864: - Try gradlew regenerate -x jflexUAX29URLEmailTokenizerImpl -

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308473#comment-17308473 ] Dawid Weiss commented on LUCENE-9864: - The patch changes files in generated code. If you run

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17308402#comment-17308402 ] Zach Chen commented on LUCENE-9864: --- Hi [~rcmuir] [~uschindler], I've opened a PR to enforce @Override

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-24 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307828#comment-17307828 ] Uwe Schindler commented on LUCENE-9864: --- +1 > Enforce @Override annotation with ecj static