[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188108#comment-17188108 ] Noble Paul commented on SOLR-14579: --- [~erickerickson] are you going to do this only on master or on

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188097#comment-17188097 ] Erick Erickson commented on SOLR-14579: --- [~noble.paul] I guess I'll take this one. The PR has some

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-26 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146437#comment-17146437 ] Erick Erickson commented on SOLR-14579: --- Addendum to my comment. It turned out that suppressing

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-22 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142003#comment-17142003 ] Erick Erickson commented on SOLR-14579: --- I'm still working on it. 9x should compile cleanly, 8x

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-22 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141972#comment-17141972 ] Noble Paul commented on SOLR-14579: --- Didn't you suppress all the warnings [~erickerickson]? > Remove

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-22 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141964#comment-17141964 ] Erick Erickson commented on SOLR-14579: --- Get used to me asking this ;). But will it compile without

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-22 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141911#comment-17141911 ] Ilan Ginzburg commented on SOLR-14579: -- I second [~ab] here. When we write non obvious code, we

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-22 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141874#comment-17141874 ] Noble Paul commented on SOLR-14579: --- Our code still compiles with java 8 for the current releases. It's

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-22 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141860#comment-17141860 ] Andrzej Bialecki commented on SOLR-14579: - That's only partially true because HotSpot _may_ 

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-22 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141846#comment-17141846 ] Noble Paul commented on SOLR-14579: --- people misunderstand lambdas let's look at a very innocuous

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-06-22 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141832#comment-17141832 ] Noble Paul commented on SOLR-14579: --- the NEW_HASHMAP_FUN was added for a purpose (efficiency)