[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306558#comment-17306558 ] Robert Muir commented on LUCENE-9861: - {quote} But for stuff that works perfectly fi

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306625#comment-17306625 ] Robert Muir commented on LUCENE-9861: - If you have 87 cores, you can afford to spend

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306627#comment-17306627 ] Robert Muir commented on LUCENE-9861: - Another way to look at it, if you see that, y

[jira] [Commented] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306677#comment-17306677 ] Robert Muir commented on LUCENE-9856: - While wrestling with the PR, I found out abou

[jira] [Created] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-22 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9862: --- Summary: gradlew regenerate doesnt invoke jflexStandardTokenizerImpl Key: LUCENE-9862 URL: https://issues.apache.org/jira/browse/LUCENE-9862 Project: Lucene - Core

[jira] [Created] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-23 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9863: --- Summary: run spotless across groovy (e.g. gradle) code too Key: LUCENE-9863 URL: https://issues.apache.org/jira/browse/LUCENE-9863 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-9861) speed up precommit

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306997#comment-17306997 ] Robert Muir commented on LUCENE-9861: - Thank you [~dweiss], this one really helps my

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307033#comment-17307033 ] Robert Muir commented on LUCENE-9863: - Does it just need more maturity before it can

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307111#comment-17307111 ] Robert Muir commented on LUCENE-9862: - Oh man, it is probably a bug. This thing is p

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307122#comment-17307122 ] Robert Muir commented on LUCENE-9862: - I must have messed it up the last time I upgr

[jira] [Resolved] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9856. - Fix Version/s: main (9.0) Resolution: Fixed > Improve static analysis to catch dead code

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307177#comment-17307177 ] Robert Muir commented on LUCENE-9827: - [~jpountz] As far as the "1% dirty docs", it

[jira] [Reopened] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reopened LUCENE-9856: - I reverted this due to test failures. I will look into it, I think i angered the attributes. > Imp

[jira] [Commented] (LUCENE-9850) Explore PFOR for Doc ID delta encoding (instead of FOR)

2021-03-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307382#comment-17307382 ] Robert Muir commented on LUCENE-9850: - Maybe rather than power of two, try a list so

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307909#comment-17307909 ] Robert Muir commented on LUCENE-9863: - I think my issue is that there is no agreed-u

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307914#comment-17307914 ] Robert Muir commented on LUCENE-9863: - As an example, I opened this issue because of

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307925#comment-17307925 ] Robert Muir commented on LUCENE-9863: - Also given there is no standard, i tend to le

[jira] [Created] (LUCENE-9866) regenerate kuromoji dict in regenerate

2021-03-24 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9866: --- Summary: regenerate kuromoji dict in regenerate Key: LUCENE-9866 URL: https://issues.apache.org/jira/browse/LUCENE-9866 Project: Lucene - Core Issue Type: Task

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307938#comment-17307938 ] Robert Muir commented on LUCENE-9862: - Thank you for the improvements here [~dweiss]

[jira] [Commented] (LUCENE-9863) run spotless across groovy (e.g. gradle) code too

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307946#comment-17307946 ] Robert Muir commented on LUCENE-9863: - I agree, I don't want to sound like a complai

[jira] [Commented] (LUCENE-9862) gradlew regenerate doesnt invoke jflexStandardTokenizerImpl

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307951#comment-17307951 ] Robert Muir commented on LUCENE-9862: - Yes, that one triggered the OOM killer on my

[jira] [Resolved] (LUCENE-9856) Improve static analysis to catch dead code and other potential bugs

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9856. - Resolution: Fixed Thanks [~uschindler] for cleaning up the long tail here! > Improve static ana

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-03-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308339#comment-17308339 ] Robert Muir commented on LUCENE-9867: - [~sqshq] you really shouldn't see FileNotFoun

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308510#comment-17308510 ] Robert Muir commented on LUCENE-9867: - [~sqshq] the general problem is files getting

[jira] [Commented] (LUCENE-9866) regenerate kuromoji dict in regenerate

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308512#comment-17308512 ] Robert Muir commented on LUCENE-9866: - [~dweiss] we package mecab by default with lu

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308538#comment-17308538 ] Robert Muir commented on LUCENE-9867: - I'm really not worried about XFS yet. I first

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308794#comment-17308794 ] Robert Muir commented on LUCENE-9864: - I only saw issues with snowball generated cod

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308812#comment-17308812 ] Robert Muir commented on LUCENE-9864: - Sorry, I missed seeing the modified querypars

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308826#comment-17308826 ] Robert Muir commented on LUCENE-9864: - I'm working on the queryparser pieces. It is

[jira] [Commented] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308844#comment-17308844 ] Robert Muir commented on LUCENE-9864: - Thank you [~dweiss]. Congratulations, you mad

[jira] [Resolved] (LUCENE-9864) Enforce @Override annotation with ecj static analysis configuration

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9864. - Resolution: Fixed > Enforce @Override annotation with ecj static analysis configuration > --

[jira] [Commented] (LUCENE-9868) Verify checksums on generated files

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308997#comment-17308997 ] Robert Muir commented on LUCENE-9868: - I think hashing could be extremely difficult

[jira] [Created] (LUCENE-9878) enable redundantNullCheck in ecjLint

2021-03-25 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9878: --- Summary: enable redundantNullCheck in ecjLint Key: LUCENE-9878 URL: https://issues.apache.org/jira/browse/LUCENE-9878 Project: Lucene - Core Issue Type: Task

[jira] [Created] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9879: --- Summary: errorprone cause large slowdown of compileJava/compileTestJava Key: LUCENE-9879 URL: https://issues.apache.org/jira/browse/LUCENE-9879 Project: Lucene - Core

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309136#comment-17309136 ] Robert Muir commented on LUCENE-9879: - In an ideal world I think, we'd let javac do

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309138#comment-17309138 ] Robert Muir commented on LUCENE-9879: - Related issue, particularly this comment: ht

[jira] [Commented] (LUCENE-9880) Task ordering can be incorrect for gradlew clean [...]

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309308#comment-17309308 ] Robert Muir commented on LUCENE-9880: - I hit this sometimes too. > Task ordering c

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309312#comment-17309312 ] Robert Muir commented on LUCENE-9879: - {quote} Thanks Robert: this explains why it g

[jira] [Commented] (LUCENE-9868) Verify checksums on generated files

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309334#comment-17309334 ] Robert Muir commented on LUCENE-9868: - Yeah, probably a few other things we want to

[jira] [Commented] (LUCENE-9880) Task ordering can be incorrect for gradlew clean [...]

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309391#comment-17309391 ] Robert Muir commented on LUCENE-9880: - I don't know if it helps, but if you pass "-v

[jira] [Created] (LUCENE-9881) synchronize ECJ linter with eclipse IDE

2021-03-26 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9881: --- Summary: synchronize ECJ linter with eclipse IDE Key: LUCENE-9881 URL: https://issues.apache.org/jira/browse/LUCENE-9881 Project: Lucene - Core Issue Type: Tas

[jira] [Created] (LUCENE-9882) better synchronize eclipse formatter with spotless

2021-03-26 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9882: --- Summary: better synchronize eclipse formatter with spotless Key: LUCENE-9882 URL: https://issues.apache.org/jira/browse/LUCENE-9882 Project: Lucene - Core Issu

[jira] [Commented] (LUCENE-9888) Re-instate CheckIndex's attempts to confirm index sort is consistent across all segments

2021-03-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309981#comment-17309981 ] Robert Muir commented on LUCENE-9888: - yeah this is a wtf that checker found. i mech

[jira] [Commented] (LUCENE-9890) Retire @lucene.experimental tag and enforce @since tag for public classes

2021-03-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311454#comment-17311454 ] Robert Muir commented on LUCENE-9890: - I think the api is almost a lost cause at thi

[jira] [Resolved] (LUCENE-9893) Document or fix CodecUtil's codec requirements/limitations

2021-03-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9893. - Resolution: Not A Problem Not a limitation: this is a utility class, either you use it or you do

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314734#comment-17314734 ] Robert Muir commented on LUCENE-9855: - the "strategy" is a huge antipattern. lets sp

[jira] [Commented] (LUCENE-9855) Reconsider codec name VectorFormat

2021-04-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315813#comment-17315813 ] Robert Muir commented on LUCENE-9855: - {quote} For postings and doc values, we make

[jira] [Created] (LUCENE-9910) maximize javac lint

2021-04-06 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9910: --- Summary: maximize javac lint Key: LUCENE-9910 URL: https://issues.apache.org/jira/browse/LUCENE-9910 Project: Lucene - Core Issue Type: Task Report

[jira] [Created] (LUCENE-9911) enable ecjLint unusedExceptionParameter

2021-04-06 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9911: --- Summary: enable ecjLint unusedExceptionParameter Key: LUCENE-9911 URL: https://issues.apache.org/jira/browse/LUCENE-9911 Project: Lucene - Core Issue Type: Tas

[jira] [Resolved] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9827. - Fix Version/s: main (9.0) Resolution: Fixed > Small segments are slower to merge due to s

[jira] [Resolved] (LUCENE-9910) maximize javac lint

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9910. - Fix Version/s: main (9.0) Resolution: Fixed > maximize javac lint > --- >

[jira] [Resolved] (LUCENE-9882) better synchronize eclipse formatter with spotless

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9882. - Fix Version/s: main (9.0) Resolution: Fixed > better synchronize eclipse formatter with s

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316254#comment-17316254 ] Robert Muir commented on LUCENE-9827: - [~jpountz] I was thinking about it too, but w

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316391#comment-17316391 ] Robert Muir commented on LUCENE-9827: - [~jpountz] Oh, that's perfectly fine. I mista

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316710#comment-17316710 ] Robert Muir commented on LUCENE-9914: - [~dweiss] how hard would it be to depend on I

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316713#comment-17316713 ] Robert Muir commented on LUCENE-9914: - One little hurdle is that this perl script wa

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316719#comment-17316719 ] Robert Muir commented on LUCENE-9914: - E.g. current file is generated for unicode 11

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316744#comment-17316744 ] Robert Muir commented on LUCENE-9914: - This seems to print the current stuff that is

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317121#comment-17317121 ] Robert Muir commented on LUCENE-9914: - FYI: For the jflex we want the unicode versio

[jira] [Commented] (LUCENE-9913) TestCompressingTermVectorsFormat.testMergeStability can fail assertion

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317137#comment-17317137 ] Robert Muir commented on LUCENE-9913: - [~julietibs] I haven't dug into this test/fai

[jira] [Resolved] (LUCENE-9911) enable ecjLint unusedExceptionParameter

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9911. - Fix Version/s: main (9.0) Resolution: Fixed > enable ecjLint unusedExceptionParameter > -

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317145#comment-17317145 ] Robert Muir commented on LUCENE-9914: - yes, that one looks great: I think a similar

[jira] [Created] (LUCENE-9916) generateUnicodeProps doesn't work according to instructions, always SKIPPED

2021-04-08 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9916: --- Summary: generateUnicodeProps doesn't work according to instructions, always SKIPPED Key: LUCENE-9916 URL: https://issues.apache.org/jira/browse/LUCENE-9916 Project: Lu

[jira] [Commented] (LUCENE-9916) generateUnicodeProps doesn't work according to instructions, always SKIPPED

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317192#comment-17317192 ] Robert Muir commented on LUCENE-9916: - [~dweiss] I realize this looks like just a ge

[jira] [Commented] (LUCENE-9917) Reduce block size for BEST_COMPRESSION

2021-04-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317379#comment-17317379 ] Robert Muir commented on LUCENE-9917: - do you mean BEST_SPEED here? > Reduce block

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318517#comment-17318517 ] Robert Muir commented on LUCENE-9914: - I don't think we should do this at all. We ar

[jira] [Created] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-04-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9921: --- Summary: Can ICU regeneration tasks treat icu version as input? Key: LUCENE-9921 URL: https://issues.apache.org/jira/browse/LUCENE-9921 Project: Lucene - Core

[jira] [Created] (LUCENE-9922) checksums files should use deterministic sort order?

2021-04-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9922: --- Summary: checksums files should use deterministic sort order? Key: LUCENE-9922 URL: https://issues.apache.org/jira/browse/LUCENE-9922 Project: Lucene - Core Is

[jira] [Commented] (LUCENE-9922) checksums files should use deterministic sort order?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318525#comment-17318525 ] Robert Muir commented on LUCENE-9922: - I tend to also produce random file ordering c

[jira] [Commented] (LUCENE-9922) checksums files should use deterministic sort order?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318569#comment-17318569 ] Robert Muir commented on LUCENE-9922: - I have a PR coming... just wrap with treemap

[jira] [Commented] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318570#comment-17318570 ] Robert Muir commented on LUCENE-9921: - Yes it worked correctly for that task. I'll l

[jira] [Created] (LUCENE-9923) remove timestamp from generated ASCIITLD.jflex

2021-04-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9923: --- Summary: remove timestamp from generated ASCIITLD.jflex Key: LUCENE-9923 URL: https://issues.apache.org/jira/browse/LUCENE-9923 Project: Lucene - Core Issue Ty

[jira] [Commented] (LUCENE-9923) remove timestamp from generated ASCIITLD.jflex

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318578#comment-17318578 ] Robert Muir commented on LUCENE-9923: - I think we just want to remove the {{generate

[jira] [Commented] (LUCENE-9921) Can ICU regeneration tasks treat icu version as input?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318579#comment-17318579 ] Robert Muir commented on LUCENE-9921: - Can we point the location of the actual resol

[jira] [Resolved] (LUCENE-9922) checksums files should use deterministic sort order?

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9922. - Fix Version/s: main (9.0) Resolution: Fixed > checksums files should use deterministic so

[jira] [Resolved] (LUCENE-9923) remove timestamp from generated ASCIITLD.jflex

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9923. - Fix Version/s: main (9.0) Resolution: Fixed > remove timestamp from generated ASCIITLD.jf

[jira] [Created] (LUCENE-9924) regenerate TLD list from IANA TLD db, rather than root zone db

2021-04-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9924: --- Summary: regenerate TLD list from IANA TLD db, rather than root zone db Key: LUCENE-9924 URL: https://issues.apache.org/jira/browse/LUCENE-9924 Project: Lucene - Core

[jira] [Commented] (LUCENE-9924) regenerate TLD list from IANA TLD db, rather than root zone db

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318598#comment-17318598 ] Robert Muir commented on LUCENE-9924: - In other words, this change creates the same

[jira] [Commented] (LUCENE-9924) regenerate TLD list from IANA TLD db, rather than root zone db

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318597#comment-17318597 ] Robert Muir commented on LUCENE-9924: - No, this generator script explicitly wants on

[jira] [Commented] (LUCENE-9924) regenerate TLD list from IANA TLD db, rather than root zone db

2021-04-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318602#comment-17318602 ] Robert Muir commented on LUCENE-9924: - Matching puny-decoded form is different, I'm

[jira] [Resolved] (LUCENE-9924) regenerate TLD list from IANA TLD db, rather than root zone db

2021-04-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9924. - Fix Version/s: main (9.0) Resolution: Fixed > regenerate TLD list from IANA TLD db, rathe

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318939#comment-17318939 ] Robert Muir commented on LUCENE-9914: - [~dweiss] The emoji regeneration needs to be

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-04-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319486#comment-17319486 ] Robert Muir commented on LUCENE-9827: - [~jpountz] those cross-checks look good. one

[jira] [Created] (LUCENE-9926) remove last-modified timestamp from ASCIITLD.jflex

2021-04-12 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9926: --- Summary: remove last-modified timestamp from ASCIITLD.jflex Key: LUCENE-9926 URL: https://issues.apache.org/jira/browse/LUCENE-9926 Project: Lucene - Core Issu

[jira] [Commented] (LUCENE-9914) Modernize Emoji regeneration scripts

2021-04-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319681#comment-17319681 ] Robert Muir commented on LUCENE-9914: - Thanks [~dweiss]! Let's keep an eye on jflex

[jira] [Commented] (LUCENE-9927) Configurable BKDWriter maximum heap size

2021-04-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320144#comment-17320144 ] Robert Muir commented on LUCENE-9927: - I think it would be better to use the bugfixe

[jira] [Created] (LUCENE-9928) speed up analysis/icu regeneration

2021-04-13 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9928: --- Summary: speed up analysis/icu regeneration Key: LUCENE-9928 URL: https://issues.apache.org/jira/browse/LUCENE-9928 Project: Lucene - Core Issue Type: Task

[jira] [Commented] (LUCENE-9929) Make ScandinavianNormalizationFilter configurable wrt foldings

2021-04-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321068#comment-17321068 ] Robert Muir commented on LUCENE-9929: - Can we just add filters for each of the 3 lan

[jira] [Commented] (LUCENE-9929) Make ScandinavianNormalizationFilter configurable wrt foldings

2021-04-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321157#comment-17321157 ] Robert Muir commented on LUCENE-9929: - Adding new tokenfilters isn't a breaking chan

[jira] [Updated] (LUCENE-9843) Remove compression option on doc values

2021-04-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9843: Priority: Blocker (was: Minor) > Remove compression option on doc values > --

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-04-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321327#comment-17321327 ] Robert Muir commented on LUCENE-9843: - I moved this issue to a blocker for 9.0 becau

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-04-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17321328#comment-17321328 ] Robert Muir commented on LUCENE-9843: - Great example of why its important: for a whi

[jira] [Resolved] (LUCENE-9928) speed up analysis/icu regeneration

2021-04-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9928. - Fix Version/s: main (9.0) Resolution: Fixed > speed up analysis/icu regeneration > --

[jira] [Resolved] (LUCENE-9878) enable redundantNullCheck in ecjLint

2021-04-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9878. - Resolution: Fixed yes, oops! thanks [~mikemccand] > enable redundantNullCheck in ecjLint >

[jira] [Updated] (LUCENE-9878) enable redundantNullCheck in ecjLint

2021-04-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9878: Fix Version/s: main (9.0) > enable redundantNullCheck in ecjLint > ---

[jira] [Commented] (LUCENE-9939) Proper ASCII folding of Danish/Norwegian characters Ø, Å

2021-04-27 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333128#comment-17333128 ] Robert Muir commented on LUCENE-9939: - This isn't the way to go: these aren't the on

[jira] [Commented] (LUCENE-9946) Support multi-value fields in range facet counting

2021-04-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337498#comment-17337498 ] Robert Muir commented on LUCENE-9946: - I'm confused, why make the user provide a {{m

[jira] [Commented] (LUCENE-9946) Support multi-value fields in range facet counting

2021-04-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337741#comment-17337741 ] Robert Muir commented on LUCENE-9946: - {quote} I was aiming for consistency with the

[jira] [Resolved] (LUCENE-9188) Add jacoco code coverage support to gradle build

2021-05-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9188. - Fix Version/s: main (9.0) Resolution: Fixed > Add jacoco code coverage support to gradle

[jira] [Commented] (LUCENE-9948) Automatically detect multi- vs. single-valued cases in LongValueFacetCounts

2021-05-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338091#comment-17338091 ] Robert Muir commented on LUCENE-9948: - For 9.0, i wouldnt add back compat at all or

<    5   6   7   8   9   10   11   12   13   14   >