[ https://issues.apache.org/jira/browse/LUCENE-9856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306677#comment-17306677 ]
Robert Muir commented on LUCENE-9856: ------------------------------------- While wrestling with the PR, I found out about {{org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=enabled}}. So we were able to do it a lot easier (e.g. add {{SuppressWarnings("unused")}} to generated code). I don't think there is a need for any per-module config for this linter anymore. > Improve static analysis to catch dead code and other potential bugs > ------------------------------------------------------------------- > > Key: LUCENE-9856 > URL: https://issues.apache.org/jira/browse/LUCENE-9856 > Project: Lucene - Core > Issue Type: Improvement > Components: general/build > Reporter: Zach Chen > Priority: Minor > Labels: build > Attachments: LUCENE-9856.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > When working on PR [https://github.com/apache/lucene/pull/25,] we noticed > that some dead code is not being caught during static analysis in gradle > build, such as the *start* variable in the following code: > [https://github.com/apache/lucene/blob/a5996dbecd4a6b4147d961260711a2cb6aeab3d3/lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java#L446-L456] > > We may need to look at if additional javac compiler flag, or configuration > for *error prone,* should be added to catch such bug as well as other > potential ones. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org