mikemccand commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-847906215
Finally I ran `CheckIndex -threadCount 128`:
```
beast3:core[main]$ java -cp
../core/build/libs/lucene-core-9.0.0-SNAPSHOT.jar
org.apache.lucene.index.CheckIndex
mikemccand commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-847899963
Next I ran `CheckIndex` with `-threadCount 1`:
```
beast3:core[main]$ java -cp
../core/build/libs/lucene-core-9.0.0-SNAPSHOT.jar
org.apache.lucene.index.CheckIndex
mikemccand commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-847885348
OK I ran `CheckIndex`, with this PR, on last night's English Wikipedia
benchmark index:
```
beast3:core[main]$ java -cp
mikemccand commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-847869442
Our nightly benchmarks also exercise `CheckIndex` each night on a "real"
index, and sometimes that finds interesting surprises ;)
--
This is an automated message from the
mikemccand commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-847864069
> One thing I'm still researching is that, it seems there's limited direct
test coverage for this `CheckIndex` class? I see there's `TestCheckIndex`, but
it only has 4 tests,
mikemccand commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-841300744
I am excited to see what happens to [`CheckIndex` time in Lucene's nightly
benchmarks](https://home.apache.org/~mikemccand/lucenebench/checkIndexTime.html)
after we push this!
