[GitHub] [maven] mthmulders commented on pull request #388: Refactor ProjectsCollector.collectProjects

2020-10-29 Thread GitBox
mthmulders commented on pull request #388: URL: https://github.com/apache/maven/pull/388#issuecomment-719275697 [Jenkins build](https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/refactor-projectscollector-collectprojects-return-result/2/) is green. --

[jira] [Commented] (ARCHETYPE-613) Different gererating result with user defined parameters

2020-10-29 Thread Liu Shilong (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223420#comment-17223420 ] Liu Shilong commented on ARCHETYPE-613: --- I solve the problem, In fact ,it occurs

[jira] [Updated] (ARCHETYPE-613) Different gererating result with user defined parameters

2020-10-29 Thread Liu Shilong (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Shilong updated ARCHETYPE-613: -- Description: Happend in two different maven version 3.6.1 and 3.6.3, I defined my archetype

[jira] [Created] (ARCHETYPE-613) Different gererating result with user defined parameters

2020-10-29 Thread Liu Shilong (Jira)
Liu Shilong created ARCHETYPE-613: - Summary: Different gererating result with user defined parameters Key: ARCHETYPE-613 URL: https://issues.apache.org/jira/browse/ARCHETYPE-613 Project: Maven Archetyp

[jira] [Commented] (MWRAPPER-9) Ability to automatically download JRE

2020-10-29 Thread Manfred Moser (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223271#comment-17223271 ] Manfred Moser commented on MWRAPPER-9: -- I think thats beyond the scope of the wrappe

[jira] [Commented] (MWRAPPER-10) Checksums for maven-dists

2020-10-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223255#comment-17223255 ] Michael Osipov commented on MWRAPPER-10: Checksums are *not* intended to verify

[jira] [Commented] (MWRAPPER-9) Ability to automatically download JRE

2020-10-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223257#comment-17223257 ] Michael Osipov commented on MWRAPPER-9: --- + cattle of tea infusion? > Ability to au

[jira] [Commented] (MJLINK-9) Add support for multi module projects

2020-10-29 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223216#comment-17223216 ] Benjamin Marwell commented on MJLINK-9: --- Hi, I created an integration test case loca

[GitHub] [maven-archetypes] JurrianFahner edited a comment on pull request #5: Fix merge conflicts of PR #3

2020-10-29 Thread GitBox
JurrianFahner edited a comment on pull request #5: URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-719002625 @eolivelli Gentle ping... Could you review this PR? This is an automated message from the Apache

[GitHub] [maven-archetypes] JurrianFahner commented on pull request #5: Fix merge conflicts of PR #3

2020-10-29 Thread GitBox
JurrianFahner commented on pull request #5: URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-719002625 @eolivelli Could you review this PR? This is an automated message from the Apache Git Service. To respo

[GitHub] [maven] MartinKanters commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-29 Thread GitBox
MartinKanters commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r514502330 ## File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java ## @@ -236,9 +236,9 @@ public void testReadInvalidPom()

[jira] [Commented] (SUREFIRE-1852) ReporterException: When writing xml report stdout/stderr

2020-10-29 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223167#comment-17223167 ] Tibor Digana commented on SUREFIRE-1852: [~kgyrtkirk] As i can see your stackt

[jira] [Created] (MWRAPPER-10) Checksums for maven-dists

2020-10-29 Thread Yannick Menager (Jira)
Yannick Menager created MWRAPPER-10: --- Summary: Checksums for maven-dists Key: MWRAPPER-10 URL: https://issues.apache.org/jira/browse/MWRAPPER-10 Project: Maven Wrapper Issue Type: Bug

[jira] [Created] (MWRAPPER-9) Ability to automatically download JRE

2020-10-29 Thread Yannick Menager (Jira)
Yannick Menager created MWRAPPER-9: -- Summary: Ability to automatically download JRE Key: MWRAPPER-9 URL: https://issues.apache.org/jira/browse/MWRAPPER-9 Project: Maven Wrapper Issue Type: B

[GitHub] [maven] rfscholte commented on pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-29 Thread GitBox
rfscholte commented on pull request #386: URL: https://github.com/apache/maven/pull/386#issuecomment-718921546 if there are no objections, I'll merge this tomorrow This is an automated message from the Apache Git Service. To

[GitHub] [maven-compiler-plugin] elharo commented on a change in pull request #34: [MCOMPILER-428] improve incremental compilation documentation

2020-10-29 Thread GitBox
elharo commented on a change in pull request #34: URL: https://github.com/apache/maven-compiler-plugin/pull/34#discussion_r514368549 ## File path: src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java ## @@ -483,7 +483,19 @@ private List fileExtensions

[GitHub] [maven-compiler-plugin] sadraskol commented on pull request #34: [MCOMPILER-428] improve incremental compilation documentation

2020-10-29 Thread GitBox
sadraskol commented on pull request #34: URL: https://github.com/apache/maven-compiler-plugin/pull/34#issuecomment-718818351 I've pushed the modification with the usage of present tense and a modulation to specify that the description is javac-specific. Thanks for your feedbacks! --

[GitHub] [maven-jlink-plugin] sparsick commented on pull request #9: [MJLINK-50] upgrade to Java 8 / Maven 3.1.0

2020-10-29 Thread GitBox
sparsick commented on pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#issuecomment-718777426 @bmhm :+1: I changed it This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [maven-jlink-plugin] bmhm commented on a change in pull request #9: [MJLINK-50] upgrade to Java 8 / Maven 3.1.0

2020-10-29 Thread GitBox
bmhm commented on a change in pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r514263074 ## File path: pom.xml ## @@ -118,42 +117,76 @@ org.mockito mockito-core - 2.19.0 + 3.5.13 test o

[jira] [Commented] (MJLINK-50) upgrade to Java 8 / Maven 3.1.0

2020-10-29 Thread Sandra Parsick (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222809#comment-17222809 ] Sandra Parsick commented on MJLINK-50: -- Update the issue after disussion in the PR #9

[jira] [Updated] (MJLINK-50) upgrade to Java 8 / Maven 3.1.0

2020-10-29 Thread Sandra Parsick (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandra Parsick updated MJLINK-50: - Description: Currently, the base jdk and maven is 1.7 and 3.0.0. (was: To support the module sys

[jira] [Updated] (MJLINK-50) upgrade to Java 8 / Maven 3.1.0

2020-10-29 Thread Sandra Parsick (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandra Parsick updated MJLINK-50: - Summary: upgrade to Java 8 / Maven 3.1.0 (was: Upgrade to Java 11) > upgrade to Java 8 / Maven 3.

[GitHub] [maven-jlink-plugin] sparsick commented on pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-29 Thread GitBox
sparsick commented on pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#issuecomment-718578254 @bmhm good point. Thank you. I will update the issue This is an automated message from the Apache Git Serv

[GitHub] [maven-jlink-plugin] sparsick commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-29 Thread GitBox
sparsick commented on a change in pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r514121512 ## File path: pom.xml ## @@ -146,7 +169,7 @@ 3.0.0-M3 - enforce-bytecode-version + en

[GitHub] [maven-jlink-plugin] sparsick commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-29 Thread GitBox
sparsick commented on a change in pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r514121647 ## File path: pom.xml ## @@ -67,6 +67,7 @@ 3.1.0 8 +8 Review comment: Fix see next commit ---

[GitHub] [maven-jlink-plugin] sparsick commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-29 Thread GitBox
sparsick commented on a change in pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r514105741 ## File path: pom.xml ## @@ -146,7 +169,7 @@ 3.0.0-M3 - enforce-bytecode-version + en

[GitHub] [maven-jlink-plugin] sparsick commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-29 Thread GitBox
sparsick commented on a change in pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r514103082 ## File path: pom.xml ## @@ -67,6 +67,7 @@ 3.1.0 8 +8 Review comment: I had to insert this property because enforcer-mave

[GitHub] [maven-jlink-plugin] sparsick commented on pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-29 Thread GitBox
sparsick commented on pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#issuecomment-718475463 @rfscholte @aalmiray Thanks for your review. I change the pom to address your comment. This is an automat

[GitHub] [maven-jlink-plugin] bmhm commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

2020-10-29 Thread GitBox
bmhm commented on a change in pull request #9: URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r513802569 ## File path: pom.xml ## @@ -66,8 +66,7 @@ 3.0 -1.7 -1.7 +11 Review comment: But jlink doesn't come with java 8?

[jira] [Comment Edited] (MENFORCER-360) requireUpperBoundDeps should have option to check for same major version

2020-10-29 Thread Zhenlei Huang (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222698#comment-17222698 ] Zhenlei Huang edited comment on MENFORCER-360 at 10/29/20, 7:15 AM: